mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-01 00:49:30 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
66 lines
2.5 KiB
Rust
66 lines
2.5 KiB
Rust
use clippy_utils::consts::{constant_simple, Constant};
|
|
use clippy_utils::diagnostics::span_lint_and_help;
|
|
use if_chain::if_chain;
|
|
use rustc_hir::{BinOpKind, Expr, ExprKind};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for `0.0 / 0.0`.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// It's less readable than `f32::NAN` or `f64::NAN`.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// // Bad
|
|
/// let nan = 0.0f32 / 0.0;
|
|
///
|
|
/// // Good
|
|
/// let nan = f32::NAN;
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub ZERO_DIVIDED_BY_ZERO,
|
|
complexity,
|
|
"usage of `0.0 / 0.0` to obtain NaN instead of `f32::NAN` or `f64::NAN`"
|
|
}
|
|
|
|
declare_lint_pass!(ZeroDiv => [ZERO_DIVIDED_BY_ZERO]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for ZeroDiv {
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
|
|
// check for instances of 0.0/0.0
|
|
if_chain! {
|
|
if let ExprKind::Binary(ref op, left, right) = expr.kind;
|
|
if op.node == BinOpKind::Div;
|
|
// TODO - constant_simple does not fold many operations involving floats.
|
|
// That's probably fine for this lint - it's pretty unlikely that someone would
|
|
// do something like 0.0/(2.0 - 2.0), but it would be nice to warn on that case too.
|
|
if let Some(lhs_value) = constant_simple(cx, cx.typeck_results(), left);
|
|
if let Some(rhs_value) = constant_simple(cx, cx.typeck_results(), right);
|
|
if Constant::F32(0.0) == lhs_value || Constant::F64(0.0) == lhs_value;
|
|
if Constant::F32(0.0) == rhs_value || Constant::F64(0.0) == rhs_value;
|
|
then {
|
|
// since we're about to suggest a use of f32::NAN or f64::NAN,
|
|
// match the precision of the literals that are given.
|
|
let float_type = match (lhs_value, rhs_value) {
|
|
(Constant::F64(_), _)
|
|
| (_, Constant::F64(_)) => "f64",
|
|
_ => "f32"
|
|
};
|
|
span_lint_and_help(
|
|
cx,
|
|
ZERO_DIVIDED_BY_ZERO,
|
|
expr.span,
|
|
"constant division of `0.0` with `0.0` will always result in NaN",
|
|
None,
|
|
&format!(
|
|
"consider using `{}::NAN` if you would like a constant representing NaN",
|
|
float_type,
|
|
),
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|