mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-14 00:47:16 +00:00
98 lines
3.6 KiB
Rust
98 lines
3.6 KiB
Rust
//@no-rustfix: overlapping suggestions
|
|
#![allow(clippy::let_unit_value, clippy::unnecessary_cast)]
|
|
|
|
fn main() {
|
|
let x: [i32; 3] = [1_i32, 2, 3];
|
|
let r_x = &x;
|
|
// Check casting through multiple bindings
|
|
// Because it's separate, it does not check the cast back to something of the same size
|
|
let a = r_x as *const [i32];
|
|
let b = a as *const [u8];
|
|
//~^ ERROR: casting between raw pointers to `[i32]` (element size 4) and `[u8]` (eleme
|
|
//~| NOTE: `#[deny(clippy::cast_slice_different_sizes)]` on by default
|
|
let c = b as *const [u32];
|
|
//~^ ERROR: casting between raw pointers to `[u8]` (element size 1) and `[u32]` (eleme
|
|
|
|
// loses data
|
|
let loss = r_x as *const [i32] as *const [u8];
|
|
//~^ ERROR: casting between raw pointers to `[i32]` (element size 4) and `[u8]` (eleme
|
|
|
|
// Cast back to same size but different type loses no data, just type conversion
|
|
// This is weird code but there's no reason for this lint specifically to fire *twice* on it
|
|
let restore = r_x as *const [i32] as *const [u8] as *const [u32];
|
|
|
|
// Check casting through blocks is detected
|
|
let loss_block_1 = { r_x as *const [i32] } as *const [u8];
|
|
//~^ ERROR: casting between raw pointers to `[i32]` (element size 4) and `[u8]` (eleme
|
|
let loss_block_2 = {
|
|
//~^ ERROR: casting between raw pointers to `[i32]` (element size 4) and `[u8]` (eleme
|
|
let _ = ();
|
|
r_x as *const [i32]
|
|
} as *const [u8];
|
|
|
|
// Check that resources of the same size are detected through blocks
|
|
let restore_block_1 = { r_x as *const [i32] } as *const [u8] as *const [u32];
|
|
let restore_block_2 = { ({ r_x as *const [i32] }) as *const [u8] } as *const [u32];
|
|
let restore_block_3 = {
|
|
let _ = ();
|
|
({
|
|
let _ = ();
|
|
r_x as *const [i32]
|
|
}) as *const [u8]
|
|
} as *const [u32];
|
|
|
|
// Check that the result of a long chain of casts is detected
|
|
let long_chain_loss = r_x as *const [i32] as *const [u32] as *const [u16] as *const [i8] as *const [u8];
|
|
//~^ ERROR: casting between raw pointers to `[i32]` (element size 4) and `[u8]` (eleme
|
|
let long_chain_restore =
|
|
r_x as *const [i32] as *const [u32] as *const [u16] as *const [i8] as *const [u8] as *const [u32];
|
|
}
|
|
|
|
// foo and foo2 should not fire, they're the same size
|
|
fn foo(x: *mut [u8]) -> *mut [u8] {
|
|
x as *mut [u8]
|
|
}
|
|
|
|
fn foo2(x: *mut [u8]) -> *mut [u8] {
|
|
x as *mut _
|
|
}
|
|
|
|
// Test that casts as part of function returns work
|
|
fn bar(x: *mut [u16]) -> *mut [u8] {
|
|
//~^ ERROR: casting between raw pointers to `[u16]` (element size 2) and `[u8]` (element s
|
|
x as *mut [u8]
|
|
}
|
|
|
|
fn uwu(x: *mut [u16]) -> *mut [u8] {
|
|
//~^ ERROR: casting between raw pointers to `[u16]` (element size 2) and `[u8]` (element s
|
|
x as *mut _
|
|
}
|
|
|
|
fn bar2(x: *mut [u16]) -> *mut [u8] {
|
|
//~^ ERROR: casting between raw pointers to `[u16]` (element size 2) and `[u8]` (element s
|
|
x as _
|
|
}
|
|
|
|
// constify
|
|
fn bar3(x: *mut [u16]) -> *const [u8] {
|
|
//~^ ERROR: casting between raw pointers to `[u16]` (element size 2) and `[u8]` (element s
|
|
x as _
|
|
}
|
|
|
|
// unconstify
|
|
fn bar4(x: *const [u16]) -> *mut [u8] {
|
|
//~^ ERROR: casting between raw pointers to `[u16]` (element size 2) and `[u8]` (element s
|
|
x as _
|
|
}
|
|
|
|
// function returns plus blocks
|
|
fn blocks(x: *mut [u16]) -> *mut [u8] {
|
|
//~^ ERROR: casting between raw pointers to `[u16]` (element size 2) and `[u8]` (element s
|
|
({ x }) as _
|
|
}
|
|
|
|
fn more_blocks(x: *mut [u16]) -> *mut [u8] {
|
|
//~^ ERROR: casting between raw pointers to `[u16]` (element size 2) and `[u8]` (element s
|
|
{ ({ x }) as _ }
|
|
//~^ ERROR: casting between raw pointers to `[u16]` (element size 2) and `[u8]` (eleme
|
|
}
|