mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-09-20 14:41:58 +00:00
34 lines
950 B
Text
34 lines
950 B
Text
error: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
|
|
--> $DIR/blocks_in_if_conditions.rs:24:5
|
|
|
|
|
LL | / if {
|
|
LL | | let x = 3;
|
|
LL | | x == 3
|
|
LL | | } {
|
|
| |_____^
|
|
|
|
|
= note: `-D clippy::blocks-in-if-conditions` implied by `-D warnings`
|
|
help: try
|
|
|
|
|
LL ~ let res = {
|
|
LL + let x = 3;
|
|
LL + x == 3
|
|
LL ~ }; if res {
|
|
|
|
|
|
|
error: omit braces around single expression condition
|
|
--> $DIR/blocks_in_if_conditions.rs:35:8
|
|
|
|
|
LL | if { true } { 6 } else { 10 }
|
|
| ^^^^^^^^ help: try: `true`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/blocks_in_if_conditions.rs:40:8
|
|
|
|
|
LL | if true && x == 3 { 6 } else { 10 }
|
|
| ^^^^^^^^^^^^^^ help: try: `x == 3`
|
|
|
|
|
= note: `-D clippy::nonminimal-bool` implied by `-D warnings`
|
|
|
|
error: aborting due to 3 previous errors
|
|
|