mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-23 19:43:20 +00:00
2547edb842
When a method starts with `to_` and ends with `_mut`, it should expect a `&mut self` parameter, otherwise `&self`.
195 lines
5.5 KiB
Text
195 lines
5.5 KiB
Text
error: methods called `from_*` usually take no self
|
|
--> $DIR/wrong_self_convention.rs:18:17
|
|
|
|
|
LL | fn from_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= note: `-D clippy::wrong-self-convention` implied by `-D warnings`
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `from_*` usually take no self
|
|
--> $DIR/wrong_self_convention.rs:24:21
|
|
|
|
|
LL | pub fn from_i64(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `as_*` usually take self by reference or self by mutable reference
|
|
--> $DIR/wrong_self_convention.rs:36:15
|
|
|
|
|
LL | fn as_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `into_*` usually take self by value
|
|
--> $DIR/wrong_self_convention.rs:38:17
|
|
|
|
|
LL | fn into_i32(&self) {}
|
|
| ^^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `is_*` usually take self by reference or no self
|
|
--> $DIR/wrong_self_convention.rs:40:15
|
|
|
|
|
LL | fn is_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `to_*` usually take self by reference
|
|
--> $DIR/wrong_self_convention.rs:42:15
|
|
|
|
|
LL | fn to_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `from_*` usually take no self
|
|
--> $DIR/wrong_self_convention.rs:44:17
|
|
|
|
|
LL | fn from_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `as_*` usually take self by reference or self by mutable reference
|
|
--> $DIR/wrong_self_convention.rs:46:19
|
|
|
|
|
LL | pub fn as_i64(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `into_*` usually take self by value
|
|
--> $DIR/wrong_self_convention.rs:47:21
|
|
|
|
|
LL | pub fn into_i64(&self) {}
|
|
| ^^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `is_*` usually take self by reference or no self
|
|
--> $DIR/wrong_self_convention.rs:48:19
|
|
|
|
|
LL | pub fn is_i64(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `to_*` usually take self by reference
|
|
--> $DIR/wrong_self_convention.rs:49:19
|
|
|
|
|
LL | pub fn to_i64(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `from_*` usually take no self
|
|
--> $DIR/wrong_self_convention.rs:50:21
|
|
|
|
|
LL | pub fn from_i64(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `as_*` usually take self by reference or self by mutable reference
|
|
--> $DIR/wrong_self_convention.rs:95:19
|
|
|
|
|
LL | fn as_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `into_*` usually take self by value
|
|
--> $DIR/wrong_self_convention.rs:98:25
|
|
|
|
|
LL | fn into_i32_ref(&self) {}
|
|
| ^^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `is_*` usually take self by reference or no self
|
|
--> $DIR/wrong_self_convention.rs:100:19
|
|
|
|
|
LL | fn is_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `to_*` usually take self by reference
|
|
--> $DIR/wrong_self_convention.rs:102:19
|
|
|
|
|
LL | fn to_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `from_*` usually take no self
|
|
--> $DIR/wrong_self_convention.rs:104:21
|
|
|
|
|
LL | fn from_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `as_*` usually take self by reference or self by mutable reference
|
|
--> $DIR/wrong_self_convention.rs:119:19
|
|
|
|
|
LL | fn as_i32(self);
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `into_*` usually take self by value
|
|
--> $DIR/wrong_self_convention.rs:122:25
|
|
|
|
|
LL | fn into_i32_ref(&self);
|
|
| ^^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `is_*` usually take self by reference or no self
|
|
--> $DIR/wrong_self_convention.rs:124:19
|
|
|
|
|
LL | fn is_i32(self);
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `to_*` usually take self by reference
|
|
--> $DIR/wrong_self_convention.rs:126:19
|
|
|
|
|
LL | fn to_i32(self);
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `from_*` usually take no self
|
|
--> $DIR/wrong_self_convention.rs:128:21
|
|
|
|
|
LL | fn from_i32(self);
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `into_*` usually take self by value
|
|
--> $DIR/wrong_self_convention.rs:146:25
|
|
|
|
|
LL | fn into_i32_ref(&self);
|
|
| ^^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `from_*` usually take no self
|
|
--> $DIR/wrong_self_convention.rs:152:21
|
|
|
|
|
LL | fn from_i32(self);
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: aborting due to 24 previous errors
|
|
|