mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 13:43:17 +00:00
a41cb7adbe
* add `rest_arg` to pass second argument from `map_or(U, F)` * extract some procedures into closure refac: rename rest_arg/second_arg refac: organize function argument order * put `second_arg` next to `arg` argument
41 lines
1.3 KiB
Text
41 lines
1.3 KiB
Text
error: this pattern reimplements `Option::ok_or`
|
|
--> $DIR/manual_ok_or.rs:12:5
|
|
|
|
|
LL | foo.map_or(Err("error"), |v| Ok(v));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `foo.ok_or("error")`
|
|
|
|
|
= note: `-D clippy::manual-ok-or` implied by `-D warnings`
|
|
|
|
error: this pattern reimplements `Option::ok_or`
|
|
--> $DIR/manual_ok_or.rs:15:5
|
|
|
|
|
LL | foo.map_or(Err("error"), Ok);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `foo.ok_or("error")`
|
|
|
|
error: this pattern reimplements `Option::ok_or`
|
|
--> $DIR/manual_ok_or.rs:18:5
|
|
|
|
|
LL | None::<i32>.map_or(Err("error"), |v| Ok(v));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `None::<i32>.ok_or("error")`
|
|
|
|
error: this pattern reimplements `Option::ok_or`
|
|
--> $DIR/manual_ok_or.rs:22:5
|
|
|
|
|
LL | / foo.map_or(Err::<i32, &str>(
|
|
LL | | &format!(
|
|
LL | | "{}{}{}{}{}{}{}",
|
|
LL | | "Alice", "Bob", "Sarah", "Marc", "Sandra", "Eric", "Jenifer")
|
|
LL | | ),
|
|
LL | | |v| Ok(v),
|
|
LL | | );
|
|
| |_____^
|
|
|
|
|
help: replace with
|
|
|
|
|
LL ~ foo.ok_or(&format!(
|
|
LL + "{}{}{}{}{}{}{}",
|
|
LL ~ "Alice", "Bob", "Sarah", "Marc", "Sandra", "Eric", "Jenifer"));
|
|
|
|
|
|
|
error: aborting due to 4 previous errors
|
|
|