rust-clippy/tests/ui/needless_borrowed_ref.fixed
2023-06-10 06:51:03 -05:00

124 lines
2.8 KiB
Rust

//@run-rustfix
#![warn(clippy::needless_borrowed_reference)]
#![allow(
unused,
irrefutable_let_patterns,
non_shorthand_field_patterns,
clippy::needless_borrow,
clippy::needless_if
)]
fn main() {}
struct Struct {
a: usize,
b: usize,
c: usize,
}
struct TupleStruct(u8, u8, u8);
fn should_lint(
array: [u8; 4],
slice: &[u8],
slice_of_refs: &[&u8],
vec: Vec<u8>,
tuple: (u8, u8, u8),
tuple_struct: TupleStruct,
s: Struct,
) {
let mut v = Vec::<String>::new();
let _ = v.iter_mut().filter(|a| a.is_empty());
let var = 3;
let thingy = Some(&var);
if let Some(v) = thingy {}
if let &[a, ref b] = slice_of_refs {}
let [a, ..] = &array;
let [a, b, ..] = &array;
if let [a, b] = slice {}
if let [a, b] = &vec[..] {}
if let [a, b, ..] = slice {}
if let [a, .., b] = slice {}
if let [.., a, b] = slice {}
if let [a, _] = slice {}
if let (a, b, c) = &tuple {}
if let (a, _, c) = &tuple {}
if let (a, ..) = &tuple {}
if let TupleStruct(a, ..) = &tuple_struct {}
if let Struct {
a,
b: b,
c: renamed,
} = &s
{}
if let Struct { a, b: _, .. } = &s {}
}
fn should_not_lint(
array: [u8; 4],
slice: &[u8],
slice_of_refs: &[&u8],
vec: Vec<u8>,
tuple: (u8, u8, u8),
tuple_struct: TupleStruct,
s: Struct,
) {
if let [ref a] = slice {}
if let &[ref a, b] = slice {}
if let &[ref a, .., b] = slice {}
if let &(ref a, b, ..) = &tuple {}
if let &TupleStruct(ref a, b, ..) = &tuple_struct {}
if let &Struct { ref a, b, .. } = &s {}
// must not be removed as variables must be bound consistently across | patterns
if let (&[ref a], _) | ([], ref a) = (slice_of_refs, &1u8) {}
// the `&`s here technically could be removed, but it'd be noisy and without a `ref` doesn't match
// the lint name
if let &[] = slice {}
if let &[_] = slice {}
if let &[..] = slice {}
if let &(..) = &tuple {}
if let &TupleStruct(..) = &tuple_struct {}
if let &Struct { .. } = &s {}
let mut var2 = 5;
let thingy2 = Some(&mut var2);
if let Some(&mut ref mut v) = thingy2 {
// ^ should **not** be linted
// v is borrowed as mutable.
*v = 10;
}
if let Some(&mut ref v) = thingy2 {
// ^ should **not** be linted
// here, v is borrowed as immutable.
// can't do that:
//*v = 15;
}
}
enum Animal {
Cat(u64),
Dog(u64),
}
fn foo(a: &Animal, b: &Animal) {
match (a, b) {
// lifetime mismatch error if there is no '&ref' before `feature(nll)` stabilization in 1.63
(&Animal::Cat(v), &ref k) | (&ref k, &Animal::Cat(v)) => (),
// ^ and ^ should **not** be linted
(Animal::Dog(a), &Animal::Dog(_)) => (),
}
}