mirror of
https://github.com/rust-lang/rust-clippy
synced 2025-01-02 00:09:08 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
96 lines
3.4 KiB
Rust
96 lines
3.4 KiB
Rust
//! Lint on unnecessary double comparisons. Some examples:
|
|
|
|
use clippy_utils::diagnostics::span_lint_and_sugg;
|
|
use clippy_utils::eq_expr_value;
|
|
use clippy_utils::source::snippet_with_applicability;
|
|
use rustc_errors::Applicability;
|
|
use rustc_hir::{BinOpKind, Expr, ExprKind};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use rustc_span::source_map::Span;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for double comparisons that could be simplified to a single expression.
|
|
///
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Readability.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// # let x = 1;
|
|
/// # let y = 2;
|
|
/// if x == y || x < y {}
|
|
/// ```
|
|
///
|
|
/// Could be written as:
|
|
///
|
|
/// ```rust
|
|
/// # let x = 1;
|
|
/// # let y = 2;
|
|
/// if x <= y {}
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub DOUBLE_COMPARISONS,
|
|
complexity,
|
|
"unnecessary double comparisons that can be simplified"
|
|
}
|
|
|
|
declare_lint_pass!(DoubleComparisons => [DOUBLE_COMPARISONS]);
|
|
|
|
impl<'tcx> DoubleComparisons {
|
|
#[allow(clippy::similar_names)]
|
|
fn check_binop(cx: &LateContext<'tcx>, op: BinOpKind, lhs: &'tcx Expr<'_>, rhs: &'tcx Expr<'_>, span: Span) {
|
|
let (lkind, llhs, lrhs, rkind, rlhs, rrhs) = match (&lhs.kind, &rhs.kind) {
|
|
(ExprKind::Binary(lb, llhs, lrhs), ExprKind::Binary(rb, rlhs, rrhs)) => {
|
|
(lb.node, llhs, lrhs, rb.node, rlhs, rrhs)
|
|
},
|
|
_ => return,
|
|
};
|
|
if !(eq_expr_value(cx, llhs, rlhs) && eq_expr_value(cx, lrhs, rrhs)) {
|
|
return;
|
|
}
|
|
macro_rules! lint_double_comparison {
|
|
($op:tt) => {{
|
|
let mut applicability = Applicability::MachineApplicable;
|
|
let lhs_str = snippet_with_applicability(cx, llhs.span, "", &mut applicability);
|
|
let rhs_str = snippet_with_applicability(cx, lrhs.span, "", &mut applicability);
|
|
let sugg = format!("{} {} {}", lhs_str, stringify!($op), rhs_str);
|
|
span_lint_and_sugg(
|
|
cx,
|
|
DOUBLE_COMPARISONS,
|
|
span,
|
|
"this binary expression can be simplified",
|
|
"try",
|
|
sugg,
|
|
applicability,
|
|
);
|
|
}};
|
|
}
|
|
#[rustfmt::skip]
|
|
match (op, lkind, rkind) {
|
|
(BinOpKind::Or, BinOpKind::Eq, BinOpKind::Lt) | (BinOpKind::Or, BinOpKind::Lt, BinOpKind::Eq) => {
|
|
lint_double_comparison!(<=);
|
|
},
|
|
(BinOpKind::Or, BinOpKind::Eq, BinOpKind::Gt) | (BinOpKind::Or, BinOpKind::Gt, BinOpKind::Eq) => {
|
|
lint_double_comparison!(>=);
|
|
},
|
|
(BinOpKind::Or, BinOpKind::Lt, BinOpKind::Gt) | (BinOpKind::Or, BinOpKind::Gt, BinOpKind::Lt) => {
|
|
lint_double_comparison!(!=);
|
|
},
|
|
(BinOpKind::And, BinOpKind::Le, BinOpKind::Ge) | (BinOpKind::And, BinOpKind::Ge, BinOpKind::Le) => {
|
|
lint_double_comparison!(==);
|
|
},
|
|
_ => (),
|
|
};
|
|
}
|
|
}
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for DoubleComparisons {
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
|
|
if let ExprKind::Binary(ref kind, lhs, rhs) = expr.kind {
|
|
Self::check_binop(cx, kind.node, lhs, rhs, expr.span);
|
|
}
|
|
}
|
|
}
|