rust-clippy/tests/ui/match_expr_like_matches_macro.fixed

212 lines
4 KiB
Rust

#![warn(clippy::match_like_matches_macro)]
#![allow(
unreachable_patterns,
dead_code,
clippy::equatable_if_let,
clippy::needless_borrowed_reference,
clippy::redundant_guards
)]
fn main() {
let x = Some(5);
// Lint
let _y = matches!(x, Some(0));
// Lint
let _w = x.is_some();
// Turn into is_none
let _z = x.is_none();
// Lint
let _zz = !matches!(x, Some(r) if r == 0);
// Lint
let _zzz = matches!(x, Some(5));
// No lint
let _a = match x {
Some(_) => false,
_ => false,
};
// No lint
let _ab = match x {
Some(0) => false,
_ => true,
None => false,
};
enum E {
A(u32),
B(i32),
C,
D,
}
let x = E::A(2);
{
// lint
let _ans = matches!(x, E::A(_) | E::B(_));
}
{
// lint
// skip rustfmt to prevent removing block for first pattern
#[rustfmt::skip]
let _ans = matches!(x, E::A(_) | E::B(_));
}
{
// lint
let _ans = !matches!(x, E::B(_) | E::C);
}
{
// no lint
let _ans = match x {
E::A(_) => false,
E::B(_) => false,
E::C => true,
_ => true,
};
}
{
// no lint
let _ans = match x {
E::A(_) => true,
E::B(_) => false,
E::C => false,
_ => true,
};
}
{
// no lint
let _ans = match x {
E::A(a) if a < 10 => false,
E::B(a) if a < 10 => false,
_ => true,
};
}
{
// no lint
let _ans = match x {
E::A(_) => false,
E::B(a) if a < 10 => false,
_ => true,
};
}
{
// no lint
let _ans = match x {
E::A(a) => a == 10,
E::B(_) => false,
_ => true,
};
}
{
// no lint
let _ans = match x {
E::A(_) => false,
E::B(_) => true,
_ => false,
};
}
{
// should print "z" in suggestion (#6503)
let z = &Some(3);
let _z = matches!(z, Some(3));
}
{
// this could also print "z" in suggestion..?
let z = Some(3);
let _z = matches!(&z, Some(3));
}
{
enum AnEnum {
X,
Y,
}
fn foo(_x: AnEnum) {}
fn main() {
let z = AnEnum::X;
// we can't remove the reference here!
let _ = matches!(&z, AnEnum::X);
foo(z);
}
}
{
struct S(i32);
fn fun(_val: Option<S>) {}
let val = Some(S(42));
// we need the reference here because later val is consumed by fun()
let _res = matches!(&val, &Some(ref _a));
fun(val);
}
{
struct S(i32);
fn fun(_val: Option<S>) {}
let val = Some(S(42));
let _res = matches!(&val, &Some(ref _a));
fun(val);
}
{
enum E {
A,
B,
C,
}
let _ = match E::A {
E::B => true,
#[cfg(feature = "foo")]
E::A => true,
_ => false,
};
}
let x = ' ';
// ignore if match block contains comment
let _line_comments = match x {
// numbers are bad!
'1' | '2' | '3' => true,
// spaces are very important to be true.
' ' => true,
// as are dots
'.' => true,
_ => false,
};
let _block_comments = match x {
/* numbers are bad!
*/
'1' | '2' | '3' => true,
/* spaces are very important to be true.
*/
' ' => true,
/* as are dots
*/
'.' => true,
_ => false,
};
}
#[clippy::msrv = "1.41"]
fn msrv_1_41() {
let _y = match Some(5) {
Some(0) => true,
_ => false,
};
}
#[clippy::msrv = "1.42"]
fn msrv_1_42() {
let _y = matches!(Some(5), Some(0));
}