mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-10 23:24:24 +00:00
9a002e52e5
Add lint for reference to Cow to the same place in the code where lint for reference to String lives. https://github.com/rust-lang-nursery/rust-clippy/issues/2405
52 lines
1.9 KiB
Text
52 lines
1.9 KiB
Text
error: this expression borrows a reference that is immediately dereferenced by the compiler
|
|
--> $DIR/needless_borrow.rs:13:15
|
|
|
|
|
13 | let c = x(&&a);
|
|
| ^^^ help: change this to: `&a`
|
|
|
|
|
= note: `-D needless-borrow` implied by `-D warnings`
|
|
|
|
error: this pattern creates a reference to a reference
|
|
--> $DIR/needless_borrow.rs:20:17
|
|
|
|
|
20 | if let Some(ref cake) = Some(&5) {}
|
|
| ^^^^^^^^ help: change this to: `cake`
|
|
|
|
error: this expression borrows a reference that is immediately dereferenced by the compiler
|
|
--> $DIR/needless_borrow.rs:27:15
|
|
|
|
|
27 | 46 => &&a,
|
|
| ^^^ help: change this to: `&a`
|
|
|
|
error: this pattern takes a reference on something that is being de-referenced
|
|
--> $DIR/needless_borrow.rs:49:34
|
|
|
|
|
49 | let _ = v.iter_mut().filter(|&ref a| a.is_empty());
|
|
| ^^^^^^ help: try removing the `&ref` part and just keep: `a`
|
|
|
|
|
= note: `-D needless-borrowed-reference` implied by `-D warnings`
|
|
|
|
error: this pattern takes a reference on something that is being de-referenced
|
|
--> $DIR/needless_borrow.rs:50:30
|
|
|
|
|
50 | let _ = v.iter().filter(|&ref a| a.is_empty());
|
|
| ^^^^^^ help: try removing the `&ref` part and just keep: `a`
|
|
|
|
error: this pattern creates a reference to a reference
|
|
--> $DIR/needless_borrow.rs:50:31
|
|
|
|
|
50 | let _ = v.iter().filter(|&ref a| a.is_empty());
|
|
| ^^^^^ help: change this to: `a`
|
|
|
|
a> $DIR/needless_borrow.rs:56:25: 56:36
|
|
b> $DIR/needless_borrow.rs:56:25: 56:36
|
|
error: using a reference to `Cow` is not recommended.
|
|
--> $DIR/needless_borrow.rs:56:25
|
|
|
|
|
56 | fn test_cow_with_ref(c: &Cow<[i32]>) {
|
|
| ^^^^^^^^^^^ help: change this to: `Cow<[i32]>`
|
|
|
|
|
= note: `-D ptr-arg` implied by `-D warnings`
|
|
|
|
error: aborting due to 7 previous errors
|
|
|