mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-28 07:30:57 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
60 lines
1.9 KiB
Rust
60 lines
1.9 KiB
Rust
//! checks for `#[inline]` on trait methods without bodies
|
|
|
|
use clippy_utils::diagnostics::span_lint_and_then;
|
|
use clippy_utils::sugg::DiagnosticBuilderExt;
|
|
use rustc_ast::ast::Attribute;
|
|
use rustc_errors::Applicability;
|
|
use rustc_hir::{TraitFn, TraitItem, TraitItemKind};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use rustc_span::{sym, Symbol};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for `#[inline]` on trait methods without bodies
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Only implementations of trait methods may be inlined.
|
|
/// The inline attribute is ignored for trait methods without bodies.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// trait Animal {
|
|
/// #[inline]
|
|
/// fn name(&self) -> &'static str;
|
|
/// }
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub INLINE_FN_WITHOUT_BODY,
|
|
correctness,
|
|
"use of `#[inline]` on trait methods without bodies"
|
|
}
|
|
|
|
declare_lint_pass!(InlineFnWithoutBody => [INLINE_FN_WITHOUT_BODY]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for InlineFnWithoutBody {
|
|
fn check_trait_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx TraitItem<'_>) {
|
|
if let TraitItemKind::Fn(_, TraitFn::Required(_)) = item.kind {
|
|
let attrs = cx.tcx.hir().attrs(item.hir_id());
|
|
check_attrs(cx, item.ident.name, attrs);
|
|
}
|
|
}
|
|
}
|
|
|
|
fn check_attrs(cx: &LateContext<'_>, name: Symbol, attrs: &[Attribute]) {
|
|
for attr in attrs {
|
|
if !attr.has_name(sym::inline) {
|
|
continue;
|
|
}
|
|
|
|
span_lint_and_then(
|
|
cx,
|
|
INLINE_FN_WITHOUT_BODY,
|
|
attr.span,
|
|
&format!("use of `#[inline]` on trait method `{}` which has no body", name),
|
|
|diag| {
|
|
diag.suggest_remove_item(cx, attr.span, "remove", Applicability::MachineApplicable);
|
|
},
|
|
);
|
|
}
|
|
}
|