mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 13:43:17 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
59 lines
1.7 KiB
Rust
59 lines
1.7 KiB
Rust
use clippy_utils::consts::{constant_simple, Constant};
|
|
use clippy_utils::diagnostics::span_lint;
|
|
use rustc_hir::{BinOpKind, Expr, ExprKind};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use rustc_span::source_map::Span;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for erasing operations, e.g., `x * 0`.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// The whole expression can be replaced by zero.
|
|
/// This is most likely not the intended outcome and should probably be
|
|
/// corrected
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// let x = 1;
|
|
/// 0 / x;
|
|
/// 0 * x;
|
|
/// x & 0;
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub ERASING_OP,
|
|
correctness,
|
|
"using erasing operations, e.g., `x * 0` or `y & 0`"
|
|
}
|
|
|
|
declare_lint_pass!(ErasingOp => [ERASING_OP]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for ErasingOp {
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
|
|
if e.span.from_expansion() {
|
|
return;
|
|
}
|
|
if let ExprKind::Binary(ref cmp, left, right) = e.kind {
|
|
match cmp.node {
|
|
BinOpKind::Mul | BinOpKind::BitAnd => {
|
|
check(cx, left, e.span);
|
|
check(cx, right, e.span);
|
|
},
|
|
BinOpKind::Div => check(cx, left, e.span),
|
|
_ => (),
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
fn check(cx: &LateContext<'_>, e: &Expr<'_>, span: Span) {
|
|
if constant_simple(cx, cx.typeck_results(), e) == Some(Constant::Int(0)) {
|
|
span_lint(
|
|
cx,
|
|
ERASING_OP,
|
|
span,
|
|
"this operation will always return zero. This is likely not the intended outcome",
|
|
);
|
|
}
|
|
}
|