mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-01 00:49:30 +00:00
593 lines
21 KiB
Text
593 lines
21 KiB
Text
error: redundant clone
|
|
--> tests/ui/unnecessary_to_owned.rs:157:64
|
|
|
|
|
LL | require_c_str(&CString::from_vec_with_nul(vec![0]).unwrap().to_owned());
|
|
| ^^^^^^^^^^^ help: remove this
|
|
|
|
|
note: this value is dropped without further use
|
|
--> tests/ui/unnecessary_to_owned.rs:157:20
|
|
|
|
|
LL | require_c_str(&CString::from_vec_with_nul(vec![0]).unwrap().to_owned());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
= note: `-D clippy::redundant-clone` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::redundant_clone)]`
|
|
|
|
error: redundant clone
|
|
--> tests/ui/unnecessary_to_owned.rs:158:40
|
|
|
|
|
LL | require_os_str(&OsString::from("x").to_os_string());
|
|
| ^^^^^^^^^^^^^^^ help: remove this
|
|
|
|
|
note: this value is dropped without further use
|
|
--> tests/ui/unnecessary_to_owned.rs:158:21
|
|
|
|
|
LL | require_os_str(&OsString::from("x").to_os_string());
|
|
| ^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: redundant clone
|
|
--> tests/ui/unnecessary_to_owned.rs:159:48
|
|
|
|
|
LL | require_path(&std::path::PathBuf::from("x").to_path_buf());
|
|
| ^^^^^^^^^^^^^^ help: remove this
|
|
|
|
|
note: this value is dropped without further use
|
|
--> tests/ui/unnecessary_to_owned.rs:159:19
|
|
|
|
|
LL | require_path(&std::path::PathBuf::from("x").to_path_buf());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: redundant clone
|
|
--> tests/ui/unnecessary_to_owned.rs:160:35
|
|
|
|
|
LL | require_str(&String::from("x").to_string());
|
|
| ^^^^^^^^^^^^ help: remove this
|
|
|
|
|
note: this value is dropped without further use
|
|
--> tests/ui/unnecessary_to_owned.rs:160:18
|
|
|
|
|
LL | require_str(&String::from("x").to_string());
|
|
| ^^^^^^^^^^^^^^^^^
|
|
|
|
error: redundant clone
|
|
--> tests/ui/unnecessary_to_owned.rs:161:39
|
|
|
|
|
LL | require_slice(&[String::from("x")].to_owned());
|
|
| ^^^^^^^^^^^ help: remove this
|
|
|
|
|
note: this value is dropped without further use
|
|
--> tests/ui/unnecessary_to_owned.rs:161:20
|
|
|
|
|
LL | require_slice(&[String::from("x")].to_owned());
|
|
| ^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: unnecessary use of `into_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:66:36
|
|
|
|
|
LL | require_c_str(&Cow::from(c_str).into_owned());
|
|
| ^^^^^^^^^^^^^ help: remove this
|
|
|
|
|
= note: `-D clippy::unnecessary-to-owned` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_to_owned)]`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:67:19
|
|
|
|
|
LL | require_c_str(&c_str.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^ help: use: `c_str`
|
|
|
|
error: unnecessary use of `to_os_string`
|
|
--> tests/ui/unnecessary_to_owned.rs:69:20
|
|
|
|
|
LL | require_os_str(&os_str.to_os_string());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^ help: use: `os_str`
|
|
|
|
error: unnecessary use of `into_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:70:38
|
|
|
|
|
LL | require_os_str(&Cow::from(os_str).into_owned());
|
|
| ^^^^^^^^^^^^^ help: remove this
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:71:20
|
|
|
|
|
LL | require_os_str(&os_str.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^^ help: use: `os_str`
|
|
|
|
error: unnecessary use of `to_path_buf`
|
|
--> tests/ui/unnecessary_to_owned.rs:73:18
|
|
|
|
|
LL | require_path(&path.to_path_buf());
|
|
| ^^^^^^^^^^^^^^^^^^^ help: use: `path`
|
|
|
|
error: unnecessary use of `into_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:74:34
|
|
|
|
|
LL | require_path(&Cow::from(path).into_owned());
|
|
| ^^^^^^^^^^^^^ help: remove this
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:75:18
|
|
|
|
|
LL | require_path(&path.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `path`
|
|
|
|
error: unnecessary use of `to_string`
|
|
--> tests/ui/unnecessary_to_owned.rs:77:17
|
|
|
|
|
LL | require_str(&s.to_string());
|
|
| ^^^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `into_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:78:30
|
|
|
|
|
LL | require_str(&Cow::from(s).into_owned());
|
|
| ^^^^^^^^^^^^^ help: remove this
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:79:17
|
|
|
|
|
LL | require_str(&s.to_owned());
|
|
| ^^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `to_string`
|
|
--> tests/ui/unnecessary_to_owned.rs:80:17
|
|
|
|
|
LL | require_str(&x_ref.to_string());
|
|
| ^^^^^^^^^^^^^^^^^^ help: use: `x_ref.as_ref()`
|
|
|
|
error: unnecessary use of `to_vec`
|
|
--> tests/ui/unnecessary_to_owned.rs:82:19
|
|
|
|
|
LL | require_slice(&slice.to_vec());
|
|
| ^^^^^^^^^^^^^^^ help: use: `slice`
|
|
|
|
error: unnecessary use of `into_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:83:36
|
|
|
|
|
LL | require_slice(&Cow::from(slice).into_owned());
|
|
| ^^^^^^^^^^^^^ help: remove this
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:84:19
|
|
|
|
|
LL | require_slice(&array.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^ help: use: `array.as_ref()`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:85:19
|
|
|
|
|
LL | require_slice(&array_ref.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^^^^^ help: use: `array_ref.as_ref()`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:86:19
|
|
|
|
|
LL | require_slice(&slice.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^ help: use: `slice`
|
|
|
|
error: unnecessary use of `into_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:89:42
|
|
|
|
|
LL | require_x(&Cow::<X>::Owned(x.clone()).into_owned());
|
|
| ^^^^^^^^^^^^^ help: remove this
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:92:25
|
|
|
|
|
LL | require_deref_c_str(c_str.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `c_str`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:93:26
|
|
|
|
|
LL | require_deref_os_str(os_str.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^ help: use: `os_str`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:94:24
|
|
|
|
|
LL | require_deref_path(path.to_owned());
|
|
| ^^^^^^^^^^^^^^^ help: use: `path`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:95:23
|
|
|
|
|
LL | require_deref_str(s.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:96:25
|
|
|
|
|
LL | require_deref_slice(slice.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `slice`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:98:30
|
|
|
|
|
LL | require_impl_deref_c_str(c_str.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `c_str`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:99:31
|
|
|
|
|
LL | require_impl_deref_os_str(os_str.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^ help: use: `os_str`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:100:29
|
|
|
|
|
LL | require_impl_deref_path(path.to_owned());
|
|
| ^^^^^^^^^^^^^^^ help: use: `path`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:101:28
|
|
|
|
|
LL | require_impl_deref_str(s.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:102:30
|
|
|
|
|
LL | require_impl_deref_slice(slice.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `slice`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:104:29
|
|
|
|
|
LL | require_deref_str_slice(s.to_owned(), slice.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:104:43
|
|
|
|
|
LL | require_deref_str_slice(s.to_owned(), slice.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `slice`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:105:29
|
|
|
|
|
LL | require_deref_slice_str(slice.to_owned(), s.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `slice`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:105:47
|
|
|
|
|
LL | require_deref_slice_str(slice.to_owned(), s.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:107:26
|
|
|
|
|
LL | require_as_ref_c_str(c_str.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `c_str`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:108:27
|
|
|
|
|
LL | require_as_ref_os_str(os_str.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^ help: use: `os_str`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:109:25
|
|
|
|
|
LL | require_as_ref_path(path.to_owned());
|
|
| ^^^^^^^^^^^^^^^ help: use: `path`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:110:24
|
|
|
|
|
LL | require_as_ref_str(s.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:111:24
|
|
|
|
|
LL | require_as_ref_str(x.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `&x`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:112:26
|
|
|
|
|
LL | require_as_ref_slice(array.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `array`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:113:26
|
|
|
|
|
LL | require_as_ref_slice(array_ref.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^^^^ help: use: `array_ref`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:114:26
|
|
|
|
|
LL | require_as_ref_slice(slice.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `slice`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:116:31
|
|
|
|
|
LL | require_impl_as_ref_c_str(c_str.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `c_str`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:117:32
|
|
|
|
|
LL | require_impl_as_ref_os_str(os_str.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^ help: use: `os_str`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:118:30
|
|
|
|
|
LL | require_impl_as_ref_path(path.to_owned());
|
|
| ^^^^^^^^^^^^^^^ help: use: `path`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:119:29
|
|
|
|
|
LL | require_impl_as_ref_str(s.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:120:29
|
|
|
|
|
LL | require_impl_as_ref_str(x.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `&x`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:121:31
|
|
|
|
|
LL | require_impl_as_ref_slice(array.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `array`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:122:31
|
|
|
|
|
LL | require_impl_as_ref_slice(array_ref.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^^^^ help: use: `array_ref`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:123:31
|
|
|
|
|
LL | require_impl_as_ref_slice(slice.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `slice`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:125:30
|
|
|
|
|
LL | require_as_ref_str_slice(s.to_owned(), array.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:125:44
|
|
|
|
|
LL | require_as_ref_str_slice(s.to_owned(), array.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `array`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:126:30
|
|
|
|
|
LL | require_as_ref_str_slice(s.to_owned(), array_ref.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:126:44
|
|
|
|
|
LL | require_as_ref_str_slice(s.to_owned(), array_ref.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^^^^ help: use: `array_ref`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:127:30
|
|
|
|
|
LL | require_as_ref_str_slice(s.to_owned(), slice.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:127:44
|
|
|
|
|
LL | require_as_ref_str_slice(s.to_owned(), slice.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `slice`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:128:30
|
|
|
|
|
LL | require_as_ref_slice_str(array.to_owned(), s.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `array`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:128:48
|
|
|
|
|
LL | require_as_ref_slice_str(array.to_owned(), s.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:129:30
|
|
|
|
|
LL | require_as_ref_slice_str(array_ref.to_owned(), s.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^^^^ help: use: `array_ref`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:129:52
|
|
|
|
|
LL | require_as_ref_slice_str(array_ref.to_owned(), s.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:130:30
|
|
|
|
|
LL | require_as_ref_slice_str(slice.to_owned(), s.to_owned());
|
|
| ^^^^^^^^^^^^^^^^ help: use: `slice`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:130:48
|
|
|
|
|
LL | require_as_ref_slice_str(slice.to_owned(), s.to_owned());
|
|
| ^^^^^^^^^^^^ help: use: `s`
|
|
|
|
error: unnecessary use of `to_string`
|
|
--> tests/ui/unnecessary_to_owned.rs:132:20
|
|
|
|
|
LL | let _ = x.join(&x_ref.to_string());
|
|
| ^^^^^^^^^^^^^^^^^^ help: use: `x_ref`
|
|
|
|
error: unnecessary use of `to_vec`
|
|
--> tests/ui/unnecessary_to_owned.rs:134:13
|
|
|
|
|
LL | let _ = slice.to_vec().into_iter();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `slice.iter().copied()`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:135:13
|
|
|
|
|
LL | let _ = slice.to_owned().into_iter();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `slice.iter().copied()`
|
|
|
|
error: unnecessary use of `to_vec`
|
|
--> tests/ui/unnecessary_to_owned.rs:136:13
|
|
|
|
|
LL | let _ = [std::path::PathBuf::new()][..].to_vec().into_iter();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `[std::path::PathBuf::new()][..].iter().cloned()`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:137:13
|
|
|
|
|
LL | let _ = [std::path::PathBuf::new()][..].to_owned().into_iter();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `[std::path::PathBuf::new()][..].iter().cloned()`
|
|
|
|
error: unnecessary use of `to_vec`
|
|
--> tests/ui/unnecessary_to_owned.rs:139:13
|
|
|
|
|
LL | let _ = IntoIterator::into_iter(slice.to_vec());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `slice.iter().copied()`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:140:13
|
|
|
|
|
LL | let _ = IntoIterator::into_iter(slice.to_owned());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `slice.iter().copied()`
|
|
|
|
error: unnecessary use of `to_vec`
|
|
--> tests/ui/unnecessary_to_owned.rs:141:13
|
|
|
|
|
LL | let _ = IntoIterator::into_iter([std::path::PathBuf::new()][..].to_vec());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `[std::path::PathBuf::new()][..].iter().cloned()`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:142:13
|
|
|
|
|
LL | let _ = IntoIterator::into_iter([std::path::PathBuf::new()][..].to_owned());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `[std::path::PathBuf::new()][..].iter().cloned()`
|
|
|
|
error: allocating a new `String` only to create a temporary `&str` from it
|
|
--> tests/ui/unnecessary_to_owned.rs:164:26
|
|
|
|
|
LL | let _ref_str: &str = &String::from_utf8(slice.to_vec()).expect("not UTF-8");
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: convert from `&[u8]` to `&str` directly
|
|
|
|
|
LL - let _ref_str: &str = &String::from_utf8(slice.to_vec()).expect("not UTF-8");
|
|
LL + let _ref_str: &str = core::str::from_utf8(&slice).expect("not UTF-8");
|
|
|
|
|
|
|
error: allocating a new `String` only to create a temporary `&str` from it
|
|
--> tests/ui/unnecessary_to_owned.rs:165:26
|
|
|
|
|
LL | let _ref_str: &str = &String::from_utf8(b"foo".to_vec()).unwrap();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: convert from `&[u8]` to `&str` directly
|
|
|
|
|
LL - let _ref_str: &str = &String::from_utf8(b"foo".to_vec()).unwrap();
|
|
LL + let _ref_str: &str = core::str::from_utf8(b"foo").unwrap();
|
|
|
|
|
|
|
error: allocating a new `String` only to create a temporary `&str` from it
|
|
--> tests/ui/unnecessary_to_owned.rs:166:26
|
|
|
|
|
LL | let _ref_str: &str = &String::from_utf8(b"foo".as_slice().to_owned()).unwrap();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: convert from `&[u8]` to `&str` directly
|
|
|
|
|
LL - let _ref_str: &str = &String::from_utf8(b"foo".as_slice().to_owned()).unwrap();
|
|
LL + let _ref_str: &str = core::str::from_utf8(b"foo".as_slice()).unwrap();
|
|
|
|
|
|
|
error: unnecessary use of `to_vec`
|
|
--> tests/ui/unnecessary_to_owned.rs:223:14
|
|
|
|
|
LL | for t in file_types.to_vec() {
|
|
| ^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use
|
|
|
|
|
LL | for t in file_types {
|
|
| ~~~~~~~~~~
|
|
help: remove any references to the binding
|
|
|
|
|
LL - let path = match get_file_path(&t) {
|
|
LL + let path = match get_file_path(t) {
|
|
|
|
|
|
|
error: unnecessary use of `to_vec`
|
|
--> tests/ui/unnecessary_to_owned.rs:246:14
|
|
|
|
|
LL | let _ = &["x"][..].to_vec().into_iter();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `["x"][..].iter().cloned()`
|
|
|
|
error: unnecessary use of `to_vec`
|
|
--> tests/ui/unnecessary_to_owned.rs:251:14
|
|
|
|
|
LL | let _ = &["x"][..].to_vec().into_iter();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `["x"][..].iter().copied()`
|
|
|
|
error: unnecessary use of `to_string`
|
|
--> tests/ui/unnecessary_to_owned.rs:299:24
|
|
|
|
|
LL | Box::new(build(y.to_string()))
|
|
| ^^^^^^^^^^^^^ help: use: `y`
|
|
|
|
error: unnecessary use of `to_string`
|
|
--> tests/ui/unnecessary_to_owned.rs:408:12
|
|
|
|
|
LL | id("abc".to_string())
|
|
| ^^^^^^^^^^^^^^^^^ help: use: `"abc"`
|
|
|
|
error: unnecessary use of `to_vec`
|
|
--> tests/ui/unnecessary_to_owned.rs:551:37
|
|
|
|
|
LL | IntoFuture::into_future(foo([].to_vec(), &0));
|
|
| ^^^^^^^^^^^ help: use: `[]`
|
|
|
|
error: unnecessary use of `to_vec`
|
|
--> tests/ui/unnecessary_to_owned.rs:561:18
|
|
|
|
|
LL | s.remove(&a.to_vec());
|
|
| ^^^^^^^^^^^ help: replace it with: `a`
|
|
|
|
error: unnecessary use of `to_owned`
|
|
--> tests/ui/unnecessary_to_owned.rs:565:14
|
|
|
|
|
LL | s.remove(&"b".to_owned());
|
|
| ^^^^^^^^^^^^^^^ help: replace it with: `"b"`
|
|
|
|
error: unnecessary use of `to_string`
|
|
--> tests/ui/unnecessary_to_owned.rs:566:14
|
|
|
|
|
LL | s.remove(&"b".to_string());
|
|
| ^^^^^^^^^^^^^^^^ help: replace it with: `"b"`
|
|
|
|
error: unnecessary use of `to_vec`
|
|
--> tests/ui/unnecessary_to_owned.rs:571:14
|
|
|
|
|
LL | s.remove(&["b"].to_vec());
|
|
| ^^^^^^^^^^^^^^^ help: replace it with: `["b"].as_slice()`
|
|
|
|
error: unnecessary use of `to_vec`
|
|
--> tests/ui/unnecessary_to_owned.rs:572:14
|
|
|
|
|
LL | s.remove(&(&["b"]).to_vec());
|
|
| ^^^^^^^^^^^^^^^^^^ help: replace it with: `(&["b"]).as_slice()`
|
|
|
|
error: aborting due to 88 previous errors
|
|
|