mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-14 17:07:17 +00:00
543d56938e
This commit: - now makes `HirEqInterExpr::eq_block` take comments into account. Identical code with varying comments will no longer be considered equal. - makes necessary adjustments to UI tests.
116 lines
2.6 KiB
Text
116 lines
2.6 KiB
Text
error: this `if` has identical blocks
|
|
--> $DIR/if_same_then_else2.rs:15:13
|
|
|
|
|
LL | if true {
|
|
| _____________^
|
|
LL | | for _ in &[42] {
|
|
LL | | let foo: &Option<_> = &Some::<u8>(42);
|
|
LL | | if foo.is_some() {
|
|
... |
|
|
LL | | }
|
|
LL | | } else {
|
|
| |_____^
|
|
|
|
|
note: same as this
|
|
--> $DIR/if_same_then_else2.rs:24:12
|
|
|
|
|
LL | } else {
|
|
| ____________^
|
|
LL | | for _ in &[42] {
|
|
LL | | let bar: &Option<_> = &Some::<u8>(42);
|
|
LL | | if bar.is_some() {
|
|
... |
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
= note: `-D clippy::if-same-then-else` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::if_same_then_else)]`
|
|
|
|
error: this `if` has identical blocks
|
|
--> $DIR/if_same_then_else2.rs:36:13
|
|
|
|
|
LL | if true {
|
|
| _____________^
|
|
LL | | if let Some(a) = Some(42) {}
|
|
LL | | } else {
|
|
| |_____^
|
|
|
|
|
note: same as this
|
|
--> $DIR/if_same_then_else2.rs:38:12
|
|
|
|
|
LL | } else {
|
|
| ____________^
|
|
LL | | if let Some(a) = Some(42) {}
|
|
LL | | }
|
|
| |_____^
|
|
|
|
error: this `if` has identical blocks
|
|
--> $DIR/if_same_then_else2.rs:43:13
|
|
|
|
|
LL | if true {
|
|
| _____________^
|
|
LL | | if let (1, .., 3) = (1, 2, 3) {}
|
|
LL | | } else {
|
|
| |_____^
|
|
|
|
|
note: same as this
|
|
--> $DIR/if_same_then_else2.rs:45:12
|
|
|
|
|
LL | } else {
|
|
| ____________^
|
|
LL | | if let (1, .., 3) = (1, 2, 3) {}
|
|
LL | | }
|
|
| |_____^
|
|
|
|
error: this `if` has identical blocks
|
|
--> $DIR/if_same_then_else2.rs:93:21
|
|
|
|
|
LL | let _ = if true { f32::NAN } else { f32::NAN };
|
|
| ^^^^^^^^^^^^
|
|
|
|
|
note: same as this
|
|
--> $DIR/if_same_then_else2.rs:93:39
|
|
|
|
|
LL | let _ = if true { f32::NAN } else { f32::NAN };
|
|
| ^^^^^^^^^^^^
|
|
|
|
error: this `if` has identical blocks
|
|
--> $DIR/if_same_then_else2.rs:96:13
|
|
|
|
|
LL | if true {
|
|
| _____________^
|
|
LL | | Ok("foo")?;
|
|
LL | | } else {
|
|
| |_____^
|
|
|
|
|
note: same as this
|
|
--> $DIR/if_same_then_else2.rs:98:12
|
|
|
|
|
LL | } else {
|
|
| ____________^
|
|
LL | | Ok("foo")?;
|
|
LL | | }
|
|
| |_____^
|
|
|
|
error: this `if` has identical blocks
|
|
--> $DIR/if_same_then_else2.rs:120:20
|
|
|
|
|
LL | } else if true {
|
|
| ____________________^
|
|
LL | | let foo = "";
|
|
LL | | return Ok(&foo[0..]);
|
|
LL | | } else {
|
|
| |_____^
|
|
|
|
|
note: same as this
|
|
--> $DIR/if_same_then_else2.rs:123:12
|
|
|
|
|
LL | } else {
|
|
| ____________^
|
|
LL | | let foo = "";
|
|
LL | | return Ok(&foo[0..]);
|
|
LL | | }
|
|
| |_____^
|
|
|
|
error: aborting due to 6 previous errors
|
|
|