mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 21:53:23 +00:00
852c38c543
Whenever suggestion for this lint does not fit in one line, lint will generate two help messages. The second help message will always contain the suggestion. The first help message refers to suggestion message, and it should adapt depending on the location of the suggestion: - inline suggestion within the error/warning message - suggestion separated into second help text
199 lines
5.2 KiB
Text
199 lines
5.2 KiB
Text
error: unnecessary `if let` since only the `Some` variant of the iterator element is used
|
|
--> $DIR/manual_flatten.rs:7:5
|
|
|
|
|
LL | for n in x {
|
|
| ^ - help: try: `x.into_iter().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | | if let Some(y) = n {
|
|
LL | | println!("{}", y);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
= note: `-D clippy::manual-flatten` implied by `-D warnings`
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> $DIR/manual_flatten.rs:8:9
|
|
|
|
|
LL | / if let Some(y) = n {
|
|
LL | | println!("{}", y);
|
|
LL | | }
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Ok` variant of the iterator element is used
|
|
--> $DIR/manual_flatten.rs:15:5
|
|
|
|
|
LL | for n in y.clone() {
|
|
| ^ --------- help: try: `y.clone().into_iter().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | | if let Ok(n) = n {
|
|
LL | | println!("{}", n);
|
|
LL | | };
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> $DIR/manual_flatten.rs:16:9
|
|
|
|
|
LL | / if let Ok(n) = n {
|
|
LL | | println!("{}", n);
|
|
LL | | };
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Ok` variant of the iterator element is used
|
|
--> $DIR/manual_flatten.rs:22:5
|
|
|
|
|
LL | for n in &y {
|
|
| ^ -- help: try: `y.iter().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | | if let Ok(n) = n {
|
|
LL | | println!("{}", n);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> $DIR/manual_flatten.rs:23:9
|
|
|
|
|
LL | / if let Ok(n) = n {
|
|
LL | | println!("{}", n);
|
|
LL | | }
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Ok` variant of the iterator element is used
|
|
--> $DIR/manual_flatten.rs:30:5
|
|
|
|
|
LL | for n in z {
|
|
| ^ - help: try: `z.iter().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | | if let Ok(n) = n {
|
|
LL | | println!("{}", n);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> $DIR/manual_flatten.rs:31:9
|
|
|
|
|
LL | / if let Ok(n) = n {
|
|
LL | | println!("{}", n);
|
|
LL | | }
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Some` variant of the iterator element is used
|
|
--> $DIR/manual_flatten.rs:39:5
|
|
|
|
|
LL | for n in z {
|
|
| ^ - help: try: `z.flatten()`
|
|
| _____|
|
|
| |
|
|
LL | | if let Some(m) = n {
|
|
LL | | println!("{}", m);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> $DIR/manual_flatten.rs:40:9
|
|
|
|
|
LL | / if let Some(m) = n {
|
|
LL | | println!("{}", m);
|
|
LL | | }
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Some` variant of the iterator element is used
|
|
--> $DIR/manual_flatten.rs:72:5
|
|
|
|
|
LL | for n in &vec_of_ref {
|
|
| ^ ----------- help: try: `vec_of_ref.iter().copied().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | | if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> $DIR/manual_flatten.rs:73:9
|
|
|
|
|
LL | / if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Some` variant of the iterator element is used
|
|
--> $DIR/manual_flatten.rs:79:5
|
|
|
|
|
LL | for n in vec_of_ref {
|
|
| ^ ---------- help: try: `vec_of_ref.iter().copied().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | | if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> $DIR/manual_flatten.rs:80:9
|
|
|
|
|
LL | / if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Some` variant of the iterator element is used
|
|
--> $DIR/manual_flatten.rs:86:5
|
|
|
|
|
LL | for n in slice_of_ref {
|
|
| ^ ------------ help: try: `slice_of_ref.iter().copied().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | | if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> $DIR/manual_flatten.rs:87:9
|
|
|
|
|
LL | / if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Some` variant of the iterator element is used
|
|
--> $DIR/manual_flatten.rs:116:5
|
|
|
|
|
LL | / for n in vec![
|
|
LL | | Some(1),
|
|
LL | | Some(2),
|
|
LL | | Some(3)
|
|
... |
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: remove the `if let` statement in the for loop and then...
|
|
--> $DIR/manual_flatten.rs:121:9
|
|
|
|
|
LL | / if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
| |_________^
|
|
help: try
|
|
|
|
|
LL ~ for n in vec![
|
|
LL + Some(1),
|
|
LL + Some(2),
|
|
LL + Some(3)
|
|
LL ~ ].iter().flatten() {
|
|
|
|
|
|
|
error: aborting due to 9 previous errors
|
|
|