bors 887ba0c5a4 Auto merge of #9586 - Alexendoo:format-args-commas, r=Manishearth ... FormatArgsExpn: Find comma spans and ignore weird proc macro spans Fixes the following cases: A missing `, 1` from the `expect_fun_call` suggestion: ```rust Some(()).expect(&format!("{x} {}", 1)); ``` ``` warning: use of `expect` followed by a function call --> t.rs:7:14 | 7 | Some(()).expect(&format!("{x} {}", 1)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("{x} {}"))` ``` The suggestion removing from the comma in the comment rather than the one after the format string: ```rust println!( "{}", // a comment, with a comma in it x ); ``` ``` warning: variables can be used directly in the `format!` string --> t.rs:9:5 | 9 | / println!( 10 | | "{}", 11 | | // a comment, with a comma in it 12 | | x 13 | | ); | |_____^ | help: change this to | 10 ~ "{x}", 11 ~ // a comment | ``` It also no longer accepts expansions where a format string or argument has a "weird" proc macro span, that is one where the literal/expression it outputs has the span of one of its inputs. Kind of like a `format_args` specific `clippy_utils::is_from_proc_macro`, e.g. `format!(indoc! {" ... "})` changelog: [`expect_fun_call`]: Fix suggestion for `format!` using captured variables changelog: [`print_literal`], [`write_literal`], [`uninlined_format_args`]: Fix suggestion when following a comment including a comma		2022-10-05 16:27:03 +00:00
..
src	Auto merge of #9586 - Alexendoo:format-args-commas, r=Manishearth	2022-10-05 16:27:03 +00:00
Cargo.toml	Bump Clippy version -> 0.1.66	2022-09-28 14:27:50 +02:00