mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-05 02:50:32 +00:00
ab6e709ee6
Instead of saying "unit function", use the phrase the description uses: "function that returns the unit type". Fixes #5180.
140 lines
6.1 KiB
Text
140 lines
6.1 KiB
Text
error: called `map(f)` on an `Result` value where `f` is a function that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:35:5
|
|
|
|
|
LL | x.field.map(do_nothing);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(x_field) = x.field { do_nothing(x_field) }`
|
|
|
|
|
= note: `-D clippy::result-map-unit-fn` implied by `-D warnings`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a function that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:37:5
|
|
|
|
|
LL | x.field.map(do_nothing);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(x_field) = x.field { do_nothing(x_field) }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a function that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:39:5
|
|
|
|
|
LL | x.field.map(diverge);
|
|
| ^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(x_field) = x.field { diverge(x_field) }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:45:5
|
|
|
|
|
LL | x.field.map(|value| x.do_result_nothing(value + captured));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { x.do_result_nothing(value + captured) }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:47:5
|
|
|
|
|
LL | x.field.map(|value| { x.do_result_plus_one(value + captured); });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { x.do_result_plus_one(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:50:5
|
|
|
|
|
LL | x.field.map(|value| do_nothing(value + captured));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { do_nothing(value + captured) }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:52:5
|
|
|
|
|
LL | x.field.map(|value| { do_nothing(value + captured) });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { do_nothing(value + captured) }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:54:5
|
|
|
|
|
LL | x.field.map(|value| { do_nothing(value + captured); });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { do_nothing(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:56:5
|
|
|
|
|
LL | x.field.map(|value| { { do_nothing(value + captured); } });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { do_nothing(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:59:5
|
|
|
|
|
LL | x.field.map(|value| diverge(value + captured));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { diverge(value + captured) }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:61:5
|
|
|
|
|
LL | x.field.map(|value| { diverge(value + captured) });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { diverge(value + captured) }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:63:5
|
|
|
|
|
LL | x.field.map(|value| { diverge(value + captured); });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { diverge(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:65:5
|
|
|
|
|
LL | x.field.map(|value| { { diverge(value + captured); } });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { diverge(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:70:5
|
|
|
|
|
LL | x.field.map(|value| { let y = plus_one(value + captured); });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { let y = plus_one(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:72:5
|
|
|
|
|
LL | x.field.map(|value| { plus_one(value + captured); });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { plus_one(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:74:5
|
|
|
|
|
LL | x.field.map(|value| { { plus_one(value + captured); } });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(value) = x.field { plus_one(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type
|
|
--> $DIR/result_map_unit_fn_fixable.rs:77:5
|
|
|
|
|
LL | x.field.map(|ref value| { do_nothing(value + captured) });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try this: `if let Ok(ref value) = x.field { do_nothing(value + captured) }`
|
|
|
|
error: aborting due to 17 previous errors
|
|
|