mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 05:33:27 +00:00
204 lines
6.6 KiB
Text
204 lines
6.6 KiB
Text
error: manual implementation of `split_once`
|
|
--> tests/ui/manual_split_once.rs:13:13
|
|
|
|
|
LL | let _ = "key=value".splitn(2, '=').nth(1).unwrap();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"key=value".split_once('=').unwrap().1`
|
|
|
|
|
= note: `-D clippy::manual-split-once` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::manual_split_once)]`
|
|
|
|
error: manual implementation of `split_once`
|
|
--> tests/ui/manual_split_once.rs:14:13
|
|
|
|
|
LL | let _ = "key=value".splitn(2, '=').skip(1).next().unwrap();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"key=value".split_once('=').unwrap().1`
|
|
|
|
error: manual implementation of `split_once`
|
|
--> tests/ui/manual_split_once.rs:15:18
|
|
|
|
|
LL | let (_, _) = "key=value".splitn(2, '=').next_tuple().unwrap();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"key=value".split_once('=')`
|
|
|
|
error: manual implementation of `split_once`
|
|
--> tests/ui/manual_split_once.rs:18:13
|
|
|
|
|
LL | let _ = s.splitn(2, '=').nth(1).unwrap();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.split_once('=').unwrap().1`
|
|
|
|
error: manual implementation of `split_once`
|
|
--> tests/ui/manual_split_once.rs:21:13
|
|
|
|
|
LL | let _ = s.splitn(2, '=').nth(1).unwrap();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.split_once('=').unwrap().1`
|
|
|
|
error: manual implementation of `split_once`
|
|
--> tests/ui/manual_split_once.rs:24:13
|
|
|
|
|
LL | let _ = s.splitn(2, '=').skip(1).next().unwrap();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.split_once('=').unwrap().1`
|
|
|
|
error: manual implementation of `split_once`
|
|
--> tests/ui/manual_split_once.rs:27:17
|
|
|
|
|
LL | let _ = s.splitn(2, '=').nth(1)?;
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.split_once('=')?.1`
|
|
|
|
error: manual implementation of `split_once`
|
|
--> tests/ui/manual_split_once.rs:28:17
|
|
|
|
|
LL | let _ = s.splitn(2, '=').skip(1).next()?;
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.split_once('=')?.1`
|
|
|
|
error: manual implementation of `rsplit_once`
|
|
--> tests/ui/manual_split_once.rs:29:17
|
|
|
|
|
LL | let _ = s.rsplitn(2, '=').nth(1)?;
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.rsplit_once('=')?.0`
|
|
|
|
error: manual implementation of `rsplit_once`
|
|
--> tests/ui/manual_split_once.rs:30:17
|
|
|
|
|
LL | let _ = s.rsplitn(2, '=').skip(1).next()?;
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.rsplit_once('=')?.0`
|
|
|
|
error: manual implementation of `rsplit_once`
|
|
--> tests/ui/manual_split_once.rs:38:13
|
|
|
|
|
LL | let _ = "key=value".rsplitn(2, '=').nth(1).unwrap();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"key=value".rsplit_once('=').unwrap().0`
|
|
|
|
error: manual implementation of `rsplit_once`
|
|
--> tests/ui/manual_split_once.rs:39:18
|
|
|
|
|
LL | let (_, _) = "key=value".rsplitn(2, '=').next_tuple().unwrap();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"key=value".rsplit_once('=').map(|(x, y)| (y, x))`
|
|
|
|
error: manual implementation of `rsplit_once`
|
|
--> tests/ui/manual_split_once.rs:40:13
|
|
|
|
|
LL | let _ = s.rsplitn(2, '=').nth(1);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.rsplit_once('=').map(|x| x.0)`
|
|
|
|
error: manual implementation of `split_once`
|
|
--> tests/ui/manual_split_once.rs:44:5
|
|
|
|
|
LL | let mut iter = "a.b.c".splitn(2, '.');
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
LL | let l = iter.next().unwrap();
|
|
| ----------------------------- first usage here
|
|
LL | let r = iter.next().unwrap();
|
|
| ----------------------------- second usage here
|
|
|
|
|
help: try `split_once`
|
|
|
|
|
LL | let (l, r) = "a.b.c".split_once('.').unwrap();
|
|
|
|
|
help: remove the `iter` usages
|
|
|
|
|
LL - let l = iter.next().unwrap();
|
|
|
|
|
help: remove the `iter` usages
|
|
|
|
|
LL - let r = iter.next().unwrap();
|
|
|
|
|
|
|
error: manual implementation of `split_once`
|
|
--> tests/ui/manual_split_once.rs:48:5
|
|
|
|
|
LL | let mut iter = "a.b.c".splitn(2, '.');
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
LL | let l = iter.next()?;
|
|
| --------------------- first usage here
|
|
LL | let r = iter.next()?;
|
|
| --------------------- second usage here
|
|
|
|
|
help: try `split_once`
|
|
|
|
|
LL | let (l, r) = "a.b.c".split_once('.')?;
|
|
|
|
|
help: remove the `iter` usages
|
|
|
|
|
LL - let l = iter.next()?;
|
|
|
|
|
help: remove the `iter` usages
|
|
|
|
|
LL - let r = iter.next()?;
|
|
|
|
|
|
|
error: manual implementation of `rsplit_once`
|
|
--> tests/ui/manual_split_once.rs:52:5
|
|
|
|
|
LL | let mut iter = "a.b.c".rsplitn(2, '.');
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
LL | let r = iter.next().unwrap();
|
|
| ----------------------------- first usage here
|
|
LL | let l = iter.next().unwrap();
|
|
| ----------------------------- second usage here
|
|
|
|
|
help: try `rsplit_once`
|
|
|
|
|
LL | let (l, r) = "a.b.c".rsplit_once('.').unwrap();
|
|
|
|
|
help: remove the `iter` usages
|
|
|
|
|
LL - let r = iter.next().unwrap();
|
|
|
|
|
help: remove the `iter` usages
|
|
|
|
|
LL - let l = iter.next().unwrap();
|
|
|
|
|
|
|
error: manual implementation of `rsplit_once`
|
|
--> tests/ui/manual_split_once.rs:56:5
|
|
|
|
|
LL | let mut iter = "a.b.c".rsplitn(2, '.');
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
LL | let r = iter.next()?;
|
|
| --------------------- first usage here
|
|
LL | let l = iter.next()?;
|
|
| --------------------- second usage here
|
|
|
|
|
help: try `rsplit_once`
|
|
|
|
|
LL | let (l, r) = "a.b.c".rsplit_once('.')?;
|
|
|
|
|
help: remove the `iter` usages
|
|
|
|
|
LL - let r = iter.next()?;
|
|
|
|
|
help: remove the `iter` usages
|
|
|
|
|
LL - let l = iter.next()?;
|
|
|
|
|
|
|
error: manual implementation of `split_once`
|
|
--> tests/ui/manual_split_once.rs:141:13
|
|
|
|
|
LL | let _ = "key=value".splitn(2, '=').nth(1).unwrap();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"key=value".split_once('=').unwrap().1`
|
|
|
|
error: manual implementation of `split_once`
|
|
--> tests/ui/manual_split_once.rs:143:5
|
|
|
|
|
LL | let mut iter = "a.b.c".splitn(2, '.');
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
LL | let a = iter.next().unwrap();
|
|
| ----------------------------- first usage here
|
|
LL | let b = iter.next().unwrap();
|
|
| ----------------------------- second usage here
|
|
|
|
|
help: try `split_once`
|
|
|
|
|
LL | let (a, b) = "a.b.c".split_once('.').unwrap();
|
|
|
|
|
help: remove the `iter` usages
|
|
|
|
|
LL - let a = iter.next().unwrap();
|
|
|
|
|
help: remove the `iter` usages
|
|
|
|
|
LL - let b = iter.next().unwrap();
|
|
|
|
|
|
|
error: aborting due to 19 previous errors
|
|
|