mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-18 02:38:28 +00:00
157 lines
4.8 KiB
Text
157 lines
4.8 KiB
Text
error: match expression looks like `matches!` macro
|
|
--> $DIR/match_expr_like_matches_macro.rs:10:14
|
|
|
|
|
LL | let _y = match x {
|
|
| ______________^
|
|
LL | | Some(0) => true,
|
|
LL | | _ => false,
|
|
LL | | };
|
|
| |_____^ help: try this: `matches!(x, Some(0))`
|
|
|
|
|
= note: `-D clippy::match-like-matches-macro` implied by `-D warnings`
|
|
|
|
error: match expression looks like `matches!` macro
|
|
--> $DIR/match_expr_like_matches_macro.rs:16:14
|
|
|
|
|
LL | let _w = match x {
|
|
| ______________^
|
|
LL | | Some(_) => true,
|
|
LL | | _ => false,
|
|
LL | | };
|
|
| |_____^ help: try this: `matches!(x, Some(_))`
|
|
|
|
error: redundant pattern matching, consider using `is_none()`
|
|
--> $DIR/match_expr_like_matches_macro.rs:22:14
|
|
|
|
|
LL | let _z = match x {
|
|
| ______________^
|
|
LL | | Some(_) => false,
|
|
LL | | None => true,
|
|
LL | | };
|
|
| |_____^ help: try this: `x.is_none()`
|
|
|
|
|
= note: `-D clippy::redundant-pattern-matching` implied by `-D warnings`
|
|
|
|
error: match expression looks like `matches!` macro
|
|
--> $DIR/match_expr_like_matches_macro.rs:28:15
|
|
|
|
|
LL | let _zz = match x {
|
|
| _______________^
|
|
LL | | Some(r) if r == 0 => false,
|
|
LL | | _ => true,
|
|
LL | | };
|
|
| |_____^ help: try this: `!matches!(x, Some(r) if r == 0)`
|
|
|
|
error: if let .. else expression looks like `matches!` macro
|
|
--> $DIR/match_expr_like_matches_macro.rs:34:16
|
|
|
|
|
LL | let _zzz = if let Some(5) = x { true } else { false };
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `matches!(x, Some(5))`
|
|
|
|
error: match expression looks like `matches!` macro
|
|
--> $DIR/match_expr_like_matches_macro.rs:58:20
|
|
|
|
|
LL | let _ans = match x {
|
|
| ____________________^
|
|
LL | | E::A(_) => true,
|
|
LL | | E::B(_) => true,
|
|
LL | | _ => false,
|
|
LL | | };
|
|
| |_________^ help: try this: `matches!(x, E::A(_) | E::B(_))`
|
|
|
|
error: match expression looks like `matches!` macro
|
|
--> $DIR/match_expr_like_matches_macro.rs:66:20
|
|
|
|
|
LL | let _ans = match x {
|
|
| ____________________^
|
|
LL | | E::B(_) => false,
|
|
LL | | E::C => false,
|
|
LL | | _ => true,
|
|
LL | | };
|
|
| |_________^ help: try this: `!matches!(x, E::B(_) | E::C)`
|
|
|
|
error: match expression looks like `matches!` macro
|
|
--> $DIR/match_expr_like_matches_macro.rs:126:18
|
|
|
|
|
LL | let _z = match &z {
|
|
| __________________^
|
|
LL | | Some(3) => true,
|
|
LL | | _ => false,
|
|
LL | | };
|
|
| |_________^ help: try this: `matches!(z, Some(3))`
|
|
|
|
error: match expression looks like `matches!` macro
|
|
--> $DIR/match_expr_like_matches_macro.rs:135:18
|
|
|
|
|
LL | let _z = match &z {
|
|
| __________________^
|
|
LL | | Some(3) => true,
|
|
LL | | _ => false,
|
|
LL | | };
|
|
| |_________^ help: try this: `matches!(&z, Some(3))`
|
|
|
|
error: match expression looks like `matches!` macro
|
|
--> $DIR/match_expr_like_matches_macro.rs:152:21
|
|
|
|
|
LL | let _ = match &z {
|
|
| _____________________^
|
|
LL | | AnEnum::X => true,
|
|
LL | | _ => false,
|
|
LL | | };
|
|
| |_____________^ help: try this: `matches!(&z, AnEnum::X)`
|
|
|
|
error: match expression looks like `matches!` macro
|
|
--> $DIR/match_expr_like_matches_macro.rs:166:20
|
|
|
|
|
LL | let _res = match &val {
|
|
| ____________________^
|
|
LL | | &Some(ref _a) => true,
|
|
LL | | _ => false,
|
|
LL | | };
|
|
| |_________^ help: try this: `matches!(&val, &Some(ref _a))`
|
|
|
|
error: you don't need to add `&` to both the expression and the patterns
|
|
--> $DIR/match_expr_like_matches_macro.rs:166:20
|
|
|
|
|
LL | let _res = match &val {
|
|
| ____________________^
|
|
LL | | &Some(ref _a) => true,
|
|
LL | | _ => false,
|
|
LL | | };
|
|
| |_________^
|
|
|
|
|
= note: `-D clippy::match-ref-pats` implied by `-D warnings`
|
|
help: try
|
|
|
|
|
LL ~ let _res = match val {
|
|
LL ~ Some(ref _a) => true,
|
|
|
|
|
|
|
error: match expression looks like `matches!` macro
|
|
--> $DIR/match_expr_like_matches_macro.rs:178:20
|
|
|
|
|
LL | let _res = match &val {
|
|
| ____________________^
|
|
LL | | &Some(ref _a) => true,
|
|
LL | | _ => false,
|
|
LL | | };
|
|
| |_________^ help: try this: `matches!(&val, &Some(ref _a))`
|
|
|
|
error: you don't need to add `&` to both the expression and the patterns
|
|
--> $DIR/match_expr_like_matches_macro.rs:178:20
|
|
|
|
|
LL | let _res = match &val {
|
|
| ____________________^
|
|
LL | | &Some(ref _a) => true,
|
|
LL | | _ => false,
|
|
LL | | };
|
|
| |_________^
|
|
|
|
|
help: try
|
|
|
|
|
LL ~ let _res = match val {
|
|
LL ~ Some(ref _a) => true,
|
|
|
|
|
|
|
error: aborting due to 14 previous errors
|
|
|