mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 21:53:23 +00:00
04bff17668
Don't emit a lint when `.to_string()` on anything that is not `self`
69 lines
1.1 KiB
Rust
69 lines
1.1 KiB
Rust
#![warn(clippy::to_string_in_display)]
|
|
#![allow(clippy::inherent_to_string_shadow_display)]
|
|
|
|
use std::fmt;
|
|
|
|
struct A;
|
|
impl A {
|
|
fn fmt(&self) {
|
|
self.to_string();
|
|
}
|
|
}
|
|
|
|
trait B {
|
|
fn fmt(&self) {}
|
|
}
|
|
|
|
impl B for A {
|
|
fn fmt(&self) {
|
|
self.to_string();
|
|
}
|
|
}
|
|
|
|
impl fmt::Display for A {
|
|
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
|
|
write!(f, "{}", self.to_string())
|
|
}
|
|
}
|
|
|
|
fn fmt(a: A) {
|
|
a.to_string();
|
|
}
|
|
|
|
struct C;
|
|
|
|
impl C {
|
|
fn to_string(&self) -> String {
|
|
String::from("I am C")
|
|
}
|
|
}
|
|
|
|
impl fmt::Display for C {
|
|
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
|
|
write!(f, "{}", self.to_string())
|
|
}
|
|
}
|
|
|
|
enum D {
|
|
E(String),
|
|
F,
|
|
}
|
|
|
|
impl std::fmt::Display for D {
|
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
|
match &self {
|
|
Self::E(string) => write!(f, "E {}", string.to_string()),
|
|
Self::F => write!(f, "F"),
|
|
}
|
|
}
|
|
}
|
|
|
|
fn main() {
|
|
let a = A;
|
|
a.to_string();
|
|
a.fmt();
|
|
fmt(a);
|
|
|
|
let c = C;
|
|
c.to_string();
|
|
}
|