mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 21:53:23 +00:00
a37af06fea
* Applying suggested changes from the PR
182 lines
4.4 KiB
Text
182 lines
4.4 KiB
Text
error: this match could be written as a `let` statement
|
|
--> $DIR/match_single_binding.rs:28:5
|
|
|
|
|
LL | / match (a, b, c) {
|
|
LL | | (x, y, z) => {
|
|
LL | | println!("{} {} {}", x, y, z);
|
|
LL | | },
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
= note: `-D clippy::match-single-binding` implied by `-D warnings`
|
|
help: consider using `let` statement
|
|
|
|
|
LL | let (x, y, z) = (a, b, c);
|
|
LL | {
|
|
LL | println!("{} {} {}", x, y, z);
|
|
LL | }
|
|
|
|
|
|
|
error: this match could be written as a `let` statement
|
|
--> $DIR/match_single_binding.rs:34:5
|
|
|
|
|
LL | / match (a, b, c) {
|
|
LL | | (x, y, z) => println!("{} {} {}", x, y, z),
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: consider using `let` statement
|
|
|
|
|
LL | let (x, y, z) = (a, b, c);
|
|
LL | println!("{} {} {}", x, y, z);
|
|
|
|
|
|
|
error: this match could be replaced by its body itself
|
|
--> $DIR/match_single_binding.rs:51:5
|
|
|
|
|
LL | / match a {
|
|
LL | | _ => println!("whatever"),
|
|
LL | | }
|
|
| |_____^ help: consider using the match body instead: `println!("whatever");`
|
|
|
|
error: this match could be replaced by its body itself
|
|
--> $DIR/match_single_binding.rs:55:5
|
|
|
|
|
LL | / match a {
|
|
LL | | _ => {
|
|
LL | | let x = 29;
|
|
LL | | println!("x has a value of {}", x);
|
|
LL | | },
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: consider using the match body instead
|
|
|
|
|
LL | {
|
|
LL | let x = 29;
|
|
LL | println!("x has a value of {}", x);
|
|
LL | }
|
|
|
|
|
|
|
error: this match could be replaced by its body itself
|
|
--> $DIR/match_single_binding.rs:62:5
|
|
|
|
|
LL | / match a {
|
|
LL | | _ => {
|
|
LL | | let e = 5 * a;
|
|
LL | | if e >= 5 {
|
|
... |
|
|
LL | | },
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: consider using the match body instead
|
|
|
|
|
LL | {
|
|
LL | let e = 5 * a;
|
|
LL | if e >= 5 {
|
|
LL | println!("e is superior to 5");
|
|
LL | }
|
|
LL | }
|
|
|
|
|
|
|
error: this match could be written as a `let` statement
|
|
--> $DIR/match_single_binding.rs:72:5
|
|
|
|
|
LL | / match p {
|
|
LL | | Point { x, y } => println!("Coords: ({}, {})", x, y),
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: consider using `let` statement
|
|
|
|
|
LL | let Point { x, y } = p;
|
|
LL | println!("Coords: ({}, {})", x, y);
|
|
|
|
|
|
|
error: this match could be written as a `let` statement
|
|
--> $DIR/match_single_binding.rs:76:5
|
|
|
|
|
LL | / match p {
|
|
LL | | Point { x: x1, y: y1 } => println!("Coords: ({}, {})", x1, y1),
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: consider using `let` statement
|
|
|
|
|
LL | let Point { x: x1, y: y1 } = p;
|
|
LL | println!("Coords: ({}, {})", x1, y1);
|
|
|
|
|
|
|
error: this match could be written as a `let` statement
|
|
--> $DIR/match_single_binding.rs:81:5
|
|
|
|
|
LL | / match x {
|
|
LL | | ref r => println!("Got a reference to {}", r),
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: consider using `let` statement
|
|
|
|
|
LL | let ref r = x;
|
|
LL | println!("Got a reference to {}", r);
|
|
|
|
|
|
|
error: this match could be written as a `let` statement
|
|
--> $DIR/match_single_binding.rs:86:5
|
|
|
|
|
LL | / match x {
|
|
LL | | ref mut mr => println!("Got a mutable reference to {}", mr),
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: consider using `let` statement
|
|
|
|
|
LL | let ref mut mr = x;
|
|
LL | println!("Got a mutable reference to {}", mr);
|
|
|
|
|
|
|
error: this match could be written as a `let` statement
|
|
--> $DIR/match_single_binding.rs:90:5
|
|
|
|
|
LL | / let product = match coords() {
|
|
LL | | Point { x, y } => x * y,
|
|
LL | | };
|
|
| |______^
|
|
|
|
|
help: consider using `let` statement
|
|
|
|
|
LL | let Point { x, y } = coords();
|
|
LL | let product = x * y;
|
|
|
|
|
|
|
error: this match could be written as a `let` statement
|
|
--> $DIR/match_single_binding.rs:98:18
|
|
|
|
|
LL | .map(|i| match i.unwrap() {
|
|
| __________________^
|
|
LL | | unwrapped => unwrapped,
|
|
LL | | })
|
|
| |_________^
|
|
|
|
|
help: consider using `let` statement
|
|
|
|
|
LL | .map(|i| {
|
|
LL | let unwrapped = i.unwrap();
|
|
LL | unwrapped
|
|
LL | })
|
|
|
|
|
|
|
error: this match could be replaced by its body itself
|
|
--> $DIR/match_single_binding.rs:112:5
|
|
|
|
|
LL | / match match y {
|
|
LL | | 0 => 1,
|
|
LL | | _ => 2,
|
|
LL | | } {
|
|
LL | | _ => println!("Single branch"),
|
|
LL | | }
|
|
| |_____^ help: consider using the match body instead: `println!("Single branch");`
|
|
|
|
error: aborting due to 12 previous errors
|
|
|