mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-22 19:13:29 +00:00
78 lines
2.3 KiB
Rust
78 lines
2.3 KiB
Rust
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
use crate::rustc::hir::*;
|
|
use crate::rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
|
|
use crate::rustc::{declare_tool_lint, lint_array};
|
|
use crate::syntax::source_map::{Span, Spanned};
|
|
use if_chain::if_chain;
|
|
|
|
use crate::consts::{self, Constant};
|
|
use crate::utils::span_lint;
|
|
|
|
/// **What it does:** Checks for multiplication by -1 as a form of negation.
|
|
///
|
|
/// **Why is this bad?** It's more readable to just negate.
|
|
///
|
|
/// **Known problems:** This only catches integers (for now).
|
|
///
|
|
/// **Example:**
|
|
/// ```rust
|
|
/// x * -1
|
|
/// ```
|
|
declare_clippy_lint! {
|
|
pub NEG_MULTIPLY,
|
|
style,
|
|
"multiplying integers with -1"
|
|
}
|
|
|
|
#[derive(Copy, Clone)]
|
|
pub struct NegMultiply;
|
|
|
|
impl LintPass for NegMultiply {
|
|
fn get_lints(&self) -> LintArray {
|
|
lint_array!(NEG_MULTIPLY)
|
|
}
|
|
}
|
|
|
|
#[allow(clippy::match_same_arms)]
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NegMultiply {
|
|
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
|
|
if let ExprKind::Binary(
|
|
Spanned {
|
|
node: BinOpKind::Mul, ..
|
|
},
|
|
ref l,
|
|
ref r,
|
|
) = e.node
|
|
{
|
|
match (&l.node, &r.node) {
|
|
(&ExprKind::Unary(..), &ExprKind::Unary(..)) => (),
|
|
(&ExprKind::Unary(UnNeg, ref lit), _) => check_mul(cx, e.span, lit, r),
|
|
(_, &ExprKind::Unary(UnNeg, ref lit)) => check_mul(cx, e.span, lit, l),
|
|
_ => (),
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
fn check_mul(cx: &LateContext<'_, '_>, span: Span, lit: &Expr, exp: &Expr) {
|
|
if_chain! {
|
|
if let ExprKind::Lit(ref l) = lit.node;
|
|
if let Constant::Int(val) = consts::lit_to_constant(&l.node, cx.tables.expr_ty(lit));
|
|
if val == 1;
|
|
if cx.tables.expr_ty(exp).is_integral();
|
|
then {
|
|
span_lint(cx,
|
|
NEG_MULTIPLY,
|
|
span,
|
|
"Negation by multiplying with -1");
|
|
}
|
|
}
|
|
}
|