mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-14 17:07:17 +00:00
38d4ac7cea
Discussion previously happened in https://github.com/rust-lang/rust/pull/43498
94 lines
4.1 KiB
Text
94 lines
4.1 KiB
Text
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:47:11
|
|
|
|
|
LL | fn bad(x: &u32, y: &Foo, z: &Baz) {}
|
|
| ^^^^ help: consider passing by value instead: `u32`
|
|
|
|
|
= note: `-D clippy::trivially-copy-pass-by-ref` implied by `-D warnings`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:47:20
|
|
|
|
|
LL | fn bad(x: &u32, y: &Foo, z: &Baz) {}
|
|
| ^^^^ help: consider passing by value instead: `Foo`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:47:29
|
|
|
|
|
LL | fn bad(x: &u32, y: &Foo, z: &Baz) {}
|
|
| ^^^^ help: consider passing by value instead: `Baz`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:54:12
|
|
|
|
|
LL | fn bad(&self, x: &u32, y: &Foo, z: &Baz) {}
|
|
| ^^^^^ help: consider passing by value instead: `self`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:54:22
|
|
|
|
|
LL | fn bad(&self, x: &u32, y: &Foo, z: &Baz) {}
|
|
| ^^^^ help: consider passing by value instead: `u32`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:54:31
|
|
|
|
|
LL | fn bad(&self, x: &u32, y: &Foo, z: &Baz) {}
|
|
| ^^^^ help: consider passing by value instead: `Foo`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:54:40
|
|
|
|
|
LL | fn bad(&self, x: &u32, y: &Foo, z: &Baz) {}
|
|
| ^^^^ help: consider passing by value instead: `Baz`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:56:16
|
|
|
|
|
LL | fn bad2(x: &u32, y: &Foo, z: &Baz) {}
|
|
| ^^^^ help: consider passing by value instead: `u32`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:56:25
|
|
|
|
|
LL | fn bad2(x: &u32, y: &Foo, z: &Baz) {}
|
|
| ^^^^ help: consider passing by value instead: `Foo`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:56:34
|
|
|
|
|
LL | fn bad2(x: &u32, y: &Foo, z: &Baz) {}
|
|
| ^^^^ help: consider passing by value instead: `Baz`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:68:16
|
|
|
|
|
LL | fn bad2(x: &u32, y: &Foo, z: &Baz) {}
|
|
| ^^^^ help: consider passing by value instead: `u32`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:68:25
|
|
|
|
|
LL | fn bad2(x: &u32, y: &Foo, z: &Baz) {}
|
|
| ^^^^ help: consider passing by value instead: `Foo`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:68:34
|
|
|
|
|
LL | fn bad2(x: &u32, y: &Foo, z: &Baz) {}
|
|
| ^^^^ help: consider passing by value instead: `Baz`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:72:34
|
|
|
|
|
LL | fn trait_method(&self, _foo: &Foo);
|
|
| ^^^^ help: consider passing by value instead: `Foo`
|
|
|
|
error: this argument is passed by reference, but would be more efficient if passed by value
|
|
--> $DIR/trivially_copy_pass_by_ref.rs:76:37
|
|
|
|
|
LL | fn trait_method2(&self, _color: &Color);
|
|
| ^^^^^^ help: consider passing by value instead: `Color`
|
|
|
|
error: aborting due to 15 previous errors
|
|
|