mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-21 10:33:27 +00:00
155 lines
5.1 KiB
Text
155 lines
5.1 KiB
Text
error: equality checks against true are unnecessary
|
|
--> tests/ui/bool_comparison.rs:7:8
|
|
|
|
|
LL | if x == true {
|
|
| ^^^^^^^^^ help: try simplifying it as shown: `x`
|
|
|
|
|
= note: `-D clippy::bool-comparison` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::bool_comparison)]`
|
|
|
|
error: equality checks against false can be replaced by a negation
|
|
--> tests/ui/bool_comparison.rs:12:8
|
|
|
|
|
LL | if x == false {
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `!x`
|
|
|
|
error: equality checks against true are unnecessary
|
|
--> tests/ui/bool_comparison.rs:17:8
|
|
|
|
|
LL | if true == x {
|
|
| ^^^^^^^^^ help: try simplifying it as shown: `x`
|
|
|
|
error: equality checks against false can be replaced by a negation
|
|
--> tests/ui/bool_comparison.rs:22:8
|
|
|
|
|
LL | if false == x {
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `!x`
|
|
|
|
error: inequality checks against true can be replaced by a negation
|
|
--> tests/ui/bool_comparison.rs:27:8
|
|
|
|
|
LL | if x != true {
|
|
| ^^^^^^^^^ help: try simplifying it as shown: `!x`
|
|
|
|
error: inequality checks against false are unnecessary
|
|
--> tests/ui/bool_comparison.rs:32:8
|
|
|
|
|
LL | if x != false {
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `x`
|
|
|
|
error: inequality checks against true can be replaced by a negation
|
|
--> tests/ui/bool_comparison.rs:37:8
|
|
|
|
|
LL | if true != x {
|
|
| ^^^^^^^^^ help: try simplifying it as shown: `!x`
|
|
|
|
error: inequality checks against false are unnecessary
|
|
--> tests/ui/bool_comparison.rs:42:8
|
|
|
|
|
LL | if false != x {
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `x`
|
|
|
|
error: less than comparison against true can be replaced by a negation
|
|
--> tests/ui/bool_comparison.rs:47:8
|
|
|
|
|
LL | if x < true {
|
|
| ^^^^^^^^ help: try simplifying it as shown: `!x`
|
|
|
|
error: greater than checks against false are unnecessary
|
|
--> tests/ui/bool_comparison.rs:52:8
|
|
|
|
|
LL | if false < x {
|
|
| ^^^^^^^^^ help: try simplifying it as shown: `x`
|
|
|
|
error: greater than checks against false are unnecessary
|
|
--> tests/ui/bool_comparison.rs:57:8
|
|
|
|
|
LL | if x > false {
|
|
| ^^^^^^^^^ help: try simplifying it as shown: `x`
|
|
|
|
error: less than comparison against true can be replaced by a negation
|
|
--> tests/ui/bool_comparison.rs:62:8
|
|
|
|
|
LL | if true > x {
|
|
| ^^^^^^^^ help: try simplifying it as shown: `!x`
|
|
|
|
error: order comparisons between booleans can be simplified
|
|
--> tests/ui/bool_comparison.rs:68:8
|
|
|
|
|
LL | if x < y {
|
|
| ^^^^^ help: try simplifying it as shown: `!x & y`
|
|
|
|
error: order comparisons between booleans can be simplified
|
|
--> tests/ui/bool_comparison.rs:73:8
|
|
|
|
|
LL | if x > y {
|
|
| ^^^^^ help: try simplifying it as shown: `x & !y`
|
|
|
|
error: this comparison might be written more concisely
|
|
--> tests/ui/bool_comparison.rs:121:8
|
|
|
|
|
LL | if a == !b {};
|
|
| ^^^^^^^ help: try simplifying it as shown: `a != b`
|
|
|
|
error: this comparison might be written more concisely
|
|
--> tests/ui/bool_comparison.rs:122:8
|
|
|
|
|
LL | if !a == b {};
|
|
| ^^^^^^^ help: try simplifying it as shown: `a != b`
|
|
|
|
error: this comparison might be written more concisely
|
|
--> tests/ui/bool_comparison.rs:126:8
|
|
|
|
|
LL | if b == !a {};
|
|
| ^^^^^^^ help: try simplifying it as shown: `b != a`
|
|
|
|
error: this comparison might be written more concisely
|
|
--> tests/ui/bool_comparison.rs:127:8
|
|
|
|
|
LL | if !b == a {};
|
|
| ^^^^^^^ help: try simplifying it as shown: `b != a`
|
|
|
|
error: equality checks against false can be replaced by a negation
|
|
--> tests/ui/bool_comparison.rs:151:8
|
|
|
|
|
LL | if false == m!(func) {}
|
|
| ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!m!(func)`
|
|
|
|
error: equality checks against false can be replaced by a negation
|
|
--> tests/ui/bool_comparison.rs:152:8
|
|
|
|
|
LL | if m!(func) == false {}
|
|
| ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!m!(func)`
|
|
|
|
error: equality checks against true are unnecessary
|
|
--> tests/ui/bool_comparison.rs:153:8
|
|
|
|
|
LL | if true == m!(func) {}
|
|
| ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `m!(func)`
|
|
|
|
error: equality checks against true are unnecessary
|
|
--> tests/ui/bool_comparison.rs:154:8
|
|
|
|
|
LL | if m!(func) == true {}
|
|
| ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `m!(func)`
|
|
|
|
error: equality checks against false can be replaced by a negation
|
|
--> tests/ui/bool_comparison.rs:171:14
|
|
|
|
|
LL | let _ = ((1 < 2) == false) as usize;
|
|
| ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `1 >= 2`
|
|
|
|
error: equality checks against false can be replaced by a negation
|
|
--> tests/ui/bool_comparison.rs:172:14
|
|
|
|
|
LL | let _ = (false == m!(func)) as usize;
|
|
| ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!m!(func)`
|
|
|
|
error: this comparison might be written more concisely
|
|
--> tests/ui/bool_comparison.rs:175:14
|
|
|
|
|
LL | let _ = ((1 < 2) == !m!(func)) as usize;
|
|
| ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `(1 < 2) != m!(func)`
|
|
|
|
error: aborting due to 25 previous errors
|
|
|