mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 13:43:17 +00:00
179 lines
7.4 KiB
Text
179 lines
7.4 KiB
Text
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:19:23
|
|
|
|
|
LL | fn foo<T: Default>(v: Vec<T>, w: Vec<T>, mut x: Vec<T>, y: Vec<T>) -> Vec<T> {
|
|
| ^^^^^^ help: consider changing the type to: `&[T]`
|
|
|
|
|
= note: `-D clippy::needless-pass-by-value` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::needless_pass_by_value)]`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:35:11
|
|
|
|
|
LL | fn bar(x: String, y: Wrapper) {
|
|
| ^^^^^^ help: consider changing the type to: `&str`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:35:22
|
|
|
|
|
LL | fn bar(x: String, y: Wrapper) {
|
|
| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:43:71
|
|
|
|
|
LL | fn test_borrow_trait<T: Borrow<str>, U: AsRef<str>, V>(t: T, u: U, v: V) {
|
|
| ^ help: consider taking a reference instead: `&V`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:56:18
|
|
|
|
|
LL | fn test_match(x: Option<Option<String>>, y: Option<Option<String>>) {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&Option<Option<String>>`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:70:24
|
|
|
|
|
LL | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
|
|
| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:70:36
|
|
|
|
|
LL | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
|
|
| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:88:49
|
|
|
|
|
LL | fn test_blanket_ref<T: Foo, S: Serialize>(vals: T, serializable: S) {}
|
|
| ^ help: consider taking a reference instead: `&T`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:91:18
|
|
|
|
|
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
|
| ^^^^^^ help: consider taking a reference instead: `&String`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:91:29
|
|
|
|
|
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
|
| ^^^^^^
|
|
|
|
|
help: consider changing the type to
|
|
|
|
|
LL | fn issue_2114(s: String, t: &str, u: Vec<i32>, v: Vec<i32>) {
|
|
| ~~~~
|
|
help: change `t.clone()` to
|
|
|
|
|
LL | let _ = t.to_string();
|
|
| ~~~~~~~~~~~~~
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:91:40
|
|
|
|
|
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
|
| ^^^^^^^^ help: consider taking a reference instead: `&Vec<i32>`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:91:53
|
|
|
|
|
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
|
| ^^^^^^^^
|
|
|
|
|
help: consider changing the type to
|
|
|
|
|
LL | fn issue_2114(s: String, t: String, u: Vec<i32>, v: &[i32]) {
|
|
| ~~~~~~
|
|
help: change `v.clone()` to
|
|
|
|
|
LL | let _ = v.to_owned();
|
|
| ~~~~~~~~~~~~
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:108:12
|
|
|
|
|
LL | s: String,
|
|
| ^^^^^^ help: consider changing the type to: `&str`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:110:12
|
|
|
|
|
LL | t: String,
|
|
| ^^^^^^ help: consider taking a reference instead: `&String`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:120:23
|
|
|
|
|
LL | fn baz(&self, uu: U, ss: Self) {}
|
|
| ^ help: consider taking a reference instead: `&U`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:120:30
|
|
|
|
|
LL | fn baz(&self, uu: U, ss: Self) {}
|
|
| ^^^^ help: consider taking a reference instead: `&Self`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:144:24
|
|
|
|
|
LL | fn bar_copy(x: u32, y: CopyWrapper) {
|
|
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
|
|
|
|
|
help: or consider marking this type as `Copy`
|
|
--> tests/ui/needless_pass_by_value.rs:142:1
|
|
|
|
|
LL | struct CopyWrapper(u32);
|
|
| ^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:151:29
|
|
|
|
|
LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
|
|
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
|
|
|
|
|
help: or consider marking this type as `Copy`
|
|
--> tests/ui/needless_pass_by_value.rs:142:1
|
|
|
|
|
LL | struct CopyWrapper(u32);
|
|
| ^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:151:45
|
|
|
|
|
LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
|
|
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
|
|
|
|
|
help: or consider marking this type as `Copy`
|
|
--> tests/ui/needless_pass_by_value.rs:142:1
|
|
|
|
|
LL | struct CopyWrapper(u32);
|
|
| ^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:151:61
|
|
|
|
|
LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
|
|
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
|
|
|
|
|
help: or consider marking this type as `Copy`
|
|
--> tests/ui/needless_pass_by_value.rs:142:1
|
|
|
|
|
LL | struct CopyWrapper(u32);
|
|
| ^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:166:40
|
|
|
|
|
LL | fn some_fun<'b, S: Bar<'b, ()>>(items: S) {}
|
|
| ^ help: consider taking a reference instead: `&S`
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
--> tests/ui/needless_pass_by_value.rs:172:20
|
|
|
|
|
LL | fn more_fun(items: impl Club<'static, i32>) {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider taking a reference instead: `&impl Club<'static, i32>`
|
|
|
|
error: aborting due to 22 previous errors
|
|
|