mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-14 17:07:17 +00:00
b6581636bd
Add a note when the drop order change may result in different behaviour.
154 lines
5.9 KiB
Text
154 lines
5.9 KiB
Text
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:16:12
|
|
|
|
|
LL | if let Ok(_) = &result {}
|
|
| -------^^^^^---------- help: try this: `if result.is_ok()`
|
|
|
|
|
= note: `-D clippy::redundant-pattern-matching` implied by `-D warnings`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:18:12
|
|
|
|
|
LL | if let Ok(_) = Ok::<i32, i32>(42) {}
|
|
| -------^^^^^--------------------- help: try this: `if Ok::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:20:12
|
|
|
|
|
LL | if let Err(_) = Err::<i32, i32>(42) {}
|
|
| -------^^^^^^---------------------- help: try this: `if Err::<i32, i32>(42).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:22:15
|
|
|
|
|
LL | while let Ok(_) = Ok::<i32, i32>(10) {}
|
|
| ----------^^^^^--------------------- help: try this: `while Ok::<i32, i32>(10).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:24:15
|
|
|
|
|
LL | while let Err(_) = Ok::<i32, i32>(10) {}
|
|
| ----------^^^^^^--------------------- help: try this: `while Ok::<i32, i32>(10).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:34:5
|
|
|
|
|
LL | / match Ok::<i32, i32>(42) {
|
|
LL | | Ok(_) => true,
|
|
LL | | Err(_) => false,
|
|
LL | | };
|
|
| |_____^ help: try this: `Ok::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:39:5
|
|
|
|
|
LL | / match Ok::<i32, i32>(42) {
|
|
LL | | Ok(_) => false,
|
|
LL | | Err(_) => true,
|
|
LL | | };
|
|
| |_____^ help: try this: `Ok::<i32, i32>(42).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:44:5
|
|
|
|
|
LL | / match Err::<i32, i32>(42) {
|
|
LL | | Ok(_) => false,
|
|
LL | | Err(_) => true,
|
|
LL | | };
|
|
| |_____^ help: try this: `Err::<i32, i32>(42).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:49:5
|
|
|
|
|
LL | / match Err::<i32, i32>(42) {
|
|
LL | | Ok(_) => true,
|
|
LL | | Err(_) => false,
|
|
LL | | };
|
|
| |_____^ help: try this: `Err::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:54:20
|
|
|
|
|
LL | let _ = if let Ok(_) = Ok::<usize, ()>(4) { true } else { false };
|
|
| -------^^^^^--------------------- help: try this: `if Ok::<usize, ()>(4).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:60:20
|
|
|
|
|
LL | let _ = if let Ok(_) = gen_res() {
|
|
| -------^^^^^------------ help: try this: `if gen_res().is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:62:19
|
|
|
|
|
LL | } else if let Err(_) = gen_res() {
|
|
| -------^^^^^^------------ help: try this: `if gen_res().is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:85:19
|
|
|
|
|
LL | while let Some(_) = r#try!(result_opt()) {}
|
|
| ----------^^^^^^^----------------------- help: try this: `while r#try!(result_opt()).is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:86:16
|
|
|
|
|
LL | if let Some(_) = r#try!(result_opt()) {}
|
|
| -------^^^^^^^----------------------- help: try this: `if r#try!(result_opt()).is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:92:12
|
|
|
|
|
LL | if let Some(_) = m!() {}
|
|
| -------^^^^^^^------- help: try this: `if m!().is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:93:15
|
|
|
|
|
LL | while let Some(_) = m!() {}
|
|
| ----------^^^^^^^------- help: try this: `while m!().is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:111:12
|
|
|
|
|
LL | if let Ok(_) = Ok::<i32, i32>(42) {}
|
|
| -------^^^^^--------------------- help: try this: `if Ok::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:113:12
|
|
|
|
|
LL | if let Err(_) = Err::<i32, i32>(42) {}
|
|
| -------^^^^^^---------------------- help: try this: `if Err::<i32, i32>(42).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:115:15
|
|
|
|
|
LL | while let Ok(_) = Ok::<i32, i32>(10) {}
|
|
| ----------^^^^^--------------------- help: try this: `while Ok::<i32, i32>(10).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:117:15
|
|
|
|
|
LL | while let Err(_) = Ok::<i32, i32>(10) {}
|
|
| ----------^^^^^^--------------------- help: try this: `while Ok::<i32, i32>(10).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:119:5
|
|
|
|
|
LL | / match Ok::<i32, i32>(42) {
|
|
LL | | Ok(_) => true,
|
|
LL | | Err(_) => false,
|
|
LL | | };
|
|
| |_____^ help: try this: `Ok::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:124:5
|
|
|
|
|
LL | / match Err::<i32, i32>(42) {
|
|
LL | | Ok(_) => false,
|
|
LL | | Err(_) => true,
|
|
LL | | };
|
|
| |_____^ help: try this: `Err::<i32, i32>(42).is_err()`
|
|
|
|
error: aborting due to 22 previous errors
|
|
|