mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-14 17:07:17 +00:00
b6581636bd
Add a note when the drop order change may result in different behaviour.
171 lines
8.5 KiB
Text
171 lines
8.5 KiB
Text
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:12:12
|
|
|
|
|
LL | if let Ok(_) = m.lock() {}
|
|
| -------^^^^^----------- help: try this: `if m.lock().is_ok()`
|
|
|
|
|
= note: `-D clippy::redundant-pattern-matching` implied by `-D warnings`
|
|
= note: this will change drop order of the result, as well as all temporaries
|
|
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:13:12
|
|
|
|
|
LL | if let Err(_) = Err::<(), _>(m.lock().unwrap().0) {}
|
|
| -------^^^^^^------------------------------------ help: try this: `if Err::<(), _>(m.lock().unwrap().0).is_err()`
|
|
|
|
|
= note: this will change drop order of the result, as well as all temporaries
|
|
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:16:16
|
|
|
|
|
LL | if let Ok(_) = Ok::<_, std::sync::MutexGuard<()>>(()) {}
|
|
| -------^^^^^----------------------------------------- help: try this: `if Ok::<_, std::sync::MutexGuard<()>>(()).is_ok()`
|
|
|
|
|
= note: this will change drop order of the result, as well as all temporaries
|
|
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:18:12
|
|
|
|
|
LL | if let Ok(_) = Ok::<_, std::sync::MutexGuard<()>>(()) {
|
|
| -------^^^^^----------------------------------------- help: try this: `if Ok::<_, std::sync::MutexGuard<()>>(()).is_ok()`
|
|
|
|
|
= note: this will change drop order of the result, as well as all temporaries
|
|
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:21:12
|
|
|
|
|
LL | if let Ok(_) = Ok::<_, std::sync::MutexGuard<()>>(()) {}
|
|
| -------^^^^^----------------------------------------- help: try this: `if Ok::<_, std::sync::MutexGuard<()>>(()).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:22:12
|
|
|
|
|
LL | if let Err(_) = Err::<std::sync::MutexGuard<()>, _>(()) {}
|
|
| -------^^^^^^------------------------------------------ help: try this: `if Err::<std::sync::MutexGuard<()>, _>(()).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:24:12
|
|
|
|
|
LL | if let Ok(_) = Ok::<_, ()>(String::new()) {}
|
|
| -------^^^^^----------------------------- help: try this: `if Ok::<_, ()>(String::new()).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:25:12
|
|
|
|
|
LL | if let Err(_) = Err::<(), _>((String::new(), ())) {}
|
|
| -------^^^^^^------------------------------------ help: try this: `if Err::<(), _>((String::new(), ())).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:28:12
|
|
|
|
|
LL | if let Some(_) = Some(m.lock()) {}
|
|
| -------^^^^^^^----------------- help: try this: `if Some(m.lock()).is_some()`
|
|
|
|
|
= note: this will change drop order of the result, as well as all temporaries
|
|
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:29:12
|
|
|
|
|
LL | if let Some(_) = Some(m.lock().unwrap().0) {}
|
|
| -------^^^^^^^---------------------------- help: try this: `if Some(m.lock().unwrap().0).is_some()`
|
|
|
|
|
= note: this will change drop order of the result, as well as all temporaries
|
|
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
|
|
|
|
error: redundant pattern matching, consider using `is_none()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:32:16
|
|
|
|
|
LL | if let None = None::<std::sync::MutexGuard<()>> {}
|
|
| -------^^^^------------------------------------ help: try this: `if None::<std::sync::MutexGuard<()>>.is_none()`
|
|
|
|
|
= note: this will change drop order of the result, as well as all temporaries
|
|
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
|
|
|
|
error: redundant pattern matching, consider using `is_none()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:34:12
|
|
|
|
|
LL | if let None = None::<std::sync::MutexGuard<()>> {
|
|
| -------^^^^------------------------------------ help: try this: `if None::<std::sync::MutexGuard<()>>.is_none()`
|
|
|
|
|
= note: this will change drop order of the result, as well as all temporaries
|
|
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
|
|
|
|
error: redundant pattern matching, consider using `is_none()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:38:12
|
|
|
|
|
LL | if let None = None::<std::sync::MutexGuard<()>> {}
|
|
| -------^^^^------------------------------------ help: try this: `if None::<std::sync::MutexGuard<()>>.is_none()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:40:12
|
|
|
|
|
LL | if let Some(_) = Some(String::new()) {}
|
|
| -------^^^^^^^---------------------- help: try this: `if Some(String::new()).is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:41:12
|
|
|
|
|
LL | if let Some(_) = Some((String::new(), ())) {}
|
|
| -------^^^^^^^---------------------------- help: try this: `if Some((String::new(), ())).is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_ready()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:44:12
|
|
|
|
|
LL | if let Ready(_) = Ready(m.lock()) {}
|
|
| -------^^^^^^^^------------------ help: try this: `if Ready(m.lock()).is_ready()`
|
|
|
|
|
= note: this will change drop order of the result, as well as all temporaries
|
|
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
|
|
|
|
error: redundant pattern matching, consider using `is_ready()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:45:12
|
|
|
|
|
LL | if let Ready(_) = Ready(m.lock().unwrap().0) {}
|
|
| -------^^^^^^^^----------------------------- help: try this: `if Ready(m.lock().unwrap().0).is_ready()`
|
|
|
|
|
= note: this will change drop order of the result, as well as all temporaries
|
|
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
|
|
|
|
error: redundant pattern matching, consider using `is_pending()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:48:16
|
|
|
|
|
LL | if let Pending = Pending::<std::sync::MutexGuard<()>> {}
|
|
| -------^^^^^^^--------------------------------------- help: try this: `if Pending::<std::sync::MutexGuard<()>>.is_pending()`
|
|
|
|
|
= note: this will change drop order of the result, as well as all temporaries
|
|
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
|
|
|
|
error: redundant pattern matching, consider using `is_pending()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:50:12
|
|
|
|
|
LL | if let Pending = Pending::<std::sync::MutexGuard<()>> {
|
|
| -------^^^^^^^--------------------------------------- help: try this: `if Pending::<std::sync::MutexGuard<()>>.is_pending()`
|
|
|
|
|
= note: this will change drop order of the result, as well as all temporaries
|
|
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
|
|
|
|
error: redundant pattern matching, consider using `is_pending()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:54:12
|
|
|
|
|
LL | if let Pending = Pending::<std::sync::MutexGuard<()>> {}
|
|
| -------^^^^^^^--------------------------------------- help: try this: `if Pending::<std::sync::MutexGuard<()>>.is_pending()`
|
|
|
|
error: redundant pattern matching, consider using `is_ready()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:56:12
|
|
|
|
|
LL | if let Ready(_) = Ready(String::new()) {}
|
|
| -------^^^^^^^^----------------------- help: try this: `if Ready(String::new()).is_ready()`
|
|
|
|
error: redundant pattern matching, consider using `is_ready()`
|
|
--> $DIR/redundant_pattern_matching_drop_order.rs:57:12
|
|
|
|
|
LL | if let Ready(_) = Ready((String::new(), ())) {}
|
|
| -------^^^^^^^^----------------------------- help: try this: `if Ready((String::new(), ())).is_ready()`
|
|
|
|
error: aborting due to 22 previous errors
|
|
|