mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-24 12:03:28 +00:00
786f874c34
changelog: none Sorry, this is a big one. A lot of interrelated changes and I wanted to put the new utils to use to make sure they are somewhat battle-tested. We may want to divide some of the lint-specific refactoring commits into batches for smaller reviewing tasks. I could also split into more PRs. Introduces a bunch of new utils at `clippy_utils::macros::...`. Please read through the docs and give any feedback! I'm happy to introduce `MacroCall` and various functions to retrieve an instance. It feels like the missing puzzle piece. I'm also introducing `ExpnId` from rustc as "useful for Clippy too". `@rust-lang/clippy` Fixes #7843 by not parsing every node of macro implementations, at least the major offenders. I probably want to get rid of `is_expn_of` at some point.
74 lines
1.5 KiB
Text
74 lines
1.5 KiB
Text
error: ==-comparison of unit values detected. This will always be true
|
|
--> $DIR/unit_cmp.rs:12:8
|
|
|
|
|
LL | if {
|
|
| ________^
|
|
LL | | true;
|
|
LL | | } == {
|
|
LL | | false;
|
|
LL | | } {}
|
|
| |_____^
|
|
|
|
|
= note: `-D clippy::unit-cmp` implied by `-D warnings`
|
|
|
|
error: >-comparison of unit values detected. This will always be false
|
|
--> $DIR/unit_cmp.rs:18:8
|
|
|
|
|
LL | if {
|
|
| ________^
|
|
LL | | true;
|
|
LL | | } > {
|
|
LL | | false;
|
|
LL | | } {}
|
|
| |_____^
|
|
|
|
error: `assert_eq` of unit values detected. This will always succeed
|
|
--> $DIR/unit_cmp.rs:24:5
|
|
|
|
|
LL | / assert_eq!(
|
|
LL | | {
|
|
LL | | true;
|
|
LL | | },
|
|
... |
|
|
LL | | }
|
|
LL | | );
|
|
| |_____^
|
|
|
|
error: `debug_assert_eq` of unit values detected. This will always succeed
|
|
--> $DIR/unit_cmp.rs:32:5
|
|
|
|
|
LL | / debug_assert_eq!(
|
|
LL | | {
|
|
LL | | true;
|
|
LL | | },
|
|
... |
|
|
LL | | }
|
|
LL | | );
|
|
| |_____^
|
|
|
|
error: `assert_ne` of unit values detected. This will always fail
|
|
--> $DIR/unit_cmp.rs:41:5
|
|
|
|
|
LL | / assert_ne!(
|
|
LL | | {
|
|
LL | | true;
|
|
LL | | },
|
|
... |
|
|
LL | | }
|
|
LL | | );
|
|
| |_____^
|
|
|
|
error: `debug_assert_ne` of unit values detected. This will always fail
|
|
--> $DIR/unit_cmp.rs:49:5
|
|
|
|
|
LL | / debug_assert_ne!(
|
|
LL | | {
|
|
LL | | true;
|
|
LL | | },
|
|
... |
|
|
LL | | }
|
|
LL | | );
|
|
| |_____^
|
|
|
|
error: aborting due to 6 previous errors
|
|
|