mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 13:43:17 +00:00
d0c1605d51
For the degenerate (`map(|(k, _)| k)`/`map(|(_, v)| v)`) cases a mut annotation is superfluous and a ref annotation won't compile, so no additional handling is required. For cases where the `map` call must be preserved ref/mut annotations should also be presereved so that the map body continues to work as expected.
93 lines
3 KiB
Rust
93 lines
3 KiB
Rust
// run-rustfix
|
|
|
|
#![warn(clippy::iter_kv_map)]
|
|
#![allow(unused_mut, clippy::redundant_clone, clippy::suspicious_map, clippy::map_identity)]
|
|
|
|
use std::collections::{BTreeMap, HashMap};
|
|
|
|
fn main() {
|
|
let get_key = |(key, _val)| key;
|
|
fn ref_acceptor(v: &u32) -> u32 {
|
|
*v
|
|
}
|
|
|
|
let map: HashMap<u32, u32> = HashMap::new();
|
|
|
|
let _ = map.keys().collect::<Vec<_>>();
|
|
let _ = map.values().collect::<Vec<_>>();
|
|
let _ = map.values().map(|v| v + 2).collect::<Vec<_>>();
|
|
|
|
let _ = map.clone().into_keys().collect::<Vec<_>>();
|
|
let _ = map.clone().into_keys().map(|key| key + 2).collect::<Vec<_>>();
|
|
|
|
let _ = map.clone().into_values().collect::<Vec<_>>();
|
|
let _ = map.clone().into_values().map(|val| val + 2).collect::<Vec<_>>();
|
|
|
|
let _ = map.clone().values().collect::<Vec<_>>();
|
|
let _ = map.keys().filter(|x| *x % 2 == 0).count();
|
|
|
|
// Don't lint
|
|
let _ = map.iter().filter(|(_, val)| *val % 2 == 0).map(|(key, _)| key).count();
|
|
let _ = map.iter().map(get_key).collect::<Vec<_>>();
|
|
|
|
// Linting the following could be an improvement to the lint
|
|
// map.iter().filter_map(|(_, val)| (val % 2 == 0).then(val * 17)).count();
|
|
|
|
// Lint
|
|
let _ = map.keys().map(|key| key * 9).count();
|
|
let _ = map.values().map(|value| value * 17).count();
|
|
|
|
// Preserve the ref in the fix.
|
|
let _ = map.clone().into_values().map(|ref val| ref_acceptor(val)).count();
|
|
|
|
// Preserve the mut in the fix.
|
|
let _ = map
|
|
.clone().into_values().map(|mut val| {
|
|
val += 2;
|
|
val
|
|
})
|
|
.count();
|
|
|
|
// Don't let a mut interfere.
|
|
let _ = map.clone().into_values().count();
|
|
|
|
let map: BTreeMap<u32, u32> = BTreeMap::new();
|
|
|
|
let _ = map.keys().collect::<Vec<_>>();
|
|
let _ = map.values().collect::<Vec<_>>();
|
|
let _ = map.values().map(|v| v + 2).collect::<Vec<_>>();
|
|
|
|
let _ = map.clone().into_keys().collect::<Vec<_>>();
|
|
let _ = map.clone().into_keys().map(|key| key + 2).collect::<Vec<_>>();
|
|
|
|
let _ = map.clone().into_values().collect::<Vec<_>>();
|
|
let _ = map.clone().into_values().map(|val| val + 2).collect::<Vec<_>>();
|
|
|
|
let _ = map.clone().values().collect::<Vec<_>>();
|
|
let _ = map.keys().filter(|x| *x % 2 == 0).count();
|
|
|
|
// Don't lint
|
|
let _ = map.iter().filter(|(_, val)| *val % 2 == 0).map(|(key, _)| key).count();
|
|
let _ = map.iter().map(get_key).collect::<Vec<_>>();
|
|
|
|
// Linting the following could be an improvement to the lint
|
|
// map.iter().filter_map(|(_, val)| (val % 2 == 0).then(val * 17)).count();
|
|
|
|
// Lint
|
|
let _ = map.keys().map(|key| key * 9).count();
|
|
let _ = map.values().map(|value| value * 17).count();
|
|
|
|
// Preserve the ref in the fix.
|
|
let _ = map.clone().into_values().map(|ref val| ref_acceptor(val)).count();
|
|
|
|
// Preserve the mut in the fix.
|
|
let _ = map
|
|
.clone().into_values().map(|mut val| {
|
|
val += 2;
|
|
val
|
|
})
|
|
.count();
|
|
|
|
// Don't let a mut interfere.
|
|
let _ = map.clone().into_values().count();
|
|
}
|