rust-clippy/clippy_lints/src
Philipp Krones 5ea4771433
Rollup merge of #5412 - dtolnay:tostring, r=flip1995
Downgrade inefficient_to_string to pedantic

From the [documentation](https://rust-lang.github.io/rust-clippy/master/index.html#inefficient_to_string):

> ```diff
> - ["foo", "bar"].iter().map(|s| s.to_string());
>
> + ["foo", "bar"].iter().map(|&s| s.to_string());
> ```

I feel like saving 10 nanoseconds from the formatting machinery isn't worth asking the programmer to insert extra `&` / `*` noise in the *vast* majority of cases. This is a pedantic lint.

changelog: Remove inefficient_to_string from default set of enabled lints
2020-04-08 15:50:19 +02:00
..
methods Rollup merge of #5412 - dtolnay:tostring, r=flip1995 2020-04-08 15:50:19 +02:00
utils Use assoc const NAN for zero_div_zero lint 2020-04-08 00:43:27 +02:00
approx_const.rs clean up a few lint docs 2020-03-18 02:50:39 +01:00
arithmetic.rs integer_arithmetic: detect integer arithmetic on references. 2020-03-18 14:52:01 +01:00
as_conversions.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
assertions_on_constants.rs clean up a few lint docs 2020-03-18 02:50:39 +01:00
assign_ops.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
atomic_ordering.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
attrs.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
bit_mask.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
blacklisted_name.rs Fix fallout 2020-02-21 11:14:18 +01:00
block_in_if_condition.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
booleans.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
bytecount.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
cargo_common_metadata.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
checked_conversions.rs Use int assoc consts in checked_conversions lint 2020-04-08 00:43:27 +02:00
cognitive_complexity.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
collapsible_if.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
comparison_chain.rs Fix fallout 2020-02-21 11:14:18 +01:00
consts.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
copies.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
copy_iterator.rs Rename span_note_and_lint to span_lint_and_note 2020-01-27 11:26:42 +09:00
dbg_macro.rs rustup https://github.com/rust-lang/rust/pull/69589/ 2020-03-15 18:23:43 +01:00
default_trait_access.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
deprecated_lints.rs Deprecate REPLACE_CONSTS lint 2020-03-29 12:59:35 +07:00
derive.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
doc.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
double_comparison.rs Fix fallout 2020-02-21 11:14:18 +01:00
double_parens.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
drop_bounds.rs Fix fallout 2020-02-21 11:14:18 +01:00
drop_forget_ref.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
duration_subsec.rs Fix fallout 2020-02-21 11:14:18 +01:00
else_if_without_else.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
empty_enum.rs Fix fallout 2020-02-21 11:14:18 +01:00
entry.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
enum_clike.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
enum_variants.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
eq_op.rs Fix fallout 2020-02-21 11:14:18 +01:00
erasing_op.rs Fix fallout 2020-02-21 11:14:18 +01:00
escape.rs Rustup to rust-lang/rust#70634 2020-04-02 22:29:41 +02:00
eta_reduction.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
eval_order_dependence.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
excessive_bools.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
exit.rs Rustup to rust-lang/rust#68045 2020-01-13 21:55:57 +09:00
explicit_write.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
fallible_impl_from.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
float_literal.rs Don't import primitive type modules 2020-04-08 00:43:27 +02:00
floating_point_arithmetic.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
format.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
formatting.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
functions.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
get_last_with_len.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
identity_conversion.rs Fix fallout 2020-02-21 11:14:18 +01:00
identity_op.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
if_let_some_result.rs remove redundant import 2020-03-27 20:47:34 +01:00
if_not_else.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
implicit_return.rs Fix ICE with trivial_bounds feature 2020-03-10 13:17:35 +09:00
indexing_slicing.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
infinite_iter.rs Fix fallout 2020-02-21 11:14:18 +01:00
inherent_impl.rs Rustup to rust-lang/rust#66131 2020-03-19 14:33:10 +01:00
inherent_to_string.rs rustup https://github.com/rust-lang/rust/pull/69738 2020-03-16 18:38:30 +01:00
inline_fn_without_body.rs rustup https://github.com/rust-lang/rust/pull/69738 2020-03-16 18:38:30 +01:00
int_plus_one.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
integer_division.rs Rename span_help_and_lint to span_lint_and_help 2020-01-27 11:17:58 +09:00
items_after_statements.rs Remove dependency on matches crate 2020-03-25 07:50:08 +01:00
large_enum_variant.rs Rustup to rust-lang/rust#70634 2020-04-02 22:29:41 +02:00
large_stack_arrays.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
len_zero.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
let_if_seq.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
let_underscore.rs Format clippy_lints/src/let_underscore.rs 2020-04-07 22:19:20 +02:00
lib.rs Rollup merge of #5412 - dtolnay:tostring, r=flip1995 2020-04-08 15:50:19 +02:00
lifetimes.rs don't emit lifetime lints for code inside macros. 2020-03-30 23:22:50 +02:00
literal_representation.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
loops.rs Fix dogfood fallout 2020-04-01 20:24:46 +02:00
macro_use.rs Rename macro_use_import -> macro_use_imports 2020-03-05 19:22:17 +01:00
main_recursion.rs Rename span_help_and_lint to span_lint_and_help 2020-01-27 11:17:58 +09:00
map_clone.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
map_unit_fn.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
matches.rs Move matches test in matches module 2020-04-03 22:02:27 +02:00
mem_discriminant.rs Rustup to rust-lang/rust#68045 2020-01-13 21:55:57 +09:00
mem_forget.rs Rustup to rust-lang/rust#68045 2020-01-13 21:55:57 +09:00
mem_replace.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
minmax.rs Fix fallout 2020-02-21 11:14:18 +01:00
misc.rs Fix float cmp to use assoc fxx::EPSILON 2020-04-08 00:43:27 +02:00
misc_early.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
missing_const_for_fn.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
missing_doc.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
missing_inline.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
modulo_arithmetic.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
multiple_crate_versions.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
mut_key.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
mut_mut.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
mut_reference.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
mutable_debug_assertion.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
mutex_atomic.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
needless_bool.rs Update clippy_lints/src/needless_bool.rs 2020-03-30 12:19:30 -07:00
needless_borrow.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
needless_borrowed_ref.rs Rustup to rust-lang/rust#68045 2020-01-13 21:55:57 +09:00
needless_continue.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
needless_pass_by_value.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
needless_update.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
neg_cmp_op_on_partial_ord.rs Use integer assoc consts in more lint example code 2020-04-08 00:43:27 +02:00
neg_multiply.rs Fix fallout 2020-02-21 11:14:18 +01:00
new_without_default.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
no_effect.rs Make use of or_patterns feature 2020-03-16 07:25:09 +01:00
non_copy_const.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
non_expressive_names.rs rustup https://github.com/rust-lang/rust/pull/69589/ 2020-03-15 18:23:43 +01:00
open_options.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
option_env_unwrap.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
overflow_check_conditional.rs Fix fallout 2020-02-21 11:14:18 +01:00
panic_unimplemented.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
partialeq_ne_impl.rs Fix fallout 2020-02-21 11:14:18 +01:00
path_buf_push_overwrite.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
precedence.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
ptr.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
ptr_offset_with_cast.rs Clean up imports 2020-02-18 22:37:45 +09:00
question_mark.rs Apply suggestions from code review 2020-03-04 22:08:50 +09:00
ranges.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
redundant_clone.rs Rustup to rust-lang/rust#70627 2020-04-01 19:42:15 +02:00
redundant_field_names.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
redundant_pattern_matching.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
redundant_pub_crate.rs move redundant_pub_crate to nursery 2020-03-25 18:14:11 +01:00
redundant_static_lifetimes.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
reference.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
regex.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
returns.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
serde_api.rs Fix fallout 2020-02-21 11:14:18 +01:00
shadow.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
single_component_path_imports.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
slow_vector_initialization.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
strings.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
suspicious_trait_impl.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
swap.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
tabs_in_doc_comments.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
temporary_assignment.rs Clean up imports 2020-02-18 22:37:45 +09:00
to_digit_is_some.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
trait_bounds.rs rustup https://github.com/rust-lang/rust/pull/70344 2020-03-27 20:41:35 +01:00
transmute.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
transmuting_null.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
trivially_copy_pass_by_ref.rs Downgrade trivially_copy_pass_by_ref to pedantic 2020-04-02 18:56:10 -07:00
try_err.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
types.rs Rollup merge of #5409 - dtolnay:letunit, r=flip1995 2020-04-08 15:50:16 +02:00
unicode.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
unnamed_address.rs Lint unnamed address comparisons 2020-03-30 21:42:16 +02:00
unsafe_removed_from_name.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
unused_io_amount.rs Auto merge of #5027 - sinkuu:vectored_io, r=phansch 2020-01-24 06:44:09 +00:00
unused_self.rs Auto merge of #5387 - jpospychala:useless_self_fp, r=yaahc 2020-03-30 18:10:21 +00:00
unwrap.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
use_self.rs use_self: switch to hir_ty_to_ty. 2020-04-07 19:53:02 +00:00
vec.rs rustup https://github.com/rust-lang/rust/pull/70536 2020-03-30 11:17:58 +02:00
verbose_file_reads.rs Move verbose_file_reads to restriction 2020-03-26 15:01:03 +01:00
wildcard_dependencies.rs Rustup to rust-lang/rust#69592 2020-03-01 12:23:33 +09:00
wildcard_imports.rs Rustup to rust-lang/rust#66131 2020-03-19 14:33:10 +01:00
write.rs rustup https://github.com/rust-lang/rust/pull/69838 2020-03-17 10:18:22 +01:00
zero_div_zero.rs Use assoc const NAN for zero_div_zero lint 2020-04-08 00:43:27 +02:00