mirror of
https://github.com/rust-lang/rust-clippy
synced 2025-01-02 08:19:11 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
68 lines
2.2 KiB
Rust
68 lines
2.2 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_help;
|
|
use clippy_utils::source::snippet;
|
|
use if_chain::if_chain;
|
|
use rustc_hir::{Expr, ExprKind};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_middle::mir::interpret::ConstValue;
|
|
use rustc_middle::ty::layout::LayoutOf;
|
|
use rustc_middle::ty::{self, ConstKind};
|
|
use rustc_session::{declare_tool_lint, impl_lint_pass};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for local arrays that may be too large.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Large local arrays may cause stack overflow.
|
|
///
|
|
/// ### Example
|
|
/// ```rust,ignore
|
|
/// let a = [0u32; 1_000_000];
|
|
/// ```
|
|
#[clippy::version = "1.41.0"]
|
|
pub LARGE_STACK_ARRAYS,
|
|
pedantic,
|
|
"allocating large arrays on stack may cause stack overflow"
|
|
}
|
|
|
|
pub struct LargeStackArrays {
|
|
maximum_allowed_size: u64,
|
|
}
|
|
|
|
impl LargeStackArrays {
|
|
#[must_use]
|
|
pub fn new(maximum_allowed_size: u64) -> Self {
|
|
Self { maximum_allowed_size }
|
|
}
|
|
}
|
|
|
|
impl_lint_pass!(LargeStackArrays => [LARGE_STACK_ARRAYS]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for LargeStackArrays {
|
|
fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) {
|
|
if_chain! {
|
|
if let ExprKind::Repeat(_, _) = expr.kind;
|
|
if let ty::Array(element_type, cst) = cx.typeck_results().expr_ty(expr).kind();
|
|
if let ConstKind::Value(ConstValue::Scalar(element_count)) = cst.val;
|
|
if let Ok(element_count) = element_count.to_machine_usize(&cx.tcx);
|
|
if let Ok(element_size) = cx.layout_of(element_type).map(|l| l.size.bytes());
|
|
if self.maximum_allowed_size < element_count * element_size;
|
|
then {
|
|
span_lint_and_help(
|
|
cx,
|
|
LARGE_STACK_ARRAYS,
|
|
expr.span,
|
|
&format!(
|
|
"allocating a local array larger than {} bytes",
|
|
self.maximum_allowed_size
|
|
),
|
|
None,
|
|
&format!(
|
|
"consider allocating on the heap with `vec!{}.into_boxed_slice()`",
|
|
snippet(cx, expr.span, "[...]")
|
|
),
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|