mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-30 16:39:26 +00:00
183 lines
4.3 KiB
Rust
183 lines
4.3 KiB
Rust
#![feature(plugin)]
|
|
#![plugin(clippy)]
|
|
|
|
#[deny(collapsible_if)]
|
|
fn main() {
|
|
let x = "hello";
|
|
let y = "world";
|
|
if x == "hello" {
|
|
//~^ ERROR this if statement can be collapsed
|
|
//~| HELP try
|
|
//~| SUGGESTION if x == "hello" && y == "world" {
|
|
if y == "world" {
|
|
println!("Hello world!");
|
|
}
|
|
}
|
|
|
|
if x == "hello" || x == "world" {
|
|
//~^ ERROR this if statement can be collapsed
|
|
//~| HELP try
|
|
//~| SUGGESTION if (x == "hello" || x == "world") && (y == "world" || y == "hello") {
|
|
if y == "world" || y == "hello" {
|
|
println!("Hello world!");
|
|
}
|
|
}
|
|
|
|
if x == "hello" && x == "world" {
|
|
//~^ ERROR this if statement can be collapsed
|
|
//~| HELP try
|
|
//~| SUGGESTION if x == "hello" && x == "world" && (y == "world" || y == "hello") {
|
|
if y == "world" || y == "hello" {
|
|
println!("Hello world!");
|
|
}
|
|
}
|
|
|
|
if x == "hello" || x == "world" {
|
|
//~^ ERROR this if statement can be collapsed
|
|
//~| HELP try
|
|
//~| SUGGESTION if (x == "hello" || x == "world") && y == "world" && y == "hello" {
|
|
if y == "world" && y == "hello" {
|
|
println!("Hello world!");
|
|
}
|
|
}
|
|
|
|
if x == "hello" && x == "world" {
|
|
//~^ ERROR this if statement can be collapsed
|
|
//~| HELP try
|
|
//~| SUGGESTION if x == "hello" && x == "world" && y == "world" && y == "hello" {
|
|
if y == "world" && y == "hello" {
|
|
println!("Hello world!");
|
|
}
|
|
}
|
|
|
|
if 42 == 1337 {
|
|
//~^ ERROR this if statement can be collapsed
|
|
//~| HELP try
|
|
//~| SUGGESTION if 42 == 1337 && 'a' != 'A' {
|
|
if 'a' != 'A' {
|
|
println!("world!")
|
|
}
|
|
}
|
|
|
|
// Collaspe `else { if .. }` to `else if ..`
|
|
if x == "hello" {
|
|
print!("Hello ");
|
|
} else {
|
|
//~^ ERROR: this `else { if .. }`
|
|
//~| HELP try
|
|
//~| SUGGESTION } else if y == "world"
|
|
if y == "world" {
|
|
println!("world!")
|
|
}
|
|
}
|
|
|
|
if x == "hello" {
|
|
print!("Hello ");
|
|
} else {
|
|
//~^ ERROR: this `else { if .. }`
|
|
//~| HELP try
|
|
//~| SUGGESTION } else if let Some(42)
|
|
if let Some(42) = Some(42) {
|
|
println!("world!")
|
|
}
|
|
}
|
|
|
|
if x == "hello" {
|
|
print!("Hello ");
|
|
} else {
|
|
//~^ ERROR this `else { if .. }`
|
|
//~| HELP try
|
|
//~| SUGGESTION } else if y == "world"
|
|
if y == "world" {
|
|
println!("world")
|
|
}
|
|
else {
|
|
println!("!")
|
|
}
|
|
}
|
|
|
|
if x == "hello" {
|
|
print!("Hello ");
|
|
} else {
|
|
//~^ ERROR this `else { if .. }`
|
|
//~| HELP try
|
|
//~| SUGGESTION } else if let Some(42)
|
|
if let Some(42) = Some(42) {
|
|
println!("world")
|
|
}
|
|
else {
|
|
println!("!")
|
|
}
|
|
}
|
|
|
|
if let Some(42) = Some(42) {
|
|
print!("Hello ");
|
|
} else {
|
|
//~^ ERROR this `else { if .. }`
|
|
//~| HELP try
|
|
//~| SUGGESTION } else if let Some(42)
|
|
if let Some(42) = Some(42) {
|
|
println!("world")
|
|
}
|
|
else {
|
|
println!("!")
|
|
}
|
|
}
|
|
|
|
if let Some(42) = Some(42) {
|
|
print!("Hello ");
|
|
} else {
|
|
//~^ ERROR this `else { if .. }`
|
|
//~| HELP try
|
|
//~| SUGGESTION } else if x == "hello"
|
|
if x == "hello" {
|
|
println!("world")
|
|
}
|
|
else {
|
|
println!("!")
|
|
}
|
|
}
|
|
|
|
if let Some(42) = Some(42) {
|
|
print!("Hello ");
|
|
} else {
|
|
//~^ ERROR this `else { if .. }`
|
|
//~| HELP try
|
|
//~| SUGGESTION } else if let Some(42)
|
|
if let Some(42) = Some(42) {
|
|
println!("world")
|
|
}
|
|
else {
|
|
println!("!")
|
|
}
|
|
}
|
|
|
|
// Works because any if with an else statement cannot be collapsed.
|
|
if x == "hello" {
|
|
if y == "world" {
|
|
println!("Hello world!");
|
|
}
|
|
} else {
|
|
println!("Not Hello world");
|
|
}
|
|
|
|
if x == "hello" {
|
|
if y == "world" {
|
|
println!("Hello world!");
|
|
} else {
|
|
println!("Hello something else");
|
|
}
|
|
}
|
|
|
|
if x == "hello" {
|
|
print!("Hello ");
|
|
if y == "world" {
|
|
println!("world!")
|
|
}
|
|
}
|
|
|
|
if true {
|
|
} else {
|
|
assert!(true); // assert! is just an `if`
|
|
}
|
|
}
|