mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-01 00:49:30 +00:00
8b25e53d50
A u128 has an 8 byte alignment on x86, but a 16 byte alignment on aarch64 which changes the size of the enums due to extra padding
279 lines
9.8 KiB
Text
279 lines
9.8 KiB
Text
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:10:1
|
|
|
|
|
LL | / enum LargeEnum {
|
|
LL | | A(i32),
|
|
| | ------ the second-largest variant contains at least 4 bytes
|
|
LL | | B([i32; 8000]),
|
|
| | -------------- the largest variant contains at least 32000 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 32004 bytes
|
|
|
|
|
= note: `-D clippy::large-enum-variant` implied by `-D warnings`
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
|
|
|
LL | B(Box<[i32; 8000]>),
|
|
| ~~~~~~~~~~~~~~~~
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:34:1
|
|
|
|
|
LL | / enum LargeEnum2 {
|
|
LL | | VariantOk(i32, u32),
|
|
| | ------------------- the second-largest variant contains at least 8 bytes
|
|
LL | | ContainingLargeEnum(LargeEnum),
|
|
| | ------------------------------ the largest variant contains at least 32004 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 32008 bytes
|
|
|
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
|
|
|
LL | ContainingLargeEnum(Box<LargeEnum>),
|
|
| ~~~~~~~~~~~~~~
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:39:1
|
|
|
|
|
LL | / enum LargeEnum3 {
|
|
LL | | ContainingMoreThanOneField(i32, [i32; 8000], [i32; 9500]),
|
|
| | --------------------------------------------------------- the largest variant contains at least 70004 bytes
|
|
LL | | VoidVariant,
|
|
LL | | StructLikeLittle { x: i32, y: i32 },
|
|
| | ----------------------------------- the second-largest variant contains at least 8 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 70008 bytes
|
|
|
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
|
|
|
LL | ContainingMoreThanOneField(i32, Box<[i32; 8000]>, Box<[i32; 9500]>),
|
|
| ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:45:1
|
|
|
|
|
LL | / enum LargeEnum4 {
|
|
LL | | VariantOk(i32, u32),
|
|
| | ------------------- the second-largest variant contains at least 8 bytes
|
|
LL | | StructLikeLarge { x: [i32; 8000], y: i32 },
|
|
| | ------------------------------------------ the largest variant contains at least 32004 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 32008 bytes
|
|
|
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
|
|
|
LL | StructLikeLarge { x: Box<[i32; 8000]>, y: i32 },
|
|
| ~~~~~~~~~~~~~~~~
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:50:1
|
|
|
|
|
LL | / enum LargeEnum5 {
|
|
LL | | VariantOk(i32, u32),
|
|
| | ------------------- the second-largest variant contains at least 8 bytes
|
|
LL | | StructLikeLarge2 { x: [i32; 8000] },
|
|
| | ----------------------------------- the largest variant contains at least 32000 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 32004 bytes
|
|
|
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
|
|
|
LL | StructLikeLarge2 { x: Box<[i32; 8000]> },
|
|
| ~~~~~~~~~~~~~~~~
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:66:1
|
|
|
|
|
LL | / enum LargeEnum7 {
|
|
LL | | A,
|
|
LL | | B([u8; 1255]),
|
|
| | ------------- the largest variant contains at least 1255 bytes
|
|
LL | | C([u8; 200]),
|
|
| | ------------ the second-largest variant contains at least 200 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 1256 bytes
|
|
|
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
|
|
|
LL | B(Box<[u8; 1255]>),
|
|
| ~~~~~~~~~~~~~~~
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:72:1
|
|
|
|
|
LL | / enum LargeEnum8 {
|
|
LL | | VariantOk(i32, u32),
|
|
| | ------------------- the second-largest variant contains at least 8 bytes
|
|
LL | | ContainingMoreThanOneField([i32; 8000], [i32; 2], [i32; 9500], [i32; 30]),
|
|
| | ------------------------------------------------------------------------- the largest variant contains at least 70128 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 70132 bytes
|
|
|
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
|
|
|
LL | ContainingMoreThanOneField(Box<[i32; 8000]>, [i32; 2], Box<[i32; 9500]>, [i32; 30]),
|
|
| ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:77:1
|
|
|
|
|
LL | / enum LargeEnum9 {
|
|
LL | | A(Struct<()>),
|
|
| | ------------- the second-largest variant contains at least 4 bytes
|
|
LL | | B(Struct2),
|
|
| | ---------- the largest variant contains at least 32000 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 32004 bytes
|
|
|
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
|
|
|
LL | B(Box<Struct2>),
|
|
| ~~~~~~~~~~~~
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:82:1
|
|
|
|
|
LL | / enum LargeEnumOk2<T> {
|
|
LL | | A(T),
|
|
| | ---- the second-largest variant contains at least 0 bytes
|
|
LL | | B(Struct2),
|
|
| | ---------- the largest variant contains at least 32000 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 32000 bytes
|
|
|
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
|
|
|
LL | B(Box<Struct2>),
|
|
| ~~~~~~~~~~~~
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:87:1
|
|
|
|
|
LL | / enum LargeEnumOk3<T> {
|
|
LL | | A(Struct<T>),
|
|
| | ------------ the second-largest variant contains at least 4 bytes
|
|
LL | | B(Struct2),
|
|
| | ---------- the largest variant contains at least 32000 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 32000 bytes
|
|
|
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
|
|
|
LL | B(Box<Struct2>),
|
|
| ~~~~~~~~~~~~
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:102:1
|
|
|
|
|
LL | / enum CopyableLargeEnum {
|
|
LL | | A(bool),
|
|
| | ------- the second-largest variant contains at least 1 bytes
|
|
LL | | B([u64; 8000]),
|
|
| | -------------- the largest variant contains at least 64000 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 64008 bytes
|
|
|
|
|
note: boxing a variant would require the type no longer be `Copy`
|
|
--> $DIR/large_enum_variant.rs:102:6
|
|
|
|
|
LL | enum CopyableLargeEnum {
|
|
| ^^^^^^^^^^^^^^^^^
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
--> $DIR/large_enum_variant.rs:104:5
|
|
|
|
|
LL | B([u64; 8000]),
|
|
| ^^^^^^^^^^^^^^
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:107:1
|
|
|
|
|
LL | / enum ManuallyCopyLargeEnum {
|
|
LL | | A(bool),
|
|
| | ------- the second-largest variant contains at least 1 bytes
|
|
LL | | B([u64; 8000]),
|
|
| | -------------- the largest variant contains at least 64000 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 64008 bytes
|
|
|
|
|
note: boxing a variant would require the type no longer be `Copy`
|
|
--> $DIR/large_enum_variant.rs:107:6
|
|
|
|
|
LL | enum ManuallyCopyLargeEnum {
|
|
| ^^^^^^^^^^^^^^^^^^^^^
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
--> $DIR/large_enum_variant.rs:109:5
|
|
|
|
|
LL | B([u64; 8000]),
|
|
| ^^^^^^^^^^^^^^
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:120:1
|
|
|
|
|
LL | / enum SomeGenericPossiblyCopyEnum<T> {
|
|
LL | | A(bool, std::marker::PhantomData<T>),
|
|
| | ------------------------------------ the second-largest variant contains at least 1 bytes
|
|
LL | | B([u64; 4000]),
|
|
| | -------------- the largest variant contains at least 32000 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 32008 bytes
|
|
|
|
|
note: boxing a variant would require the type no longer be `Copy`
|
|
--> $DIR/large_enum_variant.rs:120:6
|
|
|
|
|
LL | enum SomeGenericPossiblyCopyEnum<T> {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
--> $DIR/large_enum_variant.rs:122:5
|
|
|
|
|
LL | B([u64; 4000]),
|
|
| ^^^^^^^^^^^^^^
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:133:1
|
|
|
|
|
LL | / enum LargeEnumWithGenerics<T> {
|
|
LL | | Small,
|
|
| | ----- the second-largest variant carries no data at all
|
|
LL | | Large((T, [u8; 512])),
|
|
| | --------------------- the largest variant contains at least 512 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 512 bytes
|
|
|
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
|
|
|
LL | Large(Box<(T, [u8; 512])>),
|
|
| ~~~~~~~~~~~~~~~~~~~
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:142:1
|
|
|
|
|
LL | / enum WithGenerics {
|
|
LL | | Large([Foo<u64>; 64]),
|
|
| | --------------------- the largest variant contains at least 512 bytes
|
|
LL | | Small(u8),
|
|
| | --------- the second-largest variant contains at least 1 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 520 bytes
|
|
|
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
|
|
|
LL | Large(Box<[Foo<u64>; 64]>),
|
|
| ~~~~~~~~~~~~~~~~~~~
|
|
|
|
error: large size difference between variants
|
|
--> $DIR/large_enum_variant.rs:152:1
|
|
|
|
|
LL | / enum LargeEnumOfConst {
|
|
LL | | Ok,
|
|
| | -- the second-largest variant carries no data at all
|
|
LL | | Error(PossiblyLargeEnumWithConst<256>),
|
|
| | -------------------------------------- the largest variant contains at least 514 bytes
|
|
LL | | }
|
|
| |_^ the entire enum is at least 514 bytes
|
|
|
|
|
help: consider boxing the large fields to reduce the total size of the enum
|
|
|
|
|
LL | Error(Box<PossiblyLargeEnumWithConst<256>>),
|
|
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
error: aborting due to 16 previous errors
|
|
|