mirror of
https://github.com/rust-lang/rust-clippy
synced 2025-01-02 00:09:08 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
70 lines
2.3 KiB
Rust
70 lines
2.3 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_sugg;
|
|
use clippy_utils::ty::is_type_diagnostic_item;
|
|
use if_chain::if_chain;
|
|
use rustc_errors::Applicability;
|
|
use rustc_hir::{Expr, ExprKind, Mutability};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_middle::ty;
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use rustc_span::sym;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for `&mut Mutex::lock` calls
|
|
///
|
|
/// ### Why is this bad?
|
|
/// `Mutex::lock` is less efficient than
|
|
/// calling `Mutex::get_mut`. In addition you also have a statically
|
|
/// guarantee that the mutex isn't locked, instead of just a runtime
|
|
/// guarantee.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// use std::sync::{Arc, Mutex};
|
|
///
|
|
/// let mut value_rc = Arc::new(Mutex::new(42_u8));
|
|
/// let value_mutex = Arc::get_mut(&mut value_rc).unwrap();
|
|
///
|
|
/// let mut value = value_mutex.lock().unwrap();
|
|
/// *value += 1;
|
|
/// ```
|
|
/// Use instead:
|
|
/// ```rust
|
|
/// use std::sync::{Arc, Mutex};
|
|
///
|
|
/// let mut value_rc = Arc::new(Mutex::new(42_u8));
|
|
/// let value_mutex = Arc::get_mut(&mut value_rc).unwrap();
|
|
///
|
|
/// let value = value_mutex.get_mut().unwrap();
|
|
/// *value += 1;
|
|
/// ```
|
|
#[clippy::version = "1.49.0"]
|
|
pub MUT_MUTEX_LOCK,
|
|
style,
|
|
"`&mut Mutex::lock` does unnecessary locking"
|
|
}
|
|
|
|
declare_lint_pass!(MutMutexLock => [MUT_MUTEX_LOCK]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for MutMutexLock {
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, ex: &'tcx Expr<'tcx>) {
|
|
if_chain! {
|
|
if let ExprKind::MethodCall(path, method_span, [self_arg, ..], _) = &ex.kind;
|
|
if path.ident.name == sym!(lock);
|
|
let ty = cx.typeck_results().expr_ty(self_arg);
|
|
if let ty::Ref(_, inner_ty, Mutability::Mut) = ty.kind();
|
|
if is_type_diagnostic_item(cx, inner_ty, sym::Mutex);
|
|
then {
|
|
span_lint_and_sugg(
|
|
cx,
|
|
MUT_MUTEX_LOCK,
|
|
*method_span,
|
|
"calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference",
|
|
"change this to",
|
|
"get_mut".to_owned(),
|
|
Applicability::MaybeIncorrect,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|