mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 05:33:27 +00:00
198 lines
6.8 KiB
Text
198 lines
6.8 KiB
Text
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/or_fun_call.rs:49:22
|
|
|
|
|
LL | with_constructor.unwrap_or(make());
|
|
| ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(make)`
|
|
|
|
|
= note: `-D clippy::or-fun-call` implied by `-D warnings`
|
|
|
|
error: use of `unwrap_or` followed by a call to `new`
|
|
--> $DIR/or_fun_call.rs:52:5
|
|
|
|
|
LL | with_new.unwrap_or(Vec::new());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_new.unwrap_or_default()`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/or_fun_call.rs:55:21
|
|
|
|
|
LL | with_const_args.unwrap_or(Vec::with_capacity(12));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Vec::with_capacity(12))`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/or_fun_call.rs:58:14
|
|
|
|
|
LL | with_err.unwrap_or(make());
|
|
| ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| make())`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/or_fun_call.rs:61:19
|
|
|
|
|
LL | with_err_args.unwrap_or(Vec::with_capacity(12));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Vec::with_capacity(12))`
|
|
|
|
error: use of `unwrap_or` followed by a call to `default`
|
|
--> $DIR/or_fun_call.rs:64:5
|
|
|
|
|
LL | with_default_trait.unwrap_or(Default::default());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_trait.unwrap_or_default()`
|
|
|
|
error: use of `unwrap_or` followed by a call to `default`
|
|
--> $DIR/or_fun_call.rs:67:5
|
|
|
|
|
LL | with_default_type.unwrap_or(u64::default());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_type.unwrap_or_default()`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/or_fun_call.rs:70:18
|
|
|
|
|
LL | self_default.unwrap_or(<FakeDefault>::default());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(<FakeDefault>::default)`
|
|
|
|
error: use of `unwrap_or` followed by a call to `default`
|
|
--> $DIR/or_fun_call.rs:73:5
|
|
|
|
|
LL | real_default.unwrap_or(<FakeDefault as Default>::default());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `real_default.unwrap_or_default()`
|
|
|
|
error: use of `unwrap_or` followed by a call to `new`
|
|
--> $DIR/or_fun_call.rs:76:5
|
|
|
|
|
LL | with_vec.unwrap_or(vec![]);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_vec.unwrap_or_default()`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/or_fun_call.rs:79:21
|
|
|
|
|
LL | without_default.unwrap_or(Foo::new());
|
|
| ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Foo::new)`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/or_fun_call.rs:94:21
|
|
|
|
|
LL | let _ = stringy.unwrap_or("".to_owned());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/or_fun_call.rs:102:21
|
|
|
|
|
LL | let _ = Some(1).unwrap_or(map[&1]);
|
|
| ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| map[&1])`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/or_fun_call.rs:104:21
|
|
|
|
|
LL | let _ = Some(1).unwrap_or(map[&1]);
|
|
| ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| map[&1])`
|
|
|
|
error: use of `or` followed by a function call
|
|
--> $DIR/or_fun_call.rs:128:35
|
|
|
|
|
LL | let _ = Some("a".to_string()).or(Some("b".to_string()));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some("b".to_string()))`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/or_fun_call.rs:167:14
|
|
|
|
|
LL | None.unwrap_or(ptr_to_ref(s));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ptr_to_ref(s))`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/or_fun_call.rs:173:14
|
|
|
|
|
LL | None.unwrap_or(unsafe { ptr_to_ref(s) });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| unsafe { ptr_to_ref(s) })`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/or_fun_call.rs:175:14
|
|
|
|
|
LL | None.unwrap_or( unsafe { ptr_to_ref(s) } );
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| unsafe { ptr_to_ref(s) })`
|
|
|
|
error: use of `unwrap_or` followed by a call to `new`
|
|
--> $DIR/or_fun_call.rs:182:9
|
|
|
|
|
LL | / frames
|
|
LL | | .iter()
|
|
LL | | .map(|f: &String| f.to_lowercase())
|
|
LL | | .reduce(|mut acc, f| {
|
|
... |
|
|
LL | | })
|
|
LL | | .unwrap_or(String::new());
|
|
| |_____________________________________^
|
|
|
|
|
help: try this
|
|
|
|
|
LL ~ frames
|
|
LL + .iter()
|
|
LL + .map(|f: &String| f.to_lowercase())
|
|
LL + .reduce(|mut acc, f| {
|
|
LL + acc.push_str(&f);
|
|
LL + acc
|
|
LL ~ }).unwrap_or_default();
|
|
|
|
|
|
|
error: use of `unwrap_or` followed by a call to `new`
|
|
--> $DIR/or_fun_call.rs:195:9
|
|
|
|
|
LL | / iter.map(|f: &String| f.to_lowercase())
|
|
LL | | .reduce(|mut acc, f| {
|
|
LL | | let _ = "";
|
|
LL | | let _ = "";
|
|
... |
|
|
LL | | })
|
|
LL | | .unwrap_or(String::new());
|
|
| |_____________________________________^
|
|
|
|
|
help: try this
|
|
|
|
|
LL ~ iter.map(|f: &String| f.to_lowercase())
|
|
LL + .reduce(|mut acc, f| {
|
|
LL + let _ = "";
|
|
LL + let _ = "";
|
|
LL + acc.push_str(&f);
|
|
LL + acc
|
|
LL ~ }).unwrap_or_default();
|
|
|
|
|
|
|
error: use of `unwrap_or` followed by a call to `new`
|
|
--> $DIR/or_fun_call.rs:208:9
|
|
|
|
|
LL | / iter.map(|f: &String| f.to_lowercase())
|
|
LL | | .reduce(|mut acc, f| {
|
|
LL | | let _ = "";
|
|
LL | | acc.push_str(&f);
|
|
LL | | acc
|
|
LL | | })
|
|
LL | | .unwrap_or(String::new());
|
|
| |_____________________________________^
|
|
|
|
|
help: try this
|
|
|
|
|
LL ~ iter.map(|f: &String| f.to_lowercase())
|
|
LL + .reduce(|mut acc, f| {
|
|
LL + let _ = "";
|
|
LL + acc.push_str(&f);
|
|
LL + acc
|
|
LL ~ }).unwrap_or_default();
|
|
|
|
|
|
|
error: use of `unwrap_or` followed by a call to `new`
|
|
--> $DIR/or_fun_call.rs:221:9
|
|
|
|
|
LL | / map.reduce(|mut acc, f| {
|
|
LL | | acc.push_str(&f);
|
|
LL | | acc
|
|
LL | | })
|
|
LL | | .unwrap_or(String::new());
|
|
| |_________________________________^
|
|
|
|
|
help: try this
|
|
|
|
|
LL ~ map.reduce(|mut acc, f| {
|
|
LL + acc.push_str(&f);
|
|
LL + acc
|
|
LL ~ }).unwrap_or_default();
|
|
|
|
|
|
|
error: aborting due to 22 previous errors
|
|
|