mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-24 12:03:28 +00:00
38d4ac7cea
Discussion previously happened in https://github.com/rust-lang/rust/pull/43498
43 lines
1.2 KiB
Rust
43 lines
1.2 KiB
Rust
#[warn(clippy::needless_borrowed_reference)]
|
|
#[allow(unused_variables)]
|
|
fn main() {
|
|
let mut v = Vec::<String>::new();
|
|
let _ = v.iter_mut().filter(|&ref a| a.is_empty());
|
|
// ^ should be linted
|
|
|
|
let var = 3;
|
|
let thingy = Some(&var);
|
|
if let Some(&ref v) = thingy {
|
|
// ^ should be linted
|
|
}
|
|
|
|
let mut var2 = 5;
|
|
let thingy2 = Some(&mut var2);
|
|
if let Some(&mut ref mut v) = thingy2 {
|
|
// ^ should *not* be linted
|
|
// v is borrowed as mutable.
|
|
*v = 10;
|
|
}
|
|
if let Some(&mut ref v) = thingy2 {
|
|
// ^ should *not* be linted
|
|
// here, v is borrowed as immutable.
|
|
// can't do that:
|
|
//*v = 15;
|
|
}
|
|
}
|
|
|
|
#[allow(dead_code)]
|
|
enum Animal {
|
|
Cat(u64),
|
|
Dog(u64),
|
|
}
|
|
|
|
#[allow(unused_variables)]
|
|
#[allow(dead_code)]
|
|
fn foo(a: &Animal, b: &Animal) {
|
|
match (a, b) {
|
|
(&Animal::Cat(v), &ref k) | (&ref k, &Animal::Cat(v)) => (), // lifetime mismatch error if there is no '&ref'
|
|
// ^ and ^ should *not* be linted
|
|
(&Animal::Dog(ref a), &Animal::Dog(_)) => (), // ^ should *not* be linted
|
|
}
|
|
}
|