mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-22 02:53:20 +00:00
421 lines
14 KiB
Text
421 lines
14 KiB
Text
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:38:14
|
|
|
|
|
38 | for i in 0..vec.len() {
|
|
| ^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::needless-range-loop` implied by `-D warnings`
|
|
help: consider using an iterator
|
|
|
|
|
38 | for <item> in &vec {
|
|
| ^^^^^^ ^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:47:14
|
|
|
|
|
47 | for i in 0..vec.len() {
|
|
| ^^^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
47 | for <item> in &vec {
|
|
| ^^^^^^ ^^^^
|
|
|
|
error: the loop variable `j` is only used to index `STATIC`.
|
|
--> $DIR/for_loop.rs:52:14
|
|
|
|
|
52 | for j in 0..4 {
|
|
| ^^^^
|
|
help: consider using an iterator
|
|
|
|
|
52 | for <item> in &STATIC {
|
|
| ^^^^^^ ^^^^^^^
|
|
|
|
error: the loop variable `j` is only used to index `CONST`.
|
|
--> $DIR/for_loop.rs:56:14
|
|
|
|
|
56 | for j in 0..4 {
|
|
| ^^^^
|
|
help: consider using an iterator
|
|
|
|
|
56 | for <item> in &CONST {
|
|
| ^^^^^^ ^^^^^^
|
|
|
|
error: the loop variable `i` is used to index `vec`
|
|
--> $DIR/for_loop.rs:60:14
|
|
|
|
|
60 | for i in 0..vec.len() {
|
|
| ^^^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
60 | for (i, <item>) in vec.iter().enumerate() {
|
|
| ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec2`.
|
|
--> $DIR/for_loop.rs:68:14
|
|
|
|
|
68 | for i in 0..vec.len() {
|
|
| ^^^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
68 | for <item> in vec2.iter().take(vec.len()) {
|
|
| ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:72:14
|
|
|
|
|
72 | for i in 5..vec.len() {
|
|
| ^^^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
72 | for <item> in vec.iter().skip(5) {
|
|
| ^^^^^^ ^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:76:14
|
|
|
|
|
76 | for i in 0..MAX_LEN {
|
|
| ^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
76 | for <item> in vec.iter().take(MAX_LEN) {
|
|
| ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:80:14
|
|
|
|
|
80 | for i in 0..=MAX_LEN {
|
|
| ^^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
80 | for <item> in vec.iter().take(MAX_LEN + 1) {
|
|
| ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:84:14
|
|
|
|
|
84 | for i in 5..10 {
|
|
| ^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
84 | for <item> in vec.iter().take(10).skip(5) {
|
|
| ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:88:14
|
|
|
|
|
88 | for i in 5..=10 {
|
|
| ^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
88 | for <item> in vec.iter().take(10 + 1).skip(5) {
|
|
| ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is used to index `vec`
|
|
--> $DIR/for_loop.rs:92:14
|
|
|
|
|
92 | for i in 5..vec.len() {
|
|
| ^^^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
92 | for (i, <item>) in vec.iter().enumerate().skip(5) {
|
|
| ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is used to index `vec`
|
|
--> $DIR/for_loop.rs:96:14
|
|
|
|
|
96 | for i in 5..10 {
|
|
| ^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
96 | for (i, <item>) in vec.iter().enumerate().take(10).skip(5) {
|
|
| ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:100:14
|
|
|
|
|
100 | for i in 10..0 {
|
|
| ^^^^^
|
|
|
|
|
= note: `-D clippy::reverse-range-loop` implied by `-D warnings`
|
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
|
|
|
|
100 | for i in (0..10).rev() {
|
|
| ^^^^^^^^^^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:104:14
|
|
|
|
|
104 | for i in 10..=0 {
|
|
| ^^^^^^
|
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
|
|
|
|
104 | for i in (0...10).rev() {
|
|
| ^^^^^^^^^^^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:108:14
|
|
|
|
|
108 | for i in MAX_LEN..0 {
|
|
| ^^^^^^^^^^
|
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
|
|
|
|
108 | for i in (0..MAX_LEN).rev() {
|
|
| ^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:112:14
|
|
|
|
|
112 | for i in 5..5 {
|
|
| ^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:137:14
|
|
|
|
|
137 | for i in 10..5 + 4 {
|
|
| ^^^^^^^^^
|
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
|
|
|
|
137 | for i in (5 + 4..10).rev() {
|
|
| ^^^^^^^^^^^^^^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:141:14
|
|
|
|
|
141 | for i in (5 + 2)..(3 - 1) {
|
|
| ^^^^^^^^^^^^^^^^
|
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
|
|
|
|
141 | for i in ((3 - 1)..(5 + 2)).rev() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:145:14
|
|
|
|
|
145 | for i in (5 + 2)..(8 - 1) {
|
|
| ^^^^^^^^^^^^^^^^
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:167:15
|
|
|
|
|
167 | for _v in vec.iter() {}
|
|
| ^^^^^^^^^^ help: to write this more concisely, try: `&vec`
|
|
|
|
|
= note: `-D clippy::explicit-iter-loop` implied by `-D warnings`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:169:15
|
|
|
|
|
169 | for _v in vec.iter_mut() {}
|
|
| ^^^^^^^^^^^^^^ help: to write this more concisely, try: `&mut vec`
|
|
|
|
error: it is more concise to loop over containers instead of using explicit iteration methods`
|
|
--> $DIR/for_loop.rs:172:15
|
|
|
|
|
172 | for _v in out_vec.into_iter() {}
|
|
| ^^^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `out_vec`
|
|
|
|
|
= note: `-D clippy::explicit-into-iter-loop` implied by `-D warnings`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:175:15
|
|
|
|
|
175 | for _v in array.into_iter() {}
|
|
| ^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&array`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:180:15
|
|
|
|
|
180 | for _v in [1, 2, 3].iter() {}
|
|
| ^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&[1, 2, 3]`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:184:15
|
|
|
|
|
184 | for _v in [0; 32].iter() {}
|
|
| ^^^^^^^^^^^^^^ help: to write this more concisely, try: `&[0; 32]`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:189:15
|
|
|
|
|
189 | for _v in ll.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&ll`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:192:15
|
|
|
|
|
192 | for _v in vd.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&vd`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:195:15
|
|
|
|
|
195 | for _v in bh.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&bh`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:198:15
|
|
|
|
|
198 | for _v in hm.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&hm`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:201:15
|
|
|
|
|
201 | for _v in bt.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&bt`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:204:15
|
|
|
|
|
204 | for _v in hs.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&hs`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:207:15
|
|
|
|
|
207 | for _v in bs.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&bs`
|
|
|
|
error: you are iterating over `Iterator::next()` which is an Option; this will compile but is probably not what you want
|
|
--> $DIR/for_loop.rs:209:15
|
|
|
|
|
209 | for _v in vec.iter().next() {}
|
|
| ^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::iter-next-loop` implied by `-D warnings`
|
|
|
|
error: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator
|
|
--> $DIR/for_loop.rs:216:5
|
|
|
|
|
216 | vec.iter().cloned().map(|x| out.push(x)).collect::<Vec<_>>();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::unused-collect` implied by `-D warnings`
|
|
|
|
error: you seem to want to iterate on a map's values
|
|
--> $DIR/for_loop.rs:325:19
|
|
|
|
|
325 | for (_, v) in &m {
|
|
| ^^
|
|
|
|
|
= note: `-D clippy::for-kv-map` implied by `-D warnings`
|
|
help: use the corresponding method
|
|
|
|
|
325 | for v in m.values() {
|
|
| ^ ^^^^^^^^^^
|
|
|
|
error: you seem to want to iterate on a map's values
|
|
--> $DIR/for_loop.rs:330:19
|
|
|
|
|
330 | for (_, v) in &*m {
|
|
| ^^^
|
|
help: use the corresponding method
|
|
|
|
|
330 | for v in (*m).values() {
|
|
| ^ ^^^^^^^^^^^^^
|
|
|
|
error: you seem to want to iterate on a map's values
|
|
--> $DIR/for_loop.rs:338:19
|
|
|
|
|
338 | for (_, v) in &mut m {
|
|
| ^^^^^^
|
|
help: use the corresponding method
|
|
|
|
|
338 | for v in m.values_mut() {
|
|
| ^ ^^^^^^^^^^^^^^
|
|
|
|
error: you seem to want to iterate on a map's values
|
|
--> $DIR/for_loop.rs:343:19
|
|
|
|
|
343 | for (_, v) in &mut *m {
|
|
| ^^^^^^^
|
|
help: use the corresponding method
|
|
|
|
|
343 | for v in (*m).values_mut() {
|
|
| ^ ^^^^^^^^^^^^^^^^^
|
|
|
|
error: you seem to want to iterate on a map's keys
|
|
--> $DIR/for_loop.rs:349:24
|
|
|
|
|
349 | for (k, _value) in rm {
|
|
| ^^
|
|
help: use the corresponding method
|
|
|
|
|
349 | for k in rm.keys() {
|
|
| ^ ^^^^^^^^^
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:402:14
|
|
|
|
|
402 | for i in 0..src.len() {
|
|
| ^^^^^^^^^^^^ help: try replacing the loop by: `dst[..src.len()].clone_from_slice(&src[..])`
|
|
|
|
|
= note: `-D clippy::manual-memcpy` implied by `-D warnings`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:407:14
|
|
|
|
|
407 | for i in 0..src.len() {
|
|
| ^^^^^^^^^^^^ help: try replacing the loop by: `dst[10..(src.len() + 10)].clone_from_slice(&src[..])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:412:14
|
|
|
|
|
412 | for i in 0..src.len() {
|
|
| ^^^^^^^^^^^^ help: try replacing the loop by: `dst[..src.len()].clone_from_slice(&src[10..])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:417:14
|
|
|
|
|
417 | for i in 11..src.len() {
|
|
| ^^^^^^^^^^^^^ help: try replacing the loop by: `dst[11..src.len()].clone_from_slice(&src[(11 - 10)..(src.len() - 10)])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:422:14
|
|
|
|
|
422 | for i in 0..dst.len() {
|
|
| ^^^^^^^^^^^^ help: try replacing the loop by: `dst.clone_from_slice(&src[..dst.len()])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:435:14
|
|
|
|
|
435 | for i in 10..256 {
|
|
| ^^^^^^^
|
|
help: try replacing the loop by
|
|
|
|
|
435 | for i in dst[10..256].clone_from_slice(&src[(10 - 5)..(256 - 5)])
|
|
436 | dst2[(10 + 500)..(256 + 500)].clone_from_slice(&src[10..256]) {
|
|
|
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:447:14
|
|
|
|
|
447 | for i in 10..LOOP_OFFSET {
|
|
| ^^^^^^^^^^^^^^^ help: try replacing the loop by: `dst[(10 + LOOP_OFFSET)..(LOOP_OFFSET + LOOP_OFFSET)].clone_from_slice(&src[(10 - some_var)..(LOOP_OFFSET - some_var)])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:460:14
|
|
|
|
|
460 | for i in 0..src_vec.len() {
|
|
| ^^^^^^^^^^^^^^^^ help: try replacing the loop by: `dst_vec[..src_vec.len()].clone_from_slice(&src_vec[..])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:489:14
|
|
|
|
|
489 | for i in from..from + src.len() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `dst[from..from + src.len()].clone_from_slice(&src[0..(from + src.len() - from)])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:493:14
|
|
|
|
|
493 | for i in from..from + 3 {
|
|
| ^^^^^^^^^^^^^^ help: try replacing the loop by: `dst[from..from + 3].clone_from_slice(&src[0..(from + 3 - from)])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:500:14
|
|
|
|
|
500 | for i in 0..src.len() {
|
|
| ^^^^^^^^^^^^ help: try replacing the loop by: `dst[..src.len()].clone_from_slice(&src[..])`
|
|
|
|
error: aborting due to 51 previous errors
|
|
|