mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-30 06:53:27 +00:00
54 lines
1.8 KiB
Text
54 lines
1.8 KiB
Text
error: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
|
|
--> $DIR/block_in_if_condition.rs:40:8
|
|
|
|
|
40 | if {
|
|
| ________^
|
|
41 | | let x = 3;
|
|
42 | | x == 3
|
|
43 | | } {
|
|
| |_____^
|
|
|
|
|
= note: `-D clippy::block-in-if-condition-stmt` implied by `-D warnings`
|
|
= help: try
|
|
let res = {
|
|
let x = 3;
|
|
x == 3
|
|
};
|
|
if res {
|
|
6
|
|
} ...
|
|
|
|
error: omit braces around single expression condition
|
|
--> $DIR/block_in_if_condition.rs:51:8
|
|
|
|
|
51 | if { true } {
|
|
| ^^^^^^^^
|
|
|
|
|
= note: `-D clippy::block-in-if-condition-expr` implied by `-D warnings`
|
|
= help: try
|
|
if true {
|
|
6
|
|
} ...
|
|
|
|
error: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
|
|
--> $DIR/block_in_if_condition.rs:68:49
|
|
|
|
|
68 | if v == 3 && sky == "blue" && predicate(|x| { let target = 3; x == target }, v) {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
|
|
--> $DIR/block_in_if_condition.rs:71:22
|
|
|
|
|
71 | if predicate(|x| { let target = 3; x == target }, v) {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/block_in_if_condition.rs:77:8
|
|
|
|
|
77 | if true && x == 3 {
|
|
| ^^^^^^^^^^^^^^ help: try: `x == 3`
|
|
|
|
|
= note: `-D clippy::nonminimal-bool` implied by `-D warnings`
|
|
|
|
error: aborting due to 5 previous errors
|
|
|