mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-10 23:24:24 +00:00
73 lines
2 KiB
Text
73 lines
2 KiB
Text
error: manual implementation of `Option::map`
|
|
--> $DIR/manual_map_option_2.rs:8:13
|
|
|
|
|
LL | let _ = match Some(0) {
|
|
| _____________^
|
|
LL | | Some(x) => Some({
|
|
LL | | let y = (String::new(), String::new());
|
|
LL | | (x, y.0)
|
|
LL | | }),
|
|
LL | | None => None,
|
|
LL | | };
|
|
| |_____^
|
|
|
|
|
= note: `-D clippy::manual-map` implied by `-D warnings`
|
|
help: try this
|
|
|
|
|
LL ~ let _ = Some(0).map(|x| {
|
|
LL + let y = (String::new(), String::new());
|
|
LL + (x, y.0)
|
|
LL ~ });
|
|
|
|
|
|
|
error: manual implementation of `Option::map`
|
|
--> $DIR/manual_map_option_2.rs:50:13
|
|
|
|
|
LL | let _ = match &s {
|
|
| _____________^
|
|
LL | | Some(x) => Some({
|
|
LL | | if let Some(ref s) = s { (x.clone(), s) } else { panic!() }
|
|
LL | | }),
|
|
LL | | None => None,
|
|
LL | | };
|
|
| |_____^
|
|
|
|
|
help: try this
|
|
|
|
|
LL ~ let _ = s.as_ref().map(|x| {
|
|
LL + if let Some(ref s) = s { (x.clone(), s) } else { panic!() }
|
|
LL ~ });
|
|
|
|
|
|
|
error: manual implementation of `Option::map`
|
|
--> $DIR/manual_map_option_2.rs:62:17
|
|
|
|
|
LL | let _ = match Some(0) {
|
|
| _________________^
|
|
LL | | Some(x) => Some(f(x)),
|
|
LL | | None => None,
|
|
LL | | };
|
|
| |_________^ help: try this: `Some(0).map(|x| f(x))`
|
|
|
|
error: manual implementation of `Option::map`
|
|
--> $DIR/manual_map_option_2.rs:67:13
|
|
|
|
|
LL | let _ = match Some(0) {
|
|
| _____________^
|
|
LL | | Some(x) => unsafe { Some(f(x)) },
|
|
LL | | None => None,
|
|
LL | | };
|
|
| |_____^ help: try this: `Some(0).map(|x| unsafe { f(x) })`
|
|
|
|
error: manual implementation of `Option::map`
|
|
--> $DIR/manual_map_option_2.rs:71:13
|
|
|
|
|
LL | let _ = match Some(0) {
|
|
| _____________^
|
|
LL | | Some(x) => Some(unsafe { f(x) }),
|
|
LL | | None => None,
|
|
LL | | };
|
|
| |_____^ help: try this: `Some(0).map(|x| unsafe { f(x) })`
|
|
|
|
error: aborting due to 5 previous errors
|
|
|