mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-14 00:47:16 +00:00
110 lines
4.2 KiB
Text
110 lines
4.2 KiB
Text
error: redundant closure
|
|
--> $DIR/eta.rs:32:27
|
|
|
|
|
LL | let a = Some(1u8).map(|a| foo(a));
|
|
| ^^^^^^^^^^ help: replace the closure with the function itself: `foo`
|
|
|
|
|
= note: `-D clippy::redundant-closure` implied by `-D warnings`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:33:10
|
|
|
|
|
LL | meta(|a| foo(a));
|
|
| ^^^^^^^^^^ help: replace the closure with the function itself: `foo`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:37:40
|
|
|
|
|
LL | let _: Option<Vec<u8>> = true.then(|| vec![]); // special case vec!
|
|
| ^^^^^^^^^ help: replace the closure with `Vec::new`: `std::vec::Vec::new`
|
|
|
|
error: this expression borrows a reference (`&u8`) that is immediately dereferenced by the compiler
|
|
--> $DIR/eta.rs:39:21
|
|
|
|
|
LL | all(&[1, 2, 3], &&2, |x, y| below(x, y)); //is adjusted
|
|
| ^^^ help: change this to: `&2`
|
|
|
|
|
= note: `-D clippy::needless-borrow` implied by `-D warnings`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:46:27
|
|
|
|
|
LL | let e = Some(1u8).map(|a| generic(a));
|
|
| ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `generic`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:92:51
|
|
|
|
|
LL | let e = Some(TestStruct { some_ref: &i }).map(|a| a.foo());
|
|
| ^^^^^^^^^^^ help: replace the closure with the method itself: `TestStruct::foo`
|
|
|
|
|
= note: `-D clippy::redundant-closure-for-method-calls` implied by `-D warnings`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:94:51
|
|
|
|
|
LL | let e = Some(TestStruct { some_ref: &i }).map(|a| a.trait_foo());
|
|
| ^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `TestTrait::trait_foo`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:97:42
|
|
|
|
|
LL | let e = Some(&mut vec![1, 2, 3]).map(|v| v.clear());
|
|
| ^^^^^^^^^^^^^ help: replace the closure with the method itself: `std::vec::Vec::clear`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:102:29
|
|
|
|
|
LL | let e = Some("str").map(|s| s.to_string());
|
|
| ^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `std::string::ToString::to_string`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:104:27
|
|
|
|
|
LL | let e = Some('a').map(|s| s.to_uppercase());
|
|
| ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `char::to_uppercase`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:107:65
|
|
|
|
|
LL | let e: std::vec::Vec<char> = vec!['a', 'b', 'c'].iter().map(|c| c.to_ascii_uppercase()).collect();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `char::to_ascii_uppercase`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:190:27
|
|
|
|
|
LL | let a = Some(1u8).map(|a| foo_ptr(a));
|
|
| ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `foo_ptr`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:195:27
|
|
|
|
|
LL | let a = Some(1u8).map(|a| closure(a));
|
|
| ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `closure`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:227:28
|
|
|
|
|
LL | x.into_iter().for_each(|x| add_to_res(x));
|
|
| ^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `&mut add_to_res`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:228:28
|
|
|
|
|
LL | y.into_iter().for_each(|x| add_to_res(x));
|
|
| ^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `&mut add_to_res`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:229:28
|
|
|
|
|
LL | z.into_iter().for_each(|x| add_to_res(x));
|
|
| ^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `add_to_res`
|
|
|
|
error: redundant closure
|
|
--> $DIR/eta.rs:236:21
|
|
|
|
|
LL | Some(1).map(|n| closure(n));
|
|
| ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `&mut closure`
|
|
|
|
error: aborting due to 17 previous errors
|
|
|