mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-10 15:14:29 +00:00
80 lines
2.5 KiB
Rust
80 lines
2.5 KiB
Rust
#![allow(dead_code)]
|
|
|
|
fn is_any(acc: bool, x: usize) -> bool {
|
|
acc || x > 2
|
|
}
|
|
|
|
/// Calls which should trigger the `UNNECESSARY_FOLD` lint
|
|
fn unnecessary_fold() {
|
|
// Can be replaced by .any
|
|
let _ = (0..3).any(|x| x > 2);
|
|
// Can be replaced by .any (checking suggestion)
|
|
let _ = (0..3).fold(false, is_any);
|
|
// Can be replaced by .all
|
|
let _ = (0..3).all(|x| x > 2);
|
|
// Can be replaced by .sum
|
|
let _: i32 = (0..3).sum();
|
|
// Can be replaced by .product
|
|
let _: i32 = (0..3).product();
|
|
}
|
|
|
|
/// Should trigger the `UNNECESSARY_FOLD` lint, with an error span including exactly `.fold(...)`
|
|
fn unnecessary_fold_span_for_multi_element_chain() {
|
|
let _: bool = (0..3).map(|x| 2 * x).any(|x| x > 2);
|
|
}
|
|
|
|
/// Calls which should not trigger the `UNNECESSARY_FOLD` lint
|
|
fn unnecessary_fold_should_ignore() {
|
|
let _ = (0..3).fold(true, |acc, x| acc || x > 2);
|
|
let _ = (0..3).fold(false, |acc, x| acc && x > 2);
|
|
let _ = (0..3).fold(1, |acc, x| acc + x);
|
|
let _ = (0..3).fold(0, |acc, x| acc * x);
|
|
let _ = (0..3).fold(0, |acc, x| 1 + acc + x);
|
|
|
|
// We only match against an accumulator on the left
|
|
// hand side. We could lint for .sum and .product when
|
|
// it's on the right, but don't for now (and this wouldn't
|
|
// be valid if we extended the lint to cover arbitrary numeric
|
|
// types).
|
|
let _ = (0..3).fold(false, |acc, x| x > 2 || acc);
|
|
let _ = (0..3).fold(true, |acc, x| x > 2 && acc);
|
|
let _ = (0..3).fold(0, |acc, x| x + acc);
|
|
let _ = (0..3).fold(1, |acc, x| x * acc);
|
|
|
|
let _ = [(0..2), (0..3)].iter().fold(0, |a, b| a + b.len());
|
|
let _ = [(0..2), (0..3)].iter().fold(1, |a, b| a * b.len());
|
|
}
|
|
|
|
/// Should lint only the line containing the fold
|
|
fn unnecessary_fold_over_multiple_lines() {
|
|
let _ = (0..3)
|
|
.map(|x| x + 1)
|
|
.filter(|x| x % 2 == 0)
|
|
.any(|x| x > 2);
|
|
}
|
|
|
|
fn issue10000() {
|
|
use std::collections::HashMap;
|
|
use std::hash::BuildHasher;
|
|
|
|
fn anything<T>(_: T) {}
|
|
fn num(_: i32) {}
|
|
fn smoketest_map<S: BuildHasher>(mut map: HashMap<i32, i32, S>) {
|
|
map.insert(0, 0);
|
|
assert_eq!(map.values().sum::<i32>(), 0);
|
|
|
|
// more cases:
|
|
let _ = map.values().sum::<i32>();
|
|
let _ = map.values().product::<i32>();
|
|
let _: i32 = map.values().sum();
|
|
let _: i32 = map.values().product();
|
|
anything(map.values().sum::<i32>());
|
|
anything(map.values().product::<i32>());
|
|
num(map.values().sum());
|
|
num(map.values().product());
|
|
}
|
|
|
|
smoketest_map(HashMap::new());
|
|
}
|
|
|
|
fn main() {}
|