mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-09-21 07:01:54 +00:00
a6d8afd958
Fixes #9431. The current `range_plus_one` and `range_minus_one` suggestions are completely incorrect when macros are involved. This commit resolves this by disabling the lints for any range expression that is expanded from a macro. The reasons for this are that it is very difficult to create a correct suggestion in this case and that false negatives are less important for pedantic lints.
61 lines
1 KiB
Rust
61 lines
1 KiB
Rust
// run-rustfix
|
|
|
|
#![allow(unused_parens)]
|
|
#![allow(clippy::iter_with_drain)]
|
|
fn f() -> usize {
|
|
42
|
|
}
|
|
|
|
macro_rules! macro_plus_one {
|
|
($m: literal) => {
|
|
for i in 0..$m + 1 {
|
|
println!("{}", i);
|
|
}
|
|
};
|
|
}
|
|
|
|
macro_rules! macro_minus_one {
|
|
($m: literal) => {
|
|
for i in 0..=$m - 1 {
|
|
println!("{}", i);
|
|
}
|
|
};
|
|
}
|
|
|
|
#[warn(clippy::range_plus_one)]
|
|
#[warn(clippy::range_minus_one)]
|
|
fn main() {
|
|
for _ in 0..2 {}
|
|
for _ in 0..=2 {}
|
|
|
|
for _ in 0..=3 {}
|
|
for _ in 0..=3 + 1 {}
|
|
|
|
for _ in 0..=5 {}
|
|
for _ in 0..=1 + 5 {}
|
|
|
|
for _ in 1..=1 {}
|
|
for _ in 1..=1 + 1 {}
|
|
|
|
for _ in 0..13 + 13 {}
|
|
for _ in 0..=13 - 7 {}
|
|
|
|
for _ in 0..=f() {}
|
|
for _ in 0..=(1 + f()) {}
|
|
|
|
let _ = ..11 - 1;
|
|
let _ = ..11;
|
|
let _ = ..11;
|
|
let _ = (1..=11);
|
|
let _ = ((f() + 1)..=f());
|
|
|
|
const ONE: usize = 1;
|
|
// integer consts are linted, too
|
|
for _ in 1..=ONE {}
|
|
|
|
let mut vec: Vec<()> = std::vec::Vec::new();
|
|
vec.drain(..);
|
|
|
|
macro_plus_one!(5);
|
|
macro_minus_one!(5);
|
|
}
|