mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-14 07:12:51 +00:00
3d41358a55
The `wrong_self_convention` lint uses a `SelfKind` type to decide
whether a method has the right kind of "self" for its name, or whether
the kind of "self" it has makes its name confusable for a method in
a common trait. One possibility is `SelfKind::No`, which is supposed
to mean "No `self`".
Previously, SelfKind::No matched everything _except_ Self, including
references to Self. This patch changes it to match Self, &Self, &mut
Self, Box<Self>, and so on.
For example, this kind of method was allowed before:
```
impl S {
// Should trigger the lint, because
// "methods called `is_*` usually take `self` by reference or no `self`"
fn is_foo(&mut self) -> bool { todo!() }
}
```
But since SelfKind::No matched "&mut self", no lint was triggered
(see #8142).
With this patch, the code above now gives a lint as expected.
Fixes #8142
changelog: [`wrong_self_convention`] rejects `self` references in more cases
203 lines
6.1 KiB
Text
203 lines
6.1 KiB
Text
error: methods called `from_*` usually take no `self`
|
|
--> $DIR/wrong_self_convention.rs:16:17
|
|
|
|
|
LL | fn from_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= note: `-D clippy::wrong-self-convention` implied by `-D warnings`
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `from_*` usually take no `self`
|
|
--> $DIR/wrong_self_convention.rs:22:21
|
|
|
|
|
LL | pub fn from_i64(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `as_*` usually take `self` by reference or `self` by mutable reference
|
|
--> $DIR/wrong_self_convention.rs:34:15
|
|
|
|
|
LL | fn as_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `into_*` usually take `self` by value
|
|
--> $DIR/wrong_self_convention.rs:36:17
|
|
|
|
|
LL | fn into_i32(&self) {}
|
|
| ^^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `is_*` usually take `self` by reference or no `self`
|
|
--> $DIR/wrong_self_convention.rs:38:15
|
|
|
|
|
LL | fn is_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
|
|
--> $DIR/wrong_self_convention.rs:40:15
|
|
|
|
|
LL | fn to_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `from_*` usually take no `self`
|
|
--> $DIR/wrong_self_convention.rs:42:17
|
|
|
|
|
LL | fn from_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `as_*` usually take `self` by reference or `self` by mutable reference
|
|
--> $DIR/wrong_self_convention.rs:44:19
|
|
|
|
|
LL | pub fn as_i64(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `into_*` usually take `self` by value
|
|
--> $DIR/wrong_self_convention.rs:45:21
|
|
|
|
|
LL | pub fn into_i64(&self) {}
|
|
| ^^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `is_*` usually take `self` by reference or no `self`
|
|
--> $DIR/wrong_self_convention.rs:46:19
|
|
|
|
|
LL | pub fn is_i64(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
|
|
--> $DIR/wrong_self_convention.rs:47:19
|
|
|
|
|
LL | pub fn to_i64(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `from_*` usually take no `self`
|
|
--> $DIR/wrong_self_convention.rs:48:21
|
|
|
|
|
LL | pub fn from_i64(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `as_*` usually take `self` by reference or `self` by mutable reference
|
|
--> $DIR/wrong_self_convention.rs:93:19
|
|
|
|
|
LL | fn as_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `into_*` usually take `self` by value
|
|
--> $DIR/wrong_self_convention.rs:96:25
|
|
|
|
|
LL | fn into_i32_ref(&self) {}
|
|
| ^^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `is_*` usually take `self` by reference or no `self`
|
|
--> $DIR/wrong_self_convention.rs:98:19
|
|
|
|
|
LL | fn is_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `from_*` usually take no `self`
|
|
--> $DIR/wrong_self_convention.rs:102:21
|
|
|
|
|
LL | fn from_i32(self) {}
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `as_*` usually take `self` by reference or `self` by mutable reference
|
|
--> $DIR/wrong_self_convention.rs:117:19
|
|
|
|
|
LL | fn as_i32(self);
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `into_*` usually take `self` by value
|
|
--> $DIR/wrong_self_convention.rs:120:25
|
|
|
|
|
LL | fn into_i32_ref(&self);
|
|
| ^^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `is_*` usually take `self` by reference or no `self`
|
|
--> $DIR/wrong_self_convention.rs:122:19
|
|
|
|
|
LL | fn is_i32(self);
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `from_*` usually take no `self`
|
|
--> $DIR/wrong_self_convention.rs:126:21
|
|
|
|
|
LL | fn from_i32(self);
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `into_*` usually take `self` by value
|
|
--> $DIR/wrong_self_convention.rs:144:25
|
|
|
|
|
LL | fn into_i32_ref(&self);
|
|
| ^^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `from_*` usually take no `self`
|
|
--> $DIR/wrong_self_convention.rs:150:21
|
|
|
|
|
LL | fn from_i32(self);
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
|
|
--> $DIR/wrong_self_convention.rs:174:22
|
|
|
|
|
LL | fn to_u64_v2(&self) -> u64 {
|
|
| ^^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
|
|
--> $DIR/wrong_self_convention.rs:183:19
|
|
|
|
|
LL | fn to_u64(self) -> u64 {
|
|
| ^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: methods called `is_*` usually take `self` by reference or no `self`
|
|
--> $DIR/wrong_self_convention.rs:197:27
|
|
|
|
|
LL | fn is_still_buggy(&mut self) -> bool {
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider choosing a less ambiguous name
|
|
|
|
error: aborting due to 25 previous errors
|
|
|