rust-clippy/tests/ui/floating_point_mul_add.fixed
Lukas Lueg a2e396badf Don't suggest a.mul_add(b, c) if parameters are not float
clippy::suboptimal_flops used to not check if the second parameter to f32/f64.mul_add() was float. Since the method is
only defined to take `Self` as paremters, the suggestion was wrong.

Fixes #11831
2023-11-18 13:50:18 +01:00

59 lines
1.3 KiB
Rust

#![feature(const_fn_floating_point_arithmetic)]
#![warn(clippy::suboptimal_flops)]
/// Allow suboptimal_ops in constant context
pub const fn in_const_context() {
let a: f64 = 1234.567;
let b: f64 = 45.67834;
let c: f64 = 0.0004;
let _ = a * b + c;
let _ = c + a * b;
}
fn main() {
let a: f64 = 1234.567;
let b: f64 = 45.67834;
let c: f64 = 0.0004;
let d: f64 = 0.0001;
let _ = a.mul_add(b, c);
let _ = a.mul_add(b, -c);
let _ = a.mul_add(b, c);
let _ = a.mul_add(-b, c);
let _ = 2.0f64.mul_add(4.0, a);
let _ = 2.0f64.mul_add(4., a);
let _ = a.mul_add(b, c);
let _ = a.mul_add(b, c);
let _ = (a * b).mul_add(c, d);
let _ = a.mul_add(b, c).mul_add(a.mul_add(b, c), a.mul_add(b, c)) + c;
let _ = 1234.567_f64.mul_add(45.67834_f64, 0.0004_f64);
let _ = a.mul_add(a, b).sqrt();
let u = 1usize;
let _ = b.mul_add(-(u as f64), a);
// Cases where the lint shouldn't be applied
let _ = (a * a + b * b).sqrt();
}
fn _issue11831() {
struct NotAFloat;
impl std::ops::Add<f64> for NotAFloat {
type Output = Self;
fn add(self, _: f64) -> Self {
NotAFloat
}
}
let a = NotAFloat;
let b = 1.0_f64;
let c = 1.0;
let _ = a + b * c;
}