mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-21 10:33:27 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
57 lines
1.9 KiB
Rust
57 lines
1.9 KiB
Rust
use clippy_utils::{diagnostics::span_lint, is_lint_allowed};
|
|
use rustc_hir::hir_id::CRATE_HIR_ID;
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use rustc_span::source_map::DUMMY_SP;
|
|
|
|
use if_chain::if_chain;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for wildcard dependencies in the `Cargo.toml`.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// [As the edition guide says](https://rust-lang-nursery.github.io/edition-guide/rust-2018/cargo-and-crates-io/crates-io-disallows-wildcard-dependencies.html),
|
|
/// it is highly unlikely that you work with any possible version of your dependency,
|
|
/// and wildcard dependencies would cause unnecessary breakage in the ecosystem.
|
|
///
|
|
/// ### Example
|
|
/// ```toml
|
|
/// [dependencies]
|
|
/// regex = "*"
|
|
/// ```
|
|
#[clippy::version = "1.32.0"]
|
|
pub WILDCARD_DEPENDENCIES,
|
|
cargo,
|
|
"wildcard dependencies being used"
|
|
}
|
|
|
|
declare_lint_pass!(WildcardDependencies => [WILDCARD_DEPENDENCIES]);
|
|
|
|
impl LateLintPass<'_> for WildcardDependencies {
|
|
fn check_crate(&mut self, cx: &LateContext<'_>) {
|
|
if is_lint_allowed(cx, WILDCARD_DEPENDENCIES, CRATE_HIR_ID) {
|
|
return;
|
|
}
|
|
|
|
let metadata = unwrap_cargo_metadata!(cx, WILDCARD_DEPENDENCIES, false);
|
|
|
|
for dep in &metadata.packages[0].dependencies {
|
|
// VersionReq::any() does not work
|
|
if_chain! {
|
|
if let Ok(wildcard_ver) = semver::VersionReq::parse("*");
|
|
if let Some(ref source) = dep.source;
|
|
if !source.starts_with("git");
|
|
if dep.req == wildcard_ver;
|
|
then {
|
|
span_lint(
|
|
cx,
|
|
WILDCARD_DEPENDENCIES,
|
|
DUMMY_SP,
|
|
&format!("wildcard dependency for `{}`", dep.name),
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|