mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-21 10:33:27 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
79 lines
2.4 KiB
Rust
79 lines
2.4 KiB
Rust
use clippy_utils::diagnostics::span_lint;
|
|
use rustc_ast::ast::{Item, ItemKind, UseTree, UseTreeKind};
|
|
use rustc_lint::{EarlyContext, EarlyLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use rustc_span::source_map::Span;
|
|
use rustc_span::symbol::Ident;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for imports that remove "unsafe" from an item's
|
|
/// name.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Renaming makes it less clear which traits and
|
|
/// structures are unsafe.
|
|
///
|
|
/// ### Example
|
|
/// ```rust,ignore
|
|
/// use std::cell::{UnsafeCell as TotallySafeCell};
|
|
///
|
|
/// extern crate crossbeam;
|
|
/// use crossbeam::{spawn_unsafe as spawn};
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub UNSAFE_REMOVED_FROM_NAME,
|
|
style,
|
|
"`unsafe` removed from API names on import"
|
|
}
|
|
|
|
declare_lint_pass!(UnsafeNameRemoval => [UNSAFE_REMOVED_FROM_NAME]);
|
|
|
|
impl EarlyLintPass for UnsafeNameRemoval {
|
|
fn check_item(&mut self, cx: &EarlyContext<'_>, item: &Item) {
|
|
if let ItemKind::Use(ref use_tree) = item.kind {
|
|
check_use_tree(use_tree, cx, item.span);
|
|
}
|
|
}
|
|
}
|
|
|
|
fn check_use_tree(use_tree: &UseTree, cx: &EarlyContext<'_>, span: Span) {
|
|
match use_tree.kind {
|
|
UseTreeKind::Simple(Some(new_name), ..) => {
|
|
let old_name = use_tree
|
|
.prefix
|
|
.segments
|
|
.last()
|
|
.expect("use paths cannot be empty")
|
|
.ident;
|
|
unsafe_to_safe_check(old_name, new_name, cx, span);
|
|
},
|
|
UseTreeKind::Simple(None, ..) | UseTreeKind::Glob => {},
|
|
UseTreeKind::Nested(ref nested_use_tree) => {
|
|
for &(ref use_tree, _) in nested_use_tree {
|
|
check_use_tree(use_tree, cx, span);
|
|
}
|
|
},
|
|
}
|
|
}
|
|
|
|
fn unsafe_to_safe_check(old_name: Ident, new_name: Ident, cx: &EarlyContext<'_>, span: Span) {
|
|
let old_str = old_name.name.as_str();
|
|
let new_str = new_name.name.as_str();
|
|
if contains_unsafe(&old_str) && !contains_unsafe(&new_str) {
|
|
span_lint(
|
|
cx,
|
|
UNSAFE_REMOVED_FROM_NAME,
|
|
span,
|
|
&format!(
|
|
"removed `unsafe` from the name of `{}` in use as `{}`",
|
|
old_str, new_str
|
|
),
|
|
);
|
|
}
|
|
}
|
|
|
|
#[must_use]
|
|
fn contains_unsafe(name: &str) -> bool {
|
|
name.contains("Unsafe") || name.contains("unsafe")
|
|
}
|