mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-21 10:33:27 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
97 lines
3.3 KiB
Rust
97 lines
3.3 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_sugg;
|
|
use clippy_utils::source::snippet_opt;
|
|
use if_chain::if_chain;
|
|
use rustc_errors::Applicability;
|
|
use rustc_hir::{BinOpKind, Expr, ExprKind};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Use `std::ptr::eq` when applicable
|
|
///
|
|
/// ### Why is this bad?
|
|
/// `ptr::eq` can be used to compare `&T` references
|
|
/// (which coerce to `*const T` implicitly) by their address rather than
|
|
/// comparing the values they point to.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// let a = &[1, 2, 3];
|
|
/// let b = &[1, 2, 3];
|
|
///
|
|
/// assert!(a as *const _ as usize == b as *const _ as usize);
|
|
/// ```
|
|
/// Use instead:
|
|
/// ```rust
|
|
/// let a = &[1, 2, 3];
|
|
/// let b = &[1, 2, 3];
|
|
///
|
|
/// assert!(std::ptr::eq(a, b));
|
|
/// ```
|
|
#[clippy::version = "1.49.0"]
|
|
pub PTR_EQ,
|
|
style,
|
|
"use `std::ptr::eq` when comparing raw pointers"
|
|
}
|
|
|
|
declare_lint_pass!(PtrEq => [PTR_EQ]);
|
|
|
|
static LINT_MSG: &str = "use `std::ptr::eq` when comparing raw pointers";
|
|
|
|
impl LateLintPass<'_> for PtrEq {
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
|
|
if expr.span.from_expansion() {
|
|
return;
|
|
}
|
|
|
|
if let ExprKind::Binary(ref op, left, right) = expr.kind {
|
|
if BinOpKind::Eq == op.node {
|
|
let (left, right) = match (expr_as_cast_to_usize(cx, left), expr_as_cast_to_usize(cx, right)) {
|
|
(Some(lhs), Some(rhs)) => (lhs, rhs),
|
|
_ => (left, right),
|
|
};
|
|
|
|
if_chain! {
|
|
if let Some(left_var) = expr_as_cast_to_raw_pointer(cx, left);
|
|
if let Some(right_var) = expr_as_cast_to_raw_pointer(cx, right);
|
|
if let Some(left_snip) = snippet_opt(cx, left_var.span);
|
|
if let Some(right_snip) = snippet_opt(cx, right_var.span);
|
|
then {
|
|
span_lint_and_sugg(
|
|
cx,
|
|
PTR_EQ,
|
|
expr.span,
|
|
LINT_MSG,
|
|
"try",
|
|
format!("std::ptr::eq({}, {})", left_snip, right_snip),
|
|
Applicability::MachineApplicable,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// If the given expression is a cast to a usize, return the lhs of the cast
|
|
// E.g., `foo as *const _ as usize` returns `foo as *const _`.
|
|
fn expr_as_cast_to_usize<'tcx>(cx: &LateContext<'tcx>, cast_expr: &'tcx Expr<'_>) -> Option<&'tcx Expr<'tcx>> {
|
|
if cx.typeck_results().expr_ty(cast_expr) == cx.tcx.types.usize {
|
|
if let ExprKind::Cast(expr, _) = cast_expr.kind {
|
|
return Some(expr);
|
|
}
|
|
}
|
|
None
|
|
}
|
|
|
|
// If the given expression is a cast to a `*const` pointer, return the lhs of the cast
|
|
// E.g., `foo as *const _` returns `foo`.
|
|
fn expr_as_cast_to_raw_pointer<'tcx>(cx: &LateContext<'tcx>, cast_expr: &'tcx Expr<'_>) -> Option<&'tcx Expr<'tcx>> {
|
|
if cx.typeck_results().expr_ty(cast_expr).is_unsafe_ptr() {
|
|
if let ExprKind::Cast(expr, _) = cast_expr.kind {
|
|
return Some(expr);
|
|
}
|
|
}
|
|
None
|
|
}
|