mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-21 10:33:27 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
114 lines
3.3 KiB
Rust
114 lines
3.3 KiB
Rust
use clippy_utils::diagnostics::span_lint;
|
|
use clippy_utils::{is_expn_of, match_panic_call};
|
|
use if_chain::if_chain;
|
|
use rustc_hir::Expr;
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use rustc_span::Span;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for usage of `panic!`.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// `panic!` will stop the execution of the executable
|
|
///
|
|
/// ### Example
|
|
/// ```no_run
|
|
/// panic!("even with a good reason");
|
|
/// ```
|
|
#[clippy::version = "1.40.0"]
|
|
pub PANIC,
|
|
restriction,
|
|
"usage of the `panic!` macro"
|
|
}
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for usage of `unimplemented!`.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// This macro should not be present in production code
|
|
///
|
|
/// ### Example
|
|
/// ```no_run
|
|
/// unimplemented!();
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub UNIMPLEMENTED,
|
|
restriction,
|
|
"`unimplemented!` should not be present in production code"
|
|
}
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for usage of `todo!`.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// This macro should not be present in production code
|
|
///
|
|
/// ### Example
|
|
/// ```no_run
|
|
/// todo!();
|
|
/// ```
|
|
#[clippy::version = "1.40.0"]
|
|
pub TODO,
|
|
restriction,
|
|
"`todo!` should not be present in production code"
|
|
}
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for usage of `unreachable!`.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// This macro can cause code to panic
|
|
///
|
|
/// ### Example
|
|
/// ```no_run
|
|
/// unreachable!();
|
|
/// ```
|
|
#[clippy::version = "1.40.0"]
|
|
pub UNREACHABLE,
|
|
restriction,
|
|
"usage of the `unreachable!` macro"
|
|
}
|
|
|
|
declare_lint_pass!(PanicUnimplemented => [UNIMPLEMENTED, UNREACHABLE, TODO, PANIC]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for PanicUnimplemented {
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
|
|
if match_panic_call(cx, expr).is_some()
|
|
&& (is_expn_of(expr.span, "debug_assert").is_none() && is_expn_of(expr.span, "assert").is_none())
|
|
{
|
|
let span = get_outer_span(expr);
|
|
if is_expn_of(expr.span, "unimplemented").is_some() {
|
|
span_lint(
|
|
cx,
|
|
UNIMPLEMENTED,
|
|
span,
|
|
"`unimplemented` should not be present in production code",
|
|
);
|
|
} else if is_expn_of(expr.span, "todo").is_some() {
|
|
span_lint(cx, TODO, span, "`todo` should not be present in production code");
|
|
} else if is_expn_of(expr.span, "unreachable").is_some() {
|
|
span_lint(cx, UNREACHABLE, span, "usage of the `unreachable!` macro");
|
|
} else if is_expn_of(expr.span, "panic").is_some() {
|
|
span_lint(cx, PANIC, span, "`panic` should not be present in production code");
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
fn get_outer_span(expr: &Expr<'_>) -> Span {
|
|
if_chain! {
|
|
if expr.span.from_expansion();
|
|
let first = expr.span.ctxt().outer_expn_data().call_site;
|
|
if first.from_expansion();
|
|
then {
|
|
first.ctxt().outer_expn_data().call_site
|
|
} else {
|
|
expr.span
|
|
}
|
|
}
|
|
}
|