mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-30 06:53:27 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
75 lines
3.4 KiB
Rust
75 lines
3.4 KiB
Rust
use clippy_utils::diagnostics::span_lint;
|
|
use clippy_utils::SpanlessEq;
|
|
use if_chain::if_chain;
|
|
use rustc_hir::{BinOpKind, Expr, ExprKind, QPath};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Detects classic underflow/overflow checks.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Most classic C underflow/overflow checks will fail in
|
|
/// Rust. Users can use functions like `overflowing_*` and `wrapping_*` instead.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// # let a = 1;
|
|
/// # let b = 2;
|
|
/// a + b < a;
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub OVERFLOW_CHECK_CONDITIONAL,
|
|
complexity,
|
|
"overflow checks inspired by C which are likely to panic"
|
|
}
|
|
|
|
declare_lint_pass!(OverflowCheckConditional => [OVERFLOW_CHECK_CONDITIONAL]);
|
|
|
|
const OVERFLOW_MSG: &str = "you are trying to use classic C overflow conditions that will fail in Rust";
|
|
const UNDERFLOW_MSG: &str = "you are trying to use classic C underflow conditions that will fail in Rust";
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for OverflowCheckConditional {
|
|
// a + b < a, a > a + b, a < a - b, a - b > a
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
|
|
let eq = |l, r| SpanlessEq::new(cx).eq_path_segment(l, r);
|
|
if_chain! {
|
|
if let ExprKind::Binary(ref op, first, second) = expr.kind;
|
|
if let ExprKind::Binary(ref op2, ident1, ident2) = first.kind;
|
|
if let ExprKind::Path(QPath::Resolved(_, path1)) = ident1.kind;
|
|
if let ExprKind::Path(QPath::Resolved(_, path2)) = ident2.kind;
|
|
if let ExprKind::Path(QPath::Resolved(_, path3)) = second.kind;
|
|
if eq(&path1.segments[0], &path3.segments[0]) || eq(&path2.segments[0], &path3.segments[0]);
|
|
if cx.typeck_results().expr_ty(ident1).is_integral();
|
|
if cx.typeck_results().expr_ty(ident2).is_integral();
|
|
then {
|
|
if op.node == BinOpKind::Lt && op2.node == BinOpKind::Add {
|
|
span_lint(cx, OVERFLOW_CHECK_CONDITIONAL, expr.span, OVERFLOW_MSG);
|
|
}
|
|
if op.node == BinOpKind::Gt && op2.node == BinOpKind::Sub {
|
|
span_lint(cx, OVERFLOW_CHECK_CONDITIONAL, expr.span, UNDERFLOW_MSG);
|
|
}
|
|
}
|
|
}
|
|
|
|
if_chain! {
|
|
if let ExprKind::Binary(ref op, first, second) = expr.kind;
|
|
if let ExprKind::Binary(ref op2, ident1, ident2) = second.kind;
|
|
if let ExprKind::Path(QPath::Resolved(_, path1)) = ident1.kind;
|
|
if let ExprKind::Path(QPath::Resolved(_, path2)) = ident2.kind;
|
|
if let ExprKind::Path(QPath::Resolved(_, path3)) = first.kind;
|
|
if eq(&path1.segments[0], &path3.segments[0]) || eq(&path2.segments[0], &path3.segments[0]);
|
|
if cx.typeck_results().expr_ty(ident1).is_integral();
|
|
if cx.typeck_results().expr_ty(ident2).is_integral();
|
|
then {
|
|
if op.node == BinOpKind::Gt && op2.node == BinOpKind::Add {
|
|
span_lint(cx, OVERFLOW_CHECK_CONDITIONAL, expr.span, OVERFLOW_MSG);
|
|
}
|
|
if op.node == BinOpKind::Lt && op2.node == BinOpKind::Sub {
|
|
span_lint(cx, OVERFLOW_CHECK_CONDITIONAL, expr.span, UNDERFLOW_MSG);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|