mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-23 21:23:56 +00:00
217 lines
6 KiB
Text
217 lines
6 KiB
Text
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:18:13
|
|
|
|
|
LL | let _ = !true;
|
|
| ^^^^^ help: try: `false`
|
|
|
|
|
= note: `-D clippy::nonminimal-bool` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::nonminimal_bool)]`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:21:13
|
|
|
|
|
LL | let _ = !false;
|
|
| ^^^^^^ help: try: `true`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:23:13
|
|
|
|
|
LL | let _ = !!a;
|
|
| ^^^ help: try: `a`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:25:13
|
|
|
|
|
LL | let _ = false || a;
|
|
| ^^^^^^^^^^ help: try: `a`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:30:13
|
|
|
|
|
LL | let _ = !(!a && b);
|
|
| ^^^^^^^^^^ help: try: `a || !b`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:32:13
|
|
|
|
|
LL | let _ = !(!a || b);
|
|
| ^^^^^^^^^^ help: try: `a && !b`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:34:13
|
|
|
|
|
LL | let _ = !a && !(b && c);
|
|
| ^^^^^^^^^^^^^^^ help: try: `!(a || b && c)`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:43:13
|
|
|
|
|
LL | let _ = a == b && c == 5 && a == b;
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: try
|
|
|
|
|
LL | let _ = !(a != b || c != 5);
|
|
| ~~~~~~~~~~~~~~~~~~~
|
|
LL | let _ = a == b && c == 5;
|
|
| ~~~~~~~~~~~~~~~~
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:45:13
|
|
|
|
|
LL | let _ = a == b || c == 5 || a == b;
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: try
|
|
|
|
|
LL | let _ = !(a != b && c != 5);
|
|
| ~~~~~~~~~~~~~~~~~~~
|
|
LL | let _ = a == b || c == 5;
|
|
| ~~~~~~~~~~~~~~~~
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:47:13
|
|
|
|
|
LL | let _ = a == b && c == 5 && b == a;
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: try
|
|
|
|
|
LL | let _ = !(a != b || c != 5);
|
|
| ~~~~~~~~~~~~~~~~~~~
|
|
LL | let _ = a == b && c == 5;
|
|
| ~~~~~~~~~~~~~~~~
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:49:13
|
|
|
|
|
LL | let _ = a != b || !(a != b || c == d);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: try
|
|
|
|
|
LL | let _ = !(a == b && c == d);
|
|
| ~~~~~~~~~~~~~~~~~~~
|
|
LL | let _ = a != b || c != d;
|
|
| ~~~~~~~~~~~~~~~~
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:51:13
|
|
|
|
|
LL | let _ = a != b && !(a != b && c == d);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: try
|
|
|
|
|
LL | let _ = !(a == b || c == d);
|
|
| ~~~~~~~~~~~~~~~~~~~
|
|
LL | let _ = a != b && c != d;
|
|
| ~~~~~~~~~~~~~~~~
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:82:8
|
|
|
|
|
LL | if matches!(true, true) && true {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matches!(true, true)`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:162:8
|
|
|
|
|
LL | if !(12 == a) {}
|
|
| ^^^^^^^^^^ help: try: `12 != a`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:163:8
|
|
|
|
|
LL | if !(a == 12) {}
|
|
| ^^^^^^^^^^ help: try: `a != 12`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:164:8
|
|
|
|
|
LL | if !(12 != a) {}
|
|
| ^^^^^^^^^^ help: try: `12 == a`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:165:8
|
|
|
|
|
LL | if !(a != 12) {}
|
|
| ^^^^^^^^^^ help: try: `a == 12`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:169:8
|
|
|
|
|
LL | if !b == true {}
|
|
| ^^^^^^^^^^ help: try: `b != true`
|
|
|
|
error: this comparison might be written more concisely
|
|
--> $DIR/nonminimal_bool.rs:169:8
|
|
|
|
|
LL | if !b == true {}
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `b != true`
|
|
|
|
|
= note: `-D clippy::bool-comparison` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::bool_comparison)]`
|
|
|
|
error: equality checks against true are unnecessary
|
|
--> $DIR/nonminimal_bool.rs:169:8
|
|
|
|
|
LL | if !b == true {}
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `!b`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:170:8
|
|
|
|
|
LL | if !b != true {}
|
|
| ^^^^^^^^^^ help: try: `b == true`
|
|
|
|
error: inequality checks against true can be replaced by a negation
|
|
--> $DIR/nonminimal_bool.rs:170:8
|
|
|
|
|
LL | if !b != true {}
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `!(!b)`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:171:8
|
|
|
|
|
LL | if true == !b {}
|
|
| ^^^^^^^^^^ help: try: `true != b`
|
|
|
|
error: this comparison might be written more concisely
|
|
--> $DIR/nonminimal_bool.rs:171:8
|
|
|
|
|
LL | if true == !b {}
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `true != b`
|
|
|
|
error: equality checks against true are unnecessary
|
|
--> $DIR/nonminimal_bool.rs:171:8
|
|
|
|
|
LL | if true == !b {}
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `!b`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:172:8
|
|
|
|
|
LL | if true != !b {}
|
|
| ^^^^^^^^^^ help: try: `true == b`
|
|
|
|
error: inequality checks against true can be replaced by a negation
|
|
--> $DIR/nonminimal_bool.rs:172:8
|
|
|
|
|
LL | if true != !b {}
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `!(!b)`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:173:8
|
|
|
|
|
LL | if !b == !c {}
|
|
| ^^^^^^^^ help: try: `b == c`
|
|
|
|
error: this boolean expression can be simplified
|
|
--> $DIR/nonminimal_bool.rs:174:8
|
|
|
|
|
LL | if !b != !c {}
|
|
| ^^^^^^^^ help: try: `b != c`
|
|
|
|
error: aborting due to 29 previous errors
|
|
|