mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 21:53:23 +00:00
7820cb1442
* `dst.len()` as the end of the range with loop counters * the increment of the loop counter at the top of the loop
111 lines
3.7 KiB
Text
111 lines
3.7 KiB
Text
error: it looks like you're manually copying between slices
|
|
--> $DIR/with_loop_counters.rs:5:5
|
|
|
|
|
LL | / for i in 3..src.len() {
|
|
LL | | dst[i] = src[count];
|
|
LL | | count += 1;
|
|
LL | | }
|
|
| |_____^ help: try replacing the loop by: `dst[3..src.len()].clone_from_slice(&src[..(src.len() - 3)]);`
|
|
|
|
|
= note: `-D clippy::manual-memcpy` implied by `-D warnings`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/with_loop_counters.rs:11:5
|
|
|
|
|
LL | / for i in 3..src.len() {
|
|
LL | | dst[count] = src[i];
|
|
LL | | count += 1;
|
|
LL | | }
|
|
| |_____^ help: try replacing the loop by: `dst[..(src.len() - 3)].clone_from_slice(&src[3..]);`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/with_loop_counters.rs:17:5
|
|
|
|
|
LL | / for i in 0..src.len() {
|
|
LL | | dst[count] = src[i];
|
|
LL | | count += 1;
|
|
LL | | }
|
|
| |_____^ help: try replacing the loop by: `dst[3..(src.len() + 3)].clone_from_slice(&src[..]);`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/with_loop_counters.rs:23:5
|
|
|
|
|
LL | / for i in 0..src.len() {
|
|
LL | | dst[i] = src[count];
|
|
LL | | count += 1;
|
|
LL | | }
|
|
| |_____^ help: try replacing the loop by: `dst[..src.len()].clone_from_slice(&src[3..(src.len() + 3)]);`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/with_loop_counters.rs:29:5
|
|
|
|
|
LL | / for i in 3..(3 + src.len()) {
|
|
LL | | dst[i] = src[count];
|
|
LL | | count += 1;
|
|
LL | | }
|
|
| |_____^ help: try replacing the loop by: `dst[3..((3 + src.len()))].clone_from_slice(&src[..((3 + src.len()) - 3)]);`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/with_loop_counters.rs:35:5
|
|
|
|
|
LL | / for i in 5..src.len() {
|
|
LL | | dst[i] = src[count - 2];
|
|
LL | | count += 1;
|
|
LL | | }
|
|
| |_____^ help: try replacing the loop by: `dst[5..src.len()].clone_from_slice(&src[(3 - 2)..((src.len() - 2) + 3 - 5)]);`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/with_loop_counters.rs:41:5
|
|
|
|
|
LL | / for i in 0..dst.len() {
|
|
LL | | dst[i] = src[count];
|
|
LL | | count += 1;
|
|
LL | | }
|
|
| |_____^ help: try replacing the loop by: `dst.clone_from_slice(&src[2..(dst.len() + 2)]);`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/with_loop_counters.rs:47:5
|
|
|
|
|
LL | / for i in 3..10 {
|
|
LL | | dst[i] = src[count];
|
|
LL | | count += 1;
|
|
LL | | }
|
|
| |_____^ help: try replacing the loop by: `dst[3..10].clone_from_slice(&src[5..(10 + 5 - 3)]);`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/with_loop_counters.rs:54:5
|
|
|
|
|
LL | / for i in 0..src.len() {
|
|
LL | | dst[count] = src[i];
|
|
LL | | dst2[count2] = src[i];
|
|
LL | | count += 1;
|
|
LL | | count2 += 1;
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: try replacing the loop by
|
|
|
|
|
LL | dst[3..(src.len() + 3)].clone_from_slice(&src[..]);
|
|
LL | dst2[30..(src.len() + 30)].clone_from_slice(&src[..]);
|
|
|
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/with_loop_counters.rs:64:5
|
|
|
|
|
LL | / for i in 0..1 << 1 {
|
|
LL | | dst[count] = src[i + 2];
|
|
LL | | count += 1;
|
|
LL | | }
|
|
| |_____^ help: try replacing the loop by: `dst[(0 << 1)..((1 << 1) + (0 << 1))].clone_from_slice(&src[2..((1 << 1) + 2)]);`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/with_loop_counters.rs:71:5
|
|
|
|
|
LL | / for i in 3..src.len() {
|
|
LL | | dst[i] = src[count];
|
|
LL | | count += 1
|
|
LL | | }
|
|
| |_____^ help: try replacing the loop by: `dst[3..src.len()].clone_from_slice(&src[..(src.len() - 3)]);`
|
|
|
|
error: aborting due to 11 previous errors
|
|
|